Re: Bulk request to backport 12 fixes to 11-dev for 11.0.11

2021-02-23 Thread Johan Vos
Approved. On Mon, Feb 22, 2021 at 6:34 PM Kevin Rushforth wrote: > Hi Johan, > > I request approval to backport the following 12 bug fixes to 11-dev for > FX 11.0.11: > > JDK-8254049: Update WebView to public suffix list 2020-04-24 > JDK-8259635: Update to 610.2 version of WebKit > JDK-8260163:

Re: RFR: 8261221: Tooltip bigger than screen size blinks - shows and hides over and over again

2021-02-23 Thread Ajit Ghaisas
On Fri, 5 Feb 2021 10:46:49 GMT, Paweł Kruszczyński wrote: > `Tooltip` is no longer hiding upon receiving > `MouseEvent.MOUSE_ENTERED_TARGET` event inside it. Pressing mouse on > overlaying tooltip also kills the tooltip, so the infinite duration tooltip > can be closed. modules/javafx.contr

Re: RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners

2021-02-23 Thread Jeanette Winzenburg
On Mon, 22 Feb 2021 20:25:42 GMT, Kevin Rushforth wrote: >> Changes in Lambda..Handler: >> - added api and implemenation to support invalidation and listChange >> listeners in the same way as changeListeners >> - added java doc >> - added tests >> >> Changes in SkinBase >> - added api (and imp

Re: RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners [v2]

2021-02-23 Thread Jeanette Winzenburg
> Changes in Lambda..Handler: > - added api and implemenation to support invalidation and listChange > listeners in the same way as changeListeners > - added java doc > - added tests > > Changes in SkinBase > - added api (and implementation delegating to the handler) > - copied java doc from the

Re: RFR: 8260257: [Linux] WebView no longer reacts to some mouse events

2021-02-23 Thread Kevin Rushforth
On Mon, 22 Feb 2021 15:13:55 GMT, Guru Hb wrote: >> Timer in RunLoopGeneric has an open bug in WebKit >> (https://bugs.webkit.org/show_bug.cgi?id=189335) causing the timer to remain >> active even after firing. >> >> Reverting back to WebCore Timer for ScrollAnimation in Linux. > > Looks good

RFR: 8261840: Submenus close to screen borders are no longer repositioned

2021-02-23 Thread Robert Lichtenberger
Reverting to the old way of showing the context menu but with application of CSS prior to calling prefHeight(-1) / prefWidth(-1) to ensure correct size measurement of the menu. - Commit messages: - 8261840: Submenus close to screen borders are no longer repositioned Changes: https:/

Re: RFR: 8261840: Submenus close to screen borders are no longer repositioned

2021-02-23 Thread Kevin Rushforth
On Tue, 23 Feb 2021 15:32:17 GMT, Robert Lichtenberger wrote: > Reverting to the old way of showing the context menu but with application > of CSS prior to calling prefHeight(-1) / prefWidth(-1) to ensure correct > size measurement of the menu. modules/javafx.controls/src/main/java/javafx/scene

RFR: 8262236: Configure Gradle checksum verification

2021-02-23 Thread John Neffenger
The recent supply-chain attacks in the news are making me nervous! 😟 The Gradle 6.3 distribution is the only software on my OpenJFX build system that doesn't come from an Ubuntu package or a GitHub repository. Ubuntu uses digital signatures to authenticate each package, and Git uses a secure has

Re: RFR: 8262236: Configure Gradle checksum verification

2021-02-23 Thread Kevin Rushforth
On Tue, 23 Feb 2021 17:25:47 GMT, John Neffenger wrote: > The recent supply-chain attacks in the news are making me nervous! 😟 > > The Gradle 6.3 distribution is the only software on my OpenJFX build system > that doesn't come from an Ubuntu package or a GitHub repository. Ubuntu uses > digit

Re: RFR: 8260468: Wrong behavior of LocalDateTimeStringConverter [v2]

2021-02-23 Thread Pankaj Bansal
On Wed, 10 Feb 2021 02:24:57 GMT, Nir Lisker wrote: >> Fixes a mutability issue for `LocalDateTimeStringConverter` (and >> `LocalDateStringConverter`) where the chronology can change during the >> lifetime of the instance and cause an inconsistent state. The following >> changes were made: >>

Integrated: 8260468: Wrong behavior of LocalDateTimeStringConverter

2021-02-23 Thread Nir Lisker
On Thu, 4 Feb 2021 20:01:10 GMT, Nir Lisker wrote: > Fixes a mutability issue for `LocalDateTimeStringConverter` (and > `LocalDateStringConverter`) where the chronology can change during the > lifetime of the instance and cause an inconsistent state. The following > changes were made: > > * T

Re: RFR: 8262236: Configure Gradle checksum verification

2021-02-23 Thread John Neffenger
On Tue, 23 Feb 2021 17:45:53 GMT, Kevin Rushforth wrote: > I presume that just adding the checksum will enable the validation? It does in my tests. See the section "Steps to Reproduce" in the bug report for details. It would be nice to see a message that the distribution was validated successf

Re: RFR: 8262236: Configure Gradle checksum verification

2021-02-23 Thread Kevin Rushforth
On Tue, 23 Feb 2021 17:25:47 GMT, John Neffenger wrote: > The recent supply-chain attacks in the news are making me nervous! 😟 > > The Gradle 6.3 distribution is the only software on my OpenJFX build system > that doesn't come from an Ubuntu package or a GitHub repository. Ubuntu uses > digit

Re: RFR: 8262236: Configure Gradle checksum verification

2021-02-23 Thread John Neffenger
On Tue, 23 Feb 2021 17:48:08 GMT, Kevin Rushforth wrote: > > We might also consider adding the [Gradle Wrapper > > Validation](https://github.com/marketplace/actions/gradle-wrapper-validation) > > GitHub Action to the OpenJFX repository. > > Feel free to file a bug and create a PR, if you are

Re: RFR: 8262236: Configure Gradle checksum verification

2021-02-23 Thread Kevin Rushforth
On Tue, 23 Feb 2021 18:57:59 GMT, Kevin Rushforth wrote: >> The recent supply-chain attacks in the news are making me nervous! 😟 >> >> The Gradle 6.3 distribution is the only software on my OpenJFX build system >> that doesn't come from an Ubuntu package or a GitHub repository. Ubuntu uses >>

Re: RFR: 8262236: Configure Gradle checksum verification

2021-02-23 Thread John Neffenger
On Tue, 23 Feb 2021 19:04:47 GMT, Kevin Rushforth wrote: > My reading of it > [here](https://github.com/marketplace/actions/gradle-wrapper-validation#add-to-an-existing-workflow) > is that we would add this action as a step to our workflow script, which is > in > [.github/workflows/submit.yml

Integrated: 8262236: Configure Gradle checksum verification

2021-02-23 Thread John Neffenger
On Tue, 23 Feb 2021 17:25:47 GMT, John Neffenger wrote: > The recent supply-chain attacks in the news are making me nervous! 😟 > > The Gradle 6.3 distribution is the only software on my OpenJFX build system > that doesn't come from an Ubuntu package or a GitHub repository. Ubuntu uses > digit

Re: RFR: 8260257: [Linux] WebView no longer reacts to some mouse events [v2]

2021-02-23 Thread Arun Joseph
> Timer in RunLoopGeneric has an open bug in WebKit > (https://bugs.webkit.org/show_bug.cgi?id=189335) causing the timer to remain > active even after firing. > > Reverting back to WebCore Timer for ScrollAnimation in Linux. Arun Joseph has updated the pull request incrementally with one additi