On Sat, 10 Apr 2021 15:01:08 GMT, Kevin Rushforth wrote:
>> I'm currently rerunning tests and preparing and update - further analysis
>> showed, that thread attachment is handled in
>> `WebCore::StorageThread::threadEntryPoint()`:
>>
>>
On Wed, 26 Feb 2020 07:37:06 GMT, yosbits
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8197991
>
> The performance of the selectAll and selectRange methods of the
> MultiSelectionModel class has been greatly improved.
>
> This greatly improves the response when selecting multiple items
https://bugs.openjdk.java.net/browse/JDK-8197991
The performance of the selectAll and selectRange methods of the
MultiSelectionModel class has been greatly improved.
This greatly improves the response when selecting multiple items in ListView
and TableView.
However, in TreeView /
On Wed, 26 Feb 2020 07:37:06 GMT, yosbits
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8197991
>
> The performance of the selectAll and selectRange methods of the
> MultiSelectionModel class has been greatly improved.
>
> This greatly improves the response when selecting multiple items
If there are many columns, the current TableView will stall scrolling.
Resolving this performance issue requires column virtualization. Virtualization
mode is enabled when the row height is fixed by the following method.
`tableView.setFixedCellSize(height)`
This proposal includes a fix because
On Mon, 24 Feb 2020 07:39:43 GMT, yosbits
wrote:
> If there are many columns, the current TableView will stall scrolling.
> Resolving this performance issue requires column virtualization.
> Virtualization mode is enabled when the row height is fixed by the following
> method.
>
>
Did the thread dump created using the debug build helped with understanding
of what the issue was?
— PrimosK
On Tue, 23 Mar 2021 at 18:53, Arun Joseph wrote:
> The thread dump doesn’t have enough details to locate where the problem
> occurs. Using a debug build with assertions disabled (as
> The method `ControlAcceleratorSupport.doAcceleratorInstall(final List extends MenuItem> items, final Scene scene)` adds a `ChangeListener` on
> `MenuItem.acceleratorProperty()`. This listener is not removed when the
> MenuItem is removed from scenegraph.
> Adding and removing a MenuItem
I think the issue is caused by the JNI call in isMainThread() function in
MainThreadJava.cpp and one solution would be to use the respective native calls
for each platforms. I’ll create a PR with the above fix shortly after
performing a couple of sanity checks.
— Arun Joseph
On 12-Apr-2021,
On Fri, 9 Apr 2021 22:29:39 GMT, Kevin Rushforth wrote:
>> This PR introduces a refactory for VirtualFlow, fixing a number of issues
>> reported about inconsistent scrolling speed (see
>> https://bugs.openjdk.java.net/browse/JDK-8089589)
>> The problem mentioned in the JBS issue (and in
> Changes in Lambda..Handler:
> - added api and implemenation to support invalidation and listChange
> listeners in the same way as changeListeners
> - added java doc
> - added tests
>
> Changes in SkinBase
> - added api (and implementation delegating to the handler)
> - copied java doc from
On Wed, 26 Feb 2020 07:37:06 GMT, yosbits
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8197991
>
> The performance of the selectAll and selectRange methods of the
> MultiSelectionModel class has been greatly improved.
>
> This greatly improves the response when selecting multiple items
On Fri, 9 Apr 2021 22:27:47 GMT, Kevin Rushforth wrote:
>> This PR introduces a refactory for VirtualFlow, fixing a number of issues
>> reported about inconsistent scrolling speed (see
>> https://bugs.openjdk.java.net/browse/JDK-8089589)
>> The problem mentioned in the JBS issue (and in
On Fri, 9 Apr 2021 22:32:28 GMT, Kevin Rushforth wrote:
>> This PR introduces a refactory for VirtualFlow, fixing a number of issues
>> reported about inconsistent scrolling speed (see
>> https://bugs.openjdk.java.net/browse/JDK-8089589)
>> The problem mentioned in the JBS issue (and in
On Mon, 24 Feb 2020 07:39:43 GMT, yosbits
wrote:
> If there are many columns, the current TableView will stall scrolling.
> Resolving this performance issue requires column virtualization.
> Virtualization mode is enabled when the row height is fixed by the following
> method.
>
>
On Sat, 10 Apr 2021 14:58:14 GMT, Kevin Rushforth wrote:
> I'd recommend to get rid of the indirect way of testing
I have removed the indirect way, please take a look.
-
PR: https://git.openjdk.java.net/jfx/pull/429
On Mon, 14 Sep 2020 10:03:59 GMT, Ajit Ghaisas wrote:
> Can you please provide an automated test along with your fix?
Automated performance testing should be distinguished from regular testing
tasks, as it extends the build time.
Is there a task name for that in gradle?
Also, didn't you
On Mon, 12 Apr 2021 09:32:27 GMT, Johan Vos wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java
>> line 2972:
>>
>>> 2970: // Make sure we have enough space in the cache to store this
>>> index
>>> 2971: while (idx >=
On Mon, 12 Apr 2021 09:41:03 GMT, Johan Vos wrote:
>> This PR introduces a refactory for VirtualFlow, fixing a number of issues
>> reported about inconsistent scrolling speed (see
>> https://bugs.openjdk.java.net/browse/JDK-8089589)
>> The problem mentioned in the JBS issue (and in related
On Mon, 12 Apr 2021 08:40:56 GMT, Ambarish Rapte wrote:
>> The method `ControlAcceleratorSupport.doAcceleratorInstall(final List> extends MenuItem> items, final Scene scene)` adds a `ChangeListener` on
>> `MenuItem.acceleratorProperty()`. This listener is not removed when the
>> MenuItem is
On Wed, 7 Apr 2021 13:11:52 GMT, Nir Lisker wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> updated doc of list/Change methods that of invalidation methods
>
>
On Mon, 12 Apr 2021 10:39:07 GMT, Jeanette Winzenburg
wrote:
>> Changes in Lambda..Handler:
>> - added api and implemenation to support invalidation and listChange
>> listeners in the same way as changeListeners
>> - added java doc
>> - added tests
>>
>> Changes in SkinBase
>> - added api
On Mon, 12 Apr 2021 12:02:20 GMT, Jeanette Winzenburg
wrote:
> created a csr draft
> [JDK-8265063](https://bugs.openjdk.java.net/browse/JDK-8265063) - waiting for
> all monsters in hell breaking out and heavens falling down ;-)
The Draft CSR looks good, and should keep the monsters
On Mon, 12 Apr 2021 10:39:07 GMT, Jeanette Winzenburg
wrote:
>> Changes in Lambda..Handler:
>> - added api and implemenation to support invalidation and listChange
>> listeners in the same way as changeListeners
>> - added java doc
>> - added tests
>>
>> Changes in SkinBase
>> - added api
On Mon, 12 Apr 2021 13:24:18 GMT, Kevin Rushforth wrote:
>
> The Draft CSR looks good, and should keep the monsters contained. Go ahead
> and move it to Proposed.
thanks, done :) Also updated to the most recent state (including Nir's
suggestion).
-
PR:
On Mon, 24 Feb 2020 07:39:43 GMT, yosbits
wrote:
> If there are many columns, the current TableView will stall scrolling.
> Resolving this performance issue requires column virtualization.
> Virtualization mode is enabled when the row height is fixed by the following
> method.
>
>
On Mon, 31 Aug 2020 19:16:31 GMT, yosbits
wrote:
>
>
> Since there was a problem that the cell was not updated when the window was
> maximized, I added a fix to TreeTableViewSkin.java.
>
that's just the added listener to hbar properties (same as in TableViewSkin),
or anything else
On Wed, 26 Feb 2020 07:37:06 GMT, yosbits
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8197991
>
> The performance of the selectAll and selectRange methods of the
> MultiSelectionModel class has been greatly improved.
>
> This greatly improves the response when selecting multiple items
On Thu, 3 Sep 2020 07:44:55 GMT, yosbits
wrote:
>> If there are many columns, the current TableView will stall scrolling.
>> Resolving this performance issue requires column virtualization.
>> Virtualization mode is enabled when the row height is fixed by the following
>> method.
>>
>>
On Wed, 26 Feb 2020 07:37:06 GMT, yosbits
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8197991
>
> The performance of the selectAll and selectRange methods of the
> MultiSelectionModel class has been greatly improved.
>
> This greatly improves the response when selecting multiple items
On Mon, 24 Feb 2020 07:39:43 GMT, yosbits
wrote:
> If there are many columns, the current TableView will stall scrolling.
> Resolving this performance issue requires column virtualization.
> Virtualization mode is enabled when the row height is fixed by the following
> method.
>
>
On Wed, 26 Feb 2020 07:37:06 GMT, yosbits
wrote:
> https://bugs.openjdk.java.net/browse/JDK-8197991
>
> The performance of the selectAll and selectRange methods of the
> MultiSelectionModel class has been greatly improved.
>
> This greatly improves the response when selecting multiple items
> This PR introduces a refactory for VirtualFlow, fixing a number of issues
> reported about inconsistent scrolling speed (see
> https://bugs.openjdk.java.net/browse/JDK-8089589)
> The problem mentioned in the JBS issue (and in related issues) is that the
> VirtualFlow implementation depends on
On Tue, 9 Feb 2021 12:21:28 GMT, Johan Vos wrote:
> This PR introduces a refactory for VirtualFlow, fixing a number of issues
> reported about inconsistent scrolling speed (see
> https://bugs.openjdk.java.net/browse/JDK-8089589)
> The problem mentioned in the JBS issue (and in related issues)
On Fri, 9 Apr 2021 22:12:54 GMT, Kevin Rushforth wrote:
>> Johan Vos has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Process reviewer comments
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java
> line
On Mon, 12 Apr 2021 13:59:13 GMT, Nir Lisker wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> replaced param name in changeListener methods
>
>
> Each test in RegionBackgroundImageUITest makes several calls to
> `robot.getPixelColor()` on App thread. Due to this each test requires more
> than **60** seconds for execution.
>
> Fix is to save a screen capture of Scene (on App thread) and then read pixel
> color from the screen
> Changes in Lambda..Handler:
> - added api and implemenation to support invalidation and listChange
> listeners in the same way as changeListeners
> - added java doc
> - added tests
>
> Changes in SkinBase
> - added api (and implementation delegating to the handler)
> - copied java doc from
On Sun, 4 Apr 2021 16:36:27 GMT, John Neffenger wrote:
>> This pull request allows for reproducible builds of JavaFX on Linux, macOS,
>> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For
>> example, the following commands create a reproducible build:
>>
>>
>> $ export
On Mon, 12 Apr 2021 07:50:39 GMT, Johan Vos wrote:
>> Matthias Bläsing has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert changes to thread attachment introduced in second commit
>>
>> Thread attachment is handled in
>>
>>
On Thu, 8 Apr 2021 17:21:43 GMT, Kevin Rushforth wrote:
> This updates the compiler used to build JavaFX on macOS to Xcode 12.4 (which
> includes the MacOSX11.1 sdk), which matches the compiler that will be used to
> build JDK 17, once openjdk/jdk#3388 is integrated.
>
> As noted in the bug
On Mon, 12 Apr 2021 07:50:39 GMT, Johan Vos wrote:
> I understand the crash would be at a different point, but it would still be a
> crash, I think? That is, if the method handlers are correctly registered via
> the OnLoad function, and later a new native thread tries to access a function
>
On Mon, 12 Apr 2021 16:09:08 GMT, Matthias Bläsing
wrote:
> The question is: Is there a second issue?
If we don't have an example where a thread that isn't attached to the JVM
already calls into these APIs, then it seems like the second issue is just
hypothetical.
In any case, it seems best
On Thu, 25 Mar 2021 17:41:40 GMT, Martin Fox
wrote:
>> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as
>> expected by more accurately mapping from a Mac key code to a Java key code
>> based on the user’s active keyboard layout (the existing code assumes a US
>> QWERTY
On Wed, 24 Mar 2021 19:45:55 GMT, John Neffenger wrote:
>> This pull request adds dependency verification to the Gradle builds of
>> JavaFX on Linux, macOS, and Windows. It is the third of three changes that
>> close the gaps in the JavaFX build security:
>>
>> * [JDK-8262236][1]: Configure
As noted in the JBS bug, the minimum macOS version on which JavaFX will run is
currently set to 10.10 in `mac.gradle`. macOS 10.10 is many years out of
support, so we should update this minimum. Further, macOS / aarch64 (aka arm64)
requires macOS 11.0 as a minimum in order to run.
The JDK
The proposed fix for JDK-8265031 [1], which is under review as PR #462
[2], will bump the minimum version of macOS on which JavaFX will run to
10.12 (for x86_64 systems) to match the minimum version that the JDK
will run on. After this fix is integrated, builds of JavaFX will no
longer run on
On Wed, 24 Mar 2021 19:45:55 GMT, John Neffenger wrote:
>> This pull request adds dependency verification to the Gradle builds of
>> JavaFX on Linux, macOS, and Windows. It is the third of three changes that
>> close the gaps in the JavaFX build security:
>>
>> * [JDK-8262236][1]: Configure
48 matches
Mail list logo
