Re: RFR: 8267094: TreeCell: cancelEvent must return correct editing location [v2]

2021-06-01 Thread Jeanette Winzenburg
> the bug is an incorrect edit location (for tree: treeItem) in edit cancel > events - expected is the location at the time the cell edit was started, > actual was the location of at the time the edit was cancelled. See the report > for details. > > Fixed by storing the edit location in startEd

Re: RFR: 8267418: IntelliJ build and test of JavaFX does not work [v3]

2021-06-01 Thread Ambarish Rapte
On Sat, 29 May 2021 21:09:33 GMT, Marius Hanl wrote: >> ~~Question: I was wondering, should I create a ticket for this as well? >> Given the fact that I don't have an https://bugs.openjdk.java.net account, I >> need to use the official bug reporting tool, which looked a bit overkill to >> me

platformWidth

2021-06-01 Thread Johan Vos
Hi, com.sun.glass.ui.Screen has 3 width (and height) parameters, each with a getter: * width * visibleWidth * platformWidth The latter seems to be used only in the windows build, via screen.containsPlatformRect and screen.portionIntersectsPlatformRect I don't really understand what the goal of t

Re: RFR: 8239138: StyleManager should use a BufferedInputStream [v4]

2021-06-01 Thread Kevin Rushforth
On Mon, 31 May 2021 06:37:40 GMT, Ambarish Rapte wrote: >> `StyleManager.calculateCheckSum()` uses a raw InputStream as the input to a >> `DigestInputStream` and reads one byte at a time. This is slower in >> performance and should be changed, either to use `BufferedInputStream` or >> read byt

Integrated: 8239138: StyleManager should use a BufferedInputStream

2021-06-01 Thread Ambarish Rapte
On Tue, 25 May 2021 09:04:07 GMT, Ambarish Rapte wrote: > `StyleManager.calculateCheckSum()` uses a raw InputStream as the input to a > `DigestInputStream` and reads one byte at a time. This is slower in > performance and should be changed, either to use `BufferedInputStream` or > read byte bu

Re: RFR: 8196065: ListChangeListener getRemoved() returns items that were not removed. [v8]

2021-06-01 Thread Michael Strauß
On Sat, 29 May 2021 12:31:33 GMT, Michael Strauß wrote: >> The documentation for `ObservableListBase.nextRemove` states that a single >> change always refers to the current state of the list, which likely means >> that multiple disjoint removed ranges need to be applied in order, otherwise >>

RFR: 8263095: Provide a way for a custom control to indicate that its userAgentStyleSheet has changed

2021-06-01 Thread Alessadro Parisi
This change allows custom control to change their style dynamically When the user-agent stylesheet changes the property automatically calls `NodeHelper.reapplyCSS(Region.this);` to recompute the CSS for the node and its children. To make this work the StyleManager class must be fixed too. The lin

Re: RFR: 8263095: Provide a way for a custom control to indicate that its userAgentStyleSheet has changed

2021-06-01 Thread Alessadro Parisi
On Mon, 31 May 2021 13:57:22 GMT, Alessadro Parisi wrote: > This change allows custom control to change their style dynamically > When the user-agent stylesheet changes the property automatically calls > `NodeHelper.reapplyCSS(Region.this);` to recompute the CSS for the node and > its children

Re: RFR: 8263095: Provide a way for a custom control to indicate that its userAgentStyleSheet has changed

2021-06-01 Thread Nir Lisker
On Mon, 31 May 2021 13:57:22 GMT, Alessadro Parisi wrote: > This change allows custom control to change their style dynamically > When the user-agent stylesheet changes the property automatically calls > `NodeHelper.reapplyCSS(Region.this);` to recompute the CSS for the node and > its children