Re: RFR: 8273485: Deadlock when also using Swing and exiting Fullscreen on Mac [v5]

2021-09-28 Thread Florian Kirmaier
> When using Swing it's possible to generate a Deadlock. > It's related to the nested eventloop started in enterFullScreenExitingLoop - > and the RenderLock aquired when using setView in Scene. > Sample Programm and Threaddump are added to the ticket. > > Removing the nested loop fixes the

Re: RFR: 8273485: Deadlock when also using Swing and exiting Fullscreen on Mac [v6]

2021-09-28 Thread Florian Kirmaier
On Tue, 28 Sep 2021 12:07:36 GMT, Florian Kirmaier wrote: >> When using Swing it's possible to generate a Deadlock. >> It's related to the nested eventloop started in enterFullScreenExitingLoop >> - and the RenderLock aquired when using setView in Scene. >> Sample Programm and Threaddump are

Re: RFR: 8273485: Deadlock when also using Swing and exiting Fullscreen on Mac [v4]

2021-09-28 Thread Florian Kirmaier
On Fri, 17 Sep 2021 12:51:53 GMT, Kevin Rushforth wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8273485 >> small cleanup of the changes. > > You can also see the exception with _any_ JavaFX program:

Re: RFR: 8273485: Deadlock when also using Swing and exiting Fullscreen on Mac [v6]

2021-09-28 Thread Florian Kirmaier
> When using Swing it's possible to generate a Deadlock. > It's related to the nested eventloop started in enterFullScreenExitingLoop - > and the RenderLock aquired when using setView in Scene. > Sample Programm and Threaddump are added to the ticket. > > Removing the nested loop fixes the

Re: RFR: 8188026: TextFieldXXCell: NPE on calling startEdit [v4]

2021-09-28 Thread Jeanette Winzenburg
On Sun, 26 Sep 2021 12:05:11 GMT, Jeanette Winzenburg wrote: > the other way round: a cell that didn't switch into editing will nevertheless > fire a editStart on its target FYI: filed [JDK-8274433](https://bugs.openjdk.java.net/browse/JDK-8274433) - PR:

Re: RFR: 8214158: Implement HostServices.showDocument on macOS without calling AWT

2021-09-28 Thread Michael Paus
On Tue, 28 Sep 2021 16:06:30 GMT, Michael Paus wrote: > Fixes the issue by using the "open" command as discussed before. > See: https://bugs.openjdk.java.net/browse/JDK-8214158 To answer your questions: 1. I have no idea about LSOpenURLsWithRole. I am not a Mac developer. 2. I have manually

Re: RFR: 8214158: Implement HostServices.showDocument on macOS without calling AWT

2021-09-28 Thread Kevin Rushforth
On Tue, 28 Sep 2021 16:06:30 GMT, Michael Paus wrote: > Fixes the issue by using the "open" command as discussed before. > See: https://bugs.openjdk.java.net/browse/JDK-8214158 This seems like a good RFE. I have a couple overall questions. First, calling `open` was originally proposed in the

Re: RFR: 8214158: Implement HostServices.showDocument on macOS without calling AWT

2021-09-28 Thread Michael Paus
On Tue, 28 Sep 2021 16:06:30 GMT, Michael Paus wrote: > Fixes the issue by using the "open" command as discussed before. > See: https://bugs.openjdk.java.net/browse/JDK-8214158 First of all. Shall I follow the bot request above and create a new pull request? Wouldn't we loose the discussion

RFR: 8214158: Implement HostServices.showDocument on macOS without calling AWT

2021-09-28 Thread Michael Paus
Fixes the issue by using the "open" command as discussed before. See: https://bugs.openjdk.java.net/browse/JDK-8214158 - Commit messages: - Remove dependency on java.awt.Desktop Changes: https://git.openjdk.java.net/jfx/pull/634/files Webrev:

RFR: 8273743: KeyCharacterCombination for "+" does not work on US QWERTY keyboard layout

2021-09-28 Thread Martin Fox
There was a mismatch between the way `get_glass_key` generated the Java key code for a given key press and how `getKeyCodeForChar` determined the key code for the matching character. For example, when pressing the plus sign on a US keyboard `get_glass_key` correctly generated `KeyCode.EQUALS`

RFR: 8267606: Style classes not always working

2021-09-28 Thread Alessandro Parisi
Can we have a look at this report please? I'm having this issue more and more often when making custom controls JBS

Aw: RFR: 8267606: Style classes not always working

2021-09-28 Thread Marius Hanl
It would be very helpful if you could provide a minimum reproducable example. So really just the code which is necessary for all of us to reproduce it. Am 29.09.21, 00:06 schrieb Alessandro Parisi : Can we have a look at this report please? I'm having this issue more and

Transparent stages and AnimationTimer on Windows

2021-09-28 Thread John Hendrikx
I'm seeing some really weird issues with Transparent Stages on Windows when their framerate (both stability and speed) is compared with normal decorated/undecorated stages. The transparent stages seem to obey different rules when it comes to timely firing AnimationTimers. Where a decorated