Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v3]

2021-10-12 Thread Thiago Milczarek Sayao
On Tue, 12 Oct 2021 15:16:53 GMT, Pankaj Bansal wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java >> line 861: >> >>> 859: >>> 860: // walk backwards to find a blocker >>> 861: for (int i = activeWindows.size() - 1; i > 0; i--) { >> >>

Re: RFR: Draft: 8274274: Update JavaFX test framework to JUnit 5 [v5]

2021-10-12 Thread John Hendrikx
On Sat, 25 Sep 2021 13:55:15 GMT, John Hendrikx wrote: >> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests >> still work. Also added a single JUnit 5 tests, and confirmed it works. >> >> I've updated the Eclipse project file for the base module only. > > John

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v3]

2021-10-12 Thread Kevin Rushforth
On Wed, 22 Sep 2021 16:39:15 GMT, Thiago Milczarek Sayao wrote: >> Found the problem thru this path: >> >> **WindowStage.java** >> >> final void handleFocusDisabled() { >> if (activeWindows.isEmpty()) { >> return; >> } >> WindowStage window =

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v3]

2021-10-12 Thread Kevin Rushforth
On Wed, 22 Sep 2021 16:39:15 GMT, Thiago Milczarek Sayao wrote: >> Found the problem thru this path: >> >> **WindowStage.java** >> >> final void handleFocusDisabled() { >> if (activeWindows.isEmpty()) { >> return; >> } >> WindowStage window =

Re: RFR: 8271054: [REDO] Wrong stage gets focused after modal stage creation [v3]

2021-10-12 Thread Pankaj Bansal
On Tue, 12 Oct 2021 15:12:43 GMT, Kevin Rushforth wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Break if reach self > > modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/WindowStage.java