On Mon, 15 Nov 2021 18:26:00 GMT, Kevin Rushforth wrote:
> Now that JavaFX has updated to gradle 7.3 -- see
> [JDK-8276142](https://bugs.openjdk.java.net/browse/JDK-8276142) / PR #671 --
> we can update the boot JDK used to build JavaFX to JDK 17.0.1.
>
> I have run a smoke test on all three p
On Mon, 15 Nov 2021 13:11:06 GMT, Jeanette Winzenburg
wrote:
>> Cleanup of Tree-/TableRowSkin to support switching skins
>>
>> The misbehavior/s
>> - memory leaks due to manually registered listeners that were not removed
>> - side-effects due to listeners still active on old skin (like NPEs)
>
On Mon, 15 Nov 2021 13:28:40 GMT, Jeanette Winzenburg
wrote:
>> My PR is already merged, so this is not a problem. :)
>> I dont know, but since this is only fixing a (also before) wrong comment it
>> might be okay as it is very minor? :)
>
> FYI: now the listener registration - including the in
On Mon, 15 Nov 2021 18:26:00 GMT, Kevin Rushforth wrote:
> Now that JavaFX has updated to gradle 7.3 -- see
> [JDK-8276142](https://bugs.openjdk.java.net/browse/JDK-8276142) / PR #671 --
> we can update the boot JDK used to build JavaFX to JDK 17.0.1.
>
> I have run a smoke test on all three p
On Thu, 18 Nov 2021 17:02:19 GMT, Andreas Heger wrote:
>> By changing the value for the clang -arch parameter to "arm64", the jfx
>> project compiles on an apple silicon system. Are there any side effects
>> which I might be missing in this simple solution?
>
> Andreas Heger has updated the pul
On Fri, 19 Nov 2021 09:45:06 GMT, Ajit Ghaisas wrote:
>> FYI: now the listener registration - including the incorrect code comment
>> (which is the same as in current master) - is back at the old location in
>> the re-inserted setupTreeTableViewListeners. So still need input whether
>> it's ok
On Fri, 19 Nov 2021 09:24:42 GMT, Ajit Ghaisas wrote:
>> Jeanette Winzenburg has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> reverted fixedCellSize handling
>
> modules/javafx.controls/src/shims/java/javafx/scene/control/skin/TableSkinSh
> Cleanup of Tree-/TableRowSkin to support switching skins
>
> The misbehavior/s
> - memory leaks due to manually registered listeners that were not removed
> - side-effects due to listeners still active on old skin (like NPEs)
>
> Fix
> - use skin api for all listener registration (for automatic
On Thu, 18 Nov 2021 21:38:28 GMT, Kevin Rushforth wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>> good test coverage.
>>
>> This
On Fri, 19 Nov 2021 11:42:16 GMT, Jeanette Winzenburg
wrote:
>> Cleanup of Tree-/TableRowSkin to support switching skins
>>
>> The misbehavior/s
>> - memory leaks due to manually registered listeners that were not removed
>> - side-effects due to listeners still active on old skin (like NPEs)
>
On Mon, 15 Nov 2021 18:26:00 GMT, Kevin Rushforth wrote:
> Now that JavaFX has updated to gradle 7.3 -- see
> [JDK-8276142](https://bugs.openjdk.java.net/browse/JDK-8276142) / PR #671 --
> we can update the boot JDK used to build JavaFX to JDK 17.0.1.
>
> I have run a smoke test on all three p
On Mon, 15 Nov 2021 14:34:04 GMT, Marius Hanl wrote:
> When a divider is moved via drag or code it will call **requestLayout()** for
> the **SplitPane**.
> While this is fine, it is also called when the
> **SplitPaneSkin#layoutChildren(..)** method is repositioning the divider.
>
> This makes
On Mon, 15 Nov 2021 18:26:00 GMT, Kevin Rushforth wrote:
> Now that JavaFX has updated to gradle 7.3 -- see
> [JDK-8276142](https://bugs.openjdk.java.net/browse/JDK-8276142) / PR #671 --
> we can update the boot JDK used to build JavaFX to JDK 17.0.1.
>
> I have run a smoke test on all three p
On Thu, 18 Nov 2021 17:02:19 GMT, Andreas Heger wrote:
>> By changing the value for the clang -arch parameter to "arm64", the jfx
>> project compiles on an apple silicon system. Are there any side effects
>> which I might be missing in this simple solution?
>
> Andreas Heger has updated the pul
On Fri, 19 Nov 2021 10:39:05 GMT, Johan Vos wrote:
> We don't have specific flags that we pass to build webkit, so having the
> TARGET_ARCH set to arm64 in one way or another should be sufficient.
I'll check my build environment and file a follow-up issue if needed.
-
PR: https://
On Thu, 18 Nov 2021 17:02:19 GMT, Andreas Heger wrote:
>> By changing the value for the clang -arch parameter to "arm64", the jfx
>> project compiles on an apple silicon system. Are there any side effects
>> which I might be missing in this simple solution?
>
> Andreas Heger has updated the pul
On Fri, 19 Nov 2021 14:06:28 GMT, Johan Vos wrote:
> The TARGET_CPU is never changed, and the MACHINE_FLAG is the one being passed
> to the compiler.
This does seem a cleaner approach. I'll file a follow-on issue to track this
(which wouldn't just be limited to macOS).
-
PR: http
On Thu, 18 Nov 2021 17:02:19 GMT, Andreas Heger wrote:
>> By changing the value for the clang -arch parameter to "arm64", the jfx
>> project compiles on an apple silicon system. Are there any side effects
>> which I might be missing in this simple solution?
>
> Andreas Heger has updated the pul
18 matches
Mail list logo
