On Mon, 6 Dec 2021 09:23:53 GMT, eduardsdv wrote:
> I tested it again. Without the changes in this PR the bug is still there.
> **If the item is larger than the viewport**, the VirtualFlow.scrollToTop(int)
> scrolls to the end instead of to top of the item.
ahhh .. finally I understand what
On Mon, 6 Dec 2021 08:22:37 GMT, eduardsdv wrote:
>> Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last
>> element but to the bottom of the last element.
>
> eduardsdv has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev
On Fri, 20 Aug 2021 05:15:49 GMT, Michael Strauß wrote:
>> This PR adds the `Node.focusVisible` and `Node.focusWithin` properties, as
>> well as the corresponding `:focus-visible` and `:focus-within` CSS
>> pseudo-classes.
>
> Michael Strauß has updated the pull request incrementally with one
On Mon, 6 Dec 2021 11:26:24 GMT, Jeanette Winzenburg
wrote:
>> I tested it again. Without the changes in this PR the bug is still there.
>> If the item is larger than the viewport, the VirtualFlow.scrollToTop(int)
>> scrolls to the end instead of to top of the item.
>
>> I tested it again.
On Mon, 6 Dec 2021 09:23:53 GMT, eduardsdv wrote:
>> eduardsdv has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains two additional commits
>> since
On Tue, 2 Nov 2021 10:49:45 GMT, Michael Strauß wrote:
> This PR fixes an issue where the scroll delta of ScrollPane incorrectly
> depends on the size of its content.
> This leads to extremely slow scrolling when the content is only slightly
> larger than the ScrollPane.
This pull request has
On Mon, 2 Aug 2021 13:20:29 GMT, Michael Strauß wrote:
> > 3. I think the way you are propagating `focusWithin` might not work if
> > nodes are added or removed from the scene graph.
>
> I've added a test for this case:
> `FocusTest.testFocusStatesAreClearedFromFormerParentsOfFocusedNode`.
On Mon, 6 Dec 2021 14:58:52 GMT, eduardsdv wrote:
>> Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last
>> element but to the bottom of the last element.
>
> eduardsdv has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
> Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last
> element but to the bottom of the last element.
eduardsdv has updated the pull request incrementally with one additional commit
since the last revision:
8276170: Add junit for VirtualFlow.scrollToTop(int)
On Mon, 6 Dec 2021 13:05:16 GMT, Jeanette Winzenburg
wrote:
> might also need a test that verifies the focusWithin of a parent added
> somewhere above the focused node? hmm .. or maybe not, that would require to
> re-arrange a complete subtree ..
Inserting a parent into a scene graph such
On Thu, 2 Dec 2021 22:49:45 GMT, Michael Strauß wrote:
>> This PR fixes an issue where the scroll delta of ScrollPane incorrectly
>> depends on the size of its content.
>> This leads to extremely slow scrolling when the content is only slightly
>> larger than the ScrollPane.
>
> Michael Strauß
> Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last
> element but to the bottom of the last element.
eduardsdv has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the
12 matches
Mail list logo
