> This is an implementation of the proposal in
> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
> (@nlisker) have been working on. It's a complete implementation including
> good test coverage.
>
> This was based on https://github.com/openjdk/jfx/pull/434 but with a
On Wed, 15 Dec 2021 11:36:23 GMT, John Hendrikx wrote:
>> This is an implementation of the proposal in
>> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
>> (@nlisker) have been working on. It's a complete implementation including
>> good test coverage.
>>
>> This w
> This is an implementation of the proposal in
> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker
> (@nlisker) have been working on. It's a complete implementation including
> good test coverage.
>
> This was based on https://github.com/openjdk/jfx/pull/434 but with a
Hi,
The separation between Glass and Prism is slightly broken by Monocle and
that restricts the number of possible combinations.
I wonder if there are any known cases where the glass platform is set to
Monocle, but where prism is expected to use X11? That sounds like a
contradiction, as Monocle is
I wonder if there are any known cases where the glass platform is set to
Monocle, but where prism is expected to use X11? That sounds like a
contradiction
Agreed that this seems like a mismatch.
I suggest we remove the "embedded" property and the
PlatforumUtil.getEmbeddedType() method (note
On Wed, Dec 15, 2021 at 3:53 PM Kevin Rushforth
wrote:
>
> > I wonder if there are any known cases where the glass platform is set to
> > Monocle, but where prism is expected to use X11? That sounds like a
> > contradiction
>
> Agreed that this seems like a mismatch.
>
> > I suggest we remove the
Sounds good.
-- Kevin
On 12/15/2021 8:04 AM, Johan Vos wrote:
On Wed, Dec 15, 2021 at 3:53 PM Kevin Rushforth
wrote:
> I wonder if there are any known cases where the glass platform
is set to
> Monocle, but where prism is expected to use X11? That sounds like a
> contrad
Base decisions in prism for embedded cases on the same glass.platform property
that is also used in glass.
This PR replaces the property `embedded` with the property `glass.platform` .
There is only 1 place where the property `embedded` was read, which is in the
PlatformUtil.java.
There are onl
On Wed, 15 Dec 2021 00:25:08 GMT, Kevin Rushforth wrote:
> Build change to strip the non-global symbols from native shared libraries on
> Linux and macOS by running `strip -x`, unless doing a `-PCONF=DebugNative`
> build.
>
> Here is a before / after size comparison. All sizes in KBytes:
>
>
On Mon, 13 Dec 2021 19:46:27 GMT, Martin Fox wrote:
> The algorithm in `KeyCharacterCombination.match` relies on the call
> `Toolkit.getKeyCodeForChar` which is difficult to implement correctly. It
> defies the way most keyboard API’s work and no platform has got it right yet.
> In particular
On Wed, 15 Dec 2021 21:23:23 GMT, Johan Vos wrote:
> The only question I have for now is if it would make sense to have a new
> configuration instead of binding this to DEBUG_NATIVE.
I had initially thought of only stripping the binaries for production builds,
e.g., when `-PCONF=Release` is sp
On Tue, 30 Nov 2021 13:26:30 GMT, Kevin Rushforth wrote:
> This PR deprecates the JavaFX glass GTK 2 library for removal. Since there
> isn't an associated API, the mechanism for doing this is to print a
> "deprecated for removal" warning message when the `glassgtk2` library it is
> loaded. A
> Build change to strip the non-global symbols from native shared libraries on
> Linux and macOS by running `strip -x`, unless doing a `-PCONF=DebugNative`
> build.
>
> Here is a before / after size comparison. All sizes in KBytes:
>
> ### Linux
>
> | Native Library | Current | Stripped |
> |
On Wed, 15 Dec 2021 22:57:26 GMT, Kevin Rushforth wrote:
>> Build change to strip the non-global symbols from native shared libraries on
>> Linux and macOS by running `strip -x`, unless doing a `-PCONF=DebugNative`
>> build.
>>
>> Here is a before / after size comparison. All sizes in KBytes:
On Wed, 15 Dec 2021 20:39:54 GMT, Johan Vos wrote:
> Base decisions in prism for embedded cases on the same glass.platform
> property that is also used in glass.
> This PR replaces the property `embedded` with the property `glass.platform` .
>
> There is only 1 place where the property `embedde
On Wed, 15 Dec 2021 22:57:26 GMT, Kevin Rushforth wrote:
>> Build change to strip the non-global symbols from native shared libraries on
>> Linux and macOS by running `strip -x`, unless doing a `-PCONF=DebugNative`
>> build.
>>
>> Here is a before / after size comparison. All sizes in KBytes:
On Tue, 23 Nov 2021 17:40:29 GMT, Kevin Rushforth wrote:
>> This work improves the performance of `MultipleSelectionModel` over large
>> data sets by caching some values and avoiding unnecessary calls to
>> `SelectedIndicesList#size`. It further improves the performance by reducing
>> the num
On Wed, 15 Dec 2021 22:12:12 GMT, Kevin Rushforth wrote:
> > The only question I have for now is if it would make sense to have a new
> > configuration instead of binding this to DEBUG_NATIVE.
>
> I had initially thought of only stripping the binaries for production builds,
> e.g., when `-PCON
18 matches
Mail list logo