Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v2]

2021-12-15 Thread John Hendrikx
> This is an implementation of the proposal in > https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker > (@nlisker) have been working on. It's a complete implementation including > good test coverage. > > This was based on https://github.com/openjdk/jfx/pull/434 but with a

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v2]

2021-12-15 Thread John Hendrikx
On Wed, 15 Dec 2021 11:36:23 GMT, John Hendrikx wrote: >> This is an implementation of the proposal in >> https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker >> (@nlisker) have been working on. It's a complete implementation including >> good test coverage. >> >> This w

Re: RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v3]

2021-12-15 Thread John Hendrikx
> This is an implementation of the proposal in > https://bugs.openjdk.java.net/browse/JDK-8274771 that me and Nir Lisker > (@nlisker) have been working on. It's a complete implementation including > good test coverage. > > This was based on https://github.com/openjdk/jfx/pull/434 but with a

Monocle properties in glass and prism

2021-12-15 Thread Johan Vos
Hi, The separation between Glass and Prism is slightly broken by Monocle and that restricts the number of possible combinations. I wonder if there are any known cases where the glass platform is set to Monocle, but where prism is expected to use X11? That sounds like a contradiction, as Monocle is

Re: Monocle properties in glass and prism

2021-12-15 Thread Kevin Rushforth
I wonder if there are any known cases where the glass platform is set to Monocle, but where prism is expected to use X11? That sounds like a contradiction Agreed that this seems like a mismatch. I suggest we remove the "embedded" property and the PlatforumUtil.getEmbeddedType() method (note

Re: Monocle properties in glass and prism

2021-12-15 Thread Johan Vos
On Wed, Dec 15, 2021 at 3:53 PM Kevin Rushforth wrote: > > > I wonder if there are any known cases where the glass platform is set to > > Monocle, but where prism is expected to use X11? That sounds like a > > contradiction > > Agreed that this seems like a mismatch. > > > I suggest we remove the

Re: [External] : Re: Monocle properties in glass and prism

2021-12-15 Thread Kevin Rushforth
Sounds good. -- Kevin On 12/15/2021 8:04 AM, Johan Vos wrote: On Wed, Dec 15, 2021 at 3:53 PM Kevin Rushforth wrote: > I wonder if there are any known cases where the glass platform is set to > Monocle, but where prism is expected to use X11? That sounds like a > contrad

RFR: 8278860: Streamline properties for Monocle

2021-12-15 Thread Johan Vos
Base decisions in prism for embedded cases on the same glass.platform property that is also used in glass. This PR replaces the property `embedded` with the property `glass.platform` . There is only 1 place where the property `embedded` was read, which is in the PlatformUtil.java. There are onl

Re: RFR: 8278260: JavaFX shared libraries not stripped on Linux or macOS

2021-12-15 Thread Johan Vos
On Wed, 15 Dec 2021 00:25:08 GMT, Kevin Rushforth wrote: > Build change to strip the non-global symbols from native shared libraries on > Linux and macOS by running `strip -x`, unless doing a `-PCONF=DebugNative` > build. > > Here is a before / after size comparison. All sizes in KBytes: > >

Re: RFR: 8273743: KeyCharacterCombination for "+" does not work on US QWERTY keyboard layout

2021-12-15 Thread Martin Fox
On Mon, 13 Dec 2021 19:46:27 GMT, Martin Fox wrote: > The algorithm in `KeyCharacterCombination.match` relies on the call > `Toolkit.getKeyCodeForChar` which is difficult to implement correctly. It > defies the way most keyboard API’s work and no platform has got it right yet. > In particular

Re: RFR: 8278260: JavaFX shared libraries not stripped on Linux or macOS

2021-12-15 Thread Kevin Rushforth
On Wed, 15 Dec 2021 21:23:23 GMT, Johan Vos wrote: > The only question I have for now is if it would make sense to have a new > configuration instead of binding this to DEBUG_NATIVE. I had initially thought of only stripping the binaries for production builds, e.g., when `-PCONF=Release` is sp

Integrated: 8273089: Deprecate JavaFX GTK 2 library for removal

2021-12-15 Thread Kevin Rushforth
On Tue, 30 Nov 2021 13:26:30 GMT, Kevin Rushforth wrote: > This PR deprecates the JavaFX glass GTK 2 library for removal. Since there > isn't an associated API, the mechanism for doing this is to print a > "deprecated for removal" warning message when the `glassgtk2` library it is > loaded. A

Re: RFR: 8278260: JavaFX shared libraries not stripped on Linux or macOS [v2]

2021-12-15 Thread Kevin Rushforth
> Build change to strip the non-global symbols from native shared libraries on > Linux and macOS by running `strip -x`, unless doing a `-PCONF=DebugNative` > build. > > Here is a before / after size comparison. All sizes in KBytes: > > ### Linux > > | Native Library | Current | Stripped | > |

Re: RFR: 8278260: JavaFX shared libraries not stripped on Linux or macOS [v2]

2021-12-15 Thread Michael Strauß
On Wed, 15 Dec 2021 22:57:26 GMT, Kevin Rushforth wrote: >> Build change to strip the non-global symbols from native shared libraries on >> Linux and macOS by running `strip -x`, unless doing a `-PCONF=DebugNative` >> build. >> >> Here is a before / after size comparison. All sizes in KBytes:

Re: RFR: 8278860: Streamline properties for Monocle

2021-12-15 Thread Michael Strauß
On Wed, 15 Dec 2021 20:39:54 GMT, Johan Vos wrote: > Base decisions in prism for embedded cases on the same glass.platform > property that is also used in glass. > This PR replaces the property `embedded` with the property `glass.platform` . > > There is only 1 place where the property `embedde

Re: RFR: 8278260: JavaFX shared libraries not stripped on Linux or macOS [v2]

2021-12-15 Thread Michael Strauß
On Wed, 15 Dec 2021 22:57:26 GMT, Kevin Rushforth wrote: >> Build change to strip the non-global symbols from native shared libraries on >> Linux and macOS by running `strip -x`, unless doing a `-PCONF=DebugNative` >> build. >> >> Here is a before / after size comparison. All sizes in KBytes:

Re: RFR: 8197991: Selecting many items in a TableView is very slow

2021-12-15 Thread Abhinay Agarwal
On Tue, 23 Nov 2021 17:40:29 GMT, Kevin Rushforth wrote: >> This work improves the performance of `MultipleSelectionModel` over large >> data sets by caching some values and avoiding unnecessary calls to >> `SelectedIndicesList#size`. It further improves the performance by reducing >> the num

Re: RFR: 8278260: JavaFX shared libraries not stripped on Linux or macOS

2021-12-15 Thread Johan Vos
On Wed, 15 Dec 2021 22:12:12 GMT, Kevin Rushforth wrote: > > The only question I have for now is if it would make sense to have a new > > configuration instead of binding this to DEBUG_NATIVE. > > I had initially thought of only stripping the binaries for production builds, > e.g., when `-PCON