Re: RFR: 8279640: ListView with null SelectionModel/FocusModel throws NPE

2022-01-08 Thread John Hendrikx
On Sat, 8 Jan 2022 00:17:36 GMT, Marius Hanl wrote: > This PR fixes a bunch of NPEs when a null `SelectionModel` or `FocusModel` is > set on a `ListView`. > > The following NPEs are fixed (all are also covered by exactly one test case): > NPEs with null selection model: > - Mouse click on a `Li

Integrated: 8279328: CssParser uses default charset instead of UTF-8

2022-01-08 Thread Michael Strauß
On Wed, 29 Dec 2021 15:39:39 GMT, Michael Strauß wrote: > `CssParser.parse(URL)` is specified to assume UTF-8 file encoding, but > (implicitly) uses the default charset to read the file, potentially resulting > in incorrect interpretation of the file content. > > This can be fixed by explicitl

Re: RFR: 8277572: ImageStorage should correctly handle MIME types for images encoded in data URIs [v5]

2022-01-08 Thread Michael Strauß
> `com.sun.javafx.iio.ImageStorage` currently ignores the MIME image subtype > specified for images encoded in data URIs. This should be improved as follows: > > 1. If the specified image subtype is not supported, an exception will be > thrown. > 2. If the specified image subtype is supported, b

Re: RFR: 8277572: ImageStorage should correctly handle MIME types for images encoded in data URIs [v6]

2022-01-08 Thread Michael Strauß
> `com.sun.javafx.iio.ImageStorage` currently ignores the MIME image subtype > specified for images encoded in data URIs. This should be improved as follows: > > 1. If the specified image subtype is not supported, an exception will be > thrown. > 2. If the specified image subtype is supported, b

Re: RFR: 8277572: ImageStorage should correctly handle MIME types for images encoded in data URIs [v4]

2022-01-08 Thread Michael Strauß
On Fri, 7 Jan 2022 00:01:24 GMT, Kevin Rushforth wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added test for image format without signature > > modules/javafx.graphics/src/main/java/com/sun/javafx/iio/ImageSto