Re: RFR: 8244234: MenuButton: NPE on removing from scene with open popup [v2]

On Mon, 17 Jan 2022 15:32:13 GMT, eduardsdv wrote: >> The NPE occurs when the skinnable is removed from the scene while the popup >> is showing. >> The MenuButtonSkinBase, when popup becomes hidden, tries to remove Mnemonics >> from the scene and runs into NPE. >> To avoid NPE a null-check is

Strange test failures: validation of PGGroup children failed

Just stumbled across it while reviewing PR 719 (https://github.com/openjdk/jfx/pull/716) - added the new test method to see it fail (which it does) - run all control tests throws the error below in _unrelated_ tests (the one below is from TableCellTest, that is the same test the new

[jfx17u, jfx11u] RFR: Request to backport January 2022 CPU changes

Hi Johan, I request approval to backport the changes from the just-released January 2022 CPU to jfx17u (for 17.0.2) and to jfx11u (for 11.0.14) . https://github.com/kevinrushforth/jfx17u/compare/b6b7207a19...cpu-2201-sync

[jfx18] RFR: Request to sync January 2022 changes into jfx

Hi Johan, I request approval to sync changes from to the just-released January 2022 CPU release into the 'jfx18' branch of the 'jfx' repo. Here is the aggregate set of changes for the fixes: https://github.com/kevinrushforth/jfx/compare/a2a0acff66...cpu-2201-sync NOTE: Since this is an

Re: [jfx18] RFR: 8205915: [macOS] Accelerator assigned to button in dialog fires menuItem in owning stage [v2]

On Fri, 14 Jan 2022 00:55:00 GMT, Martin Fox wrote: >> When a window is closed while handling performKeyEquivalent the same NSEvent >> might be passed to the new key window causing it to being processed twice. >> Long ago a fix was put in for this case; when the GlassWindow was closed a >>

Re: RFR: 8279640: ListView with null SelectionModel/FocusModel throws NPE

On Tue, 11 Jan 2022 17:21:13 GMT, Michael Strauß wrote: > The question is whether or not `null` should be a valid value for the > `selectionModel` and `focusModel` properties. I think there are good reasons > to think that it shouldn't. The primitive property classes > (`IntegerProperty`,

Re: [jfx18] RFR: 8205915: [macOS] Accelerator assigned to button in dialog fires menuItem in owning stage [v3]

> When a window is closed while handling performKeyEquivalent the same NSEvent > might be passed to the new key window causing it to being processed twice. > Long ago a fix was put in for this case; when the GlassWindow was closed a > flag was set to ensure that we would return YES from

Integrated: 8244234: MenuButton: NPE on removing from scene with open popup

On Tue, 11 Jan 2022 14:42:19 GMT, eduardsdv wrote: > The NPE occurs when the skinnable is removed from the scene while the popup > is showing. > The MenuButtonSkinBase, when popup becomes hidden, tries to remove Mnemonics > from the scene and runs into NPE. > To avoid NPE a null-check is added

Re: [jfx18] RFR: Request to sync January 2022 changes into jfx

Approved. Op di 18 jan. 2022 om 18:25 schreef Kevin Rushforth < kevin.rushfo...@oracle.com>: > Hi Johan, > > I request approval to sync changes from to the just-released January > 2022 CPU release into the 'jfx18' branch of the 'jfx' repo. Here is the > aggregate set of changes for the fixes: >

Aw: Strange test failures: validation of PGGroup children failed

I think I had the same issues some days ago. What helped was to delete all the 'build' or 'target' or 'out' folders - so basically all the folders with the compiled files. Gesendet: Dienstag, 18. Januar 2022 um 15:46 Uhr Von: "Jeanette Winzenburg" An: "openjfx-dev"

[jfx18] Integrated: 8273998: Clarify specification for Window properties controlled by the window manager

On Fri, 7 Jan 2022 18:19:23 GMT, Kevin Rushforth wrote: > Update the API specification for the `Window` and `Stage` classes to clarify > that the values for some properties and methods can be changed or ignored by > the platform. Several of the properties already have a comment to the effect

Re: [jfx17u, jfx11u] RFR: Request to backport January 2022 CPU changes

Approved Op di 18 jan. 2022 om 18:25 schreef Kevin Rushforth < kevin.rushfo...@oracle.com>: > Hi Johan, > > I request approval to backport the changes from the just-released > January 2022 CPU to jfx17u (for 17.0.2) and to jfx11u (for 11.0.14) . > >

Re: [jfx18] RFR: 8205915: [macOS] Accelerator assigned to button in dialog fires menuItem in owning stage [v3]

On Tue, 18 Jan 2022 17:26:15 GMT, Martin Fox wrote: >> When a window is closed while handling performKeyEquivalent the same NSEvent >> might be passed to the new key window causing it to being processed twice. >> Long ago a fix was put in for this case; when the GlassWindow was closed a >>

Integrated: Merge jfx18

Merge ...Merge `jfx18` into `master`. - Commit messages: - Merge jfx18 - 8244234: MenuButton: NPE on removing from scene with open popup - 8279615: Change JavaFX release version to 19 The merge commit only contains trivial merges, so no merge-specific webrevs have been

Integrated: Merge jfx18

On Tue, 18 Jan 2022 20:12:52 GMT, Kevin Rushforth wrote: > Merge ...Merge `jfx18` into `master`. This pull request has now been integrated. Changeset: f01c50d5 Author:Kevin Rushforth URL: https://git.openjdk.java.net/jfx/commit/f01c50d5680ab038fa12774f58b60c33a85156a6 Stats: 88

Re: [jfx18] RFR: 8205915: [macOS] Accelerator assigned to button in dialog fires menuItem in owning stage [v3]

On Tue, 18 Jan 2022 17:26:15 GMT, Martin Fox wrote: >> When a window is closed while handling performKeyEquivalent the same NSEvent >> might be passed to the new key window causing it to being processed twice. >> Long ago a fix was put in for this case; when the GlassWindow was closed a >>