On Fri, 25 Feb 2022 17:54:48 GMT, Hima Bindu Meda wrote:
>> Basically, buttons property is a mask which represents the button/buttons
>> clicked on the mouse.
>> It is observed that event.buttons property is set to 0 when there is
>> mouse press or drag event.This behaviour is observed
Clean backport to `jfx17u`. I tested the backports of
[JDK-8281711](https://bugs.openjdk.java.net/browse/JDK-8281711),
[JDK-8282099](https://bugs.openjdk.java.net/browse/JDK-8282099), and
[JDK-8281089](https://bugs.openjdk.java.net/browse/JDK-8281089) together in the
`test-kcr-17.0.3` branch.
On Mon, 28 Feb 2022 16:14:18 GMT, Kevin Rushforth wrote:
> Clean backport to `jfx17u`. I tested the backports of
> [JDK-8281711](https://bugs.openjdk.java.net/browse/JDK-8281711),
> [JDK-8282099](https://bugs.openjdk.java.net/browse/JDK-8282099), and
>
On Sun, 27 Feb 2022 05:35:23 GMT, Jay Bhaskar wrote:
>> Issue: The current implementation of DOMWindow ::localStorage(..) returns
>> null pointer in case of page is being closed.
>> Fix: It should not return nullptr , as per the [w3c web storage
>>
Update `jfx11u` to the same version of VS2019 (16.9.3) that is used in mainline
jfx. I tested this along with the other VS 2019 and WebKit 613.1 fixes together
in the `test-kcr-11.0.15` branch.
-
Commit messages:
- 8265399: Update to Visual Studio 2019 version 16.9.3
Changes:
Nearly clean backport to `jfx11u` (the only conflict was in the copyright years
in one of the unit tests). I tested this along with the other VS 2019 and
WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch.
-
Commit messages:
- 8278980: Update WebKit to 613.1
Changes:
On Sun, 27 Feb 2022 05:43:27 GMT, Jay Bhaskar wrote:
>> Issue: The current implementation of DOMWindow ::localStorage(..) returns
>> null pointer in case of page is being closed.
>> Fix: It should not return nullptr , as per the [w3c web storage
>>
On Mon, 28 Feb 2022 16:02:42 GMT, Kevin Rushforth wrote:
> Clean backport to `jfx11u`. I tested this along with the other VS 2019 and
> WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch.
This pull request has now been integrated.
Changeset: 2f2a07a9
Author:Kevin Rushforth
URL:
On Wed, 16 Feb 2022 16:46:47 GMT, Kevin Rushforth wrote:
> The `javafx.graphics` module has a number of native libraries, including the
> redistributable Microsoft DLLs on Windows. When running an application using
> the standalone JavaFX SDK, we load all of the needed DLLs from the SDK `bin`
On Mon, 28 Feb 2022 16:46:36 GMT, Kevin Rushforth wrote:
> Nearly clean backport to `jfx11u` (the only conflict was in the copyright
> years in one of the unit tests). I tested this along with the other VS 2019
> and WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch.
@arapte Can
On Sun, 27 Feb 2022 07:10:25 GMT, Jay Bhaskar wrote:
>> Issue: The end point of line in drawLinesForText , add thickness to the
>> endPoint.y(). In this case origin which is start point and the end point
>> would not be same, and line would be drawn not straight.
>> Solution: Do not add
Clean backport to `jfx11u`. I tested this along with the other VS 2019 and
WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch.
-
Commit messages:
- 8281089: JavaFX built with VS2019 and jlinked into JDK 11.x fails to start
Changes:
On Mon, 28 Feb 2022 16:07:10 GMT, Kevin Rushforth wrote:
> Update `jfx11u` to the same version of VS2019 (16.9.3) that is used in
> mainline jfx. I tested this along with the other VS 2019 and WebKit 613.1
> fixes together in the `test-kcr-11.0.15` branch.
This is a prerequisite for the
On Wed, 16 Feb 2022 16:46:47 GMT, Kevin Rushforth wrote:
> The `javafx.graphics` module has a number of native libraries, including the
> redistributable Microsoft DLLs on Windows. When running an application using
> the standalone JavaFX SDK, we load all of the needed DLLs from the SDK `bin`
On Fri, 25 Feb 2022 17:54:48 GMT, Hima Bindu Meda wrote:
>> Basically, buttons property is a mask which represents the button/buttons
>> clicked on the mouse.
>> It is observed that event.buttons property is set to 0 when there is
>> mouse press or drag event.This behaviour is observed
This regression was caused in PR #667 in which I didn't take into account the
lower bounds. I have added more tests and one manual test along with the fix.
The manual test can be used to identify any future issues with paths outside
lower and upper bounds easily.
-
Commit
On Mon, 28 Feb 2022 15:10:27 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> New chnages for line test
>
> tests/system/src/test/java/test/javafx/scene/web/StraightLineTest.java line
> 57:
>
On Mon, 28 Feb 2022 13:58:03 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add Review Changes
>
> modules/javafx.web/src/main/native/Source/WebCore/page/DOMWindow.cpp line 851:
>
>> 849:
>>
On Mon, 28 Feb 2022 14:53:39 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add Review Changes
>
> modules/javafx.web/src/test/java/test/javafx/scene/web/LocalStorageTest.java
> line 55:
>
> Issue: The current implementation of DOMWindow ::localStorage(..) returns
> null pointer in case of page is being closed.
> Fix: It should not return nullptr , as per the [w3c web storage
> spec](https://www.w3.org/TR/2016/REC-webstorage-20160419/)
> "User agents should expire data from the
On Mon, 28 Feb 2022 15:12:37 GMT, Kevin Rushforth wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> New chnages for line test
>
> tests/system/src/test/java/test/javafx/scene/web/StraightLineTest.java line
> 168:
>
> Issue: The end point of line in drawLinesForText , add thickness to the
> endPoint.y(). In this case origin which is start point and the end point
> would not be same, and line would be drawn not straight.
> Solution: Do not add thickness to the y position of end point of line.
> Start
On Mon, 28 Feb 2022 09:06:30 GMT, Ambarish Rapte wrote:
>> Hima Bindu Meda has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use ESC key so that the popup, if any, disappears
>
>
> This regression was caused in PR #667 in which I didn't take into account the
> lower bounds. I have added more tests and one manual test along with the fix.
> The manual test can be used to identify any future issues with paths outside
> lower and upper bounds easily.
Abhinay Agarwal has
> Basically, buttons property is a mask which represents the button/buttons
> clicked on the mouse.
> It is observed that event.buttons property is set to 0 when there is
> mouse press or drag event.This behaviour is observed only with javafx
> webView.Other browsers set the buttons
25 matches
Mail list logo
