Re: [jfx11u] RFR: 8278980: Update WebKit to 613.1

2022-03-01 Thread Ambarish Rapte
On Mon, 28 Feb 2022 16:46:36 GMT, Kevin Rushforth wrote: > Nearly clean backport to `jfx11u` (the only conflict was in the copyright > years in one of the unit tests). I tested this along with the other VS 2019 > and WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch. Verified that t

Re: RFR: 8278759 : PointerEvent: buttons property set to 0 when mouse down [v4]

2022-03-01 Thread Ambarish Rapte
On Tue, 1 Mar 2022 06:19:04 GMT, Hima Bindu Meda wrote: >> Basically, buttons property is a mask which represents the button/buttons >> clicked on the mouse. >> It is observed that event.buttons property is set to 0 when there is >> mouse press or drag event.This behaviour is observed only

Re: [jfx11u] RFR: 8265399: Update to Visual Studio 2019 version 16.9.3

2022-03-01 Thread Ambarish Rapte
On Mon, 28 Feb 2022 16:07:10 GMT, Kevin Rushforth wrote: > Update `jfx11u` to the same version of VS2019 (16.9.3) that is used in > mainline jfx. I tested this along with the other VS 2019 and WebKit 613.1 > fixes together in the `test-kcr-11.0.15` branch. Marked as reviewed by arapte (Reviewe

Re: [jfx11u] RFR: 8278980: Update WebKit to 613.1

2022-03-01 Thread Ambarish Rapte
On Mon, 28 Feb 2022 16:46:36 GMT, Kevin Rushforth wrote: > Nearly clean backport to `jfx11u` (the only conflict was in the copyright > years in one of the unit tests). I tested this along with the other VS 2019 > and WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch. Marked as revie

Re: RFR: 8278759 : PointerEvent: buttons property set to 0 when mouse down [v4]

2022-03-01 Thread Kevin Rushforth
On Tue, 1 Mar 2022 06:19:04 GMT, Hima Bindu Meda wrote: >> Basically, buttons property is a mask which represents the button/buttons >> clicked on the mouse. >> It is observed that event.buttons property is set to 0 when there is >> mouse press or drag event.This behaviour is observed only

Integrated: 8278759 : PointerEvent: buttons property set to 0 when mouse down

2022-03-01 Thread Hima Bindu Meda
On Thu, 24 Feb 2022 18:46:21 GMT, Hima Bindu Meda wrote: > Basically, buttons property is a mask which represents the button/buttons > clicked on the mouse. > It is observed that event.buttons property is set to 0 when there is > mouse press or drag event.This behaviour is observed only wit

Re: RFR: 8255940: localStorage is null after window.close() [v7]

2022-03-01 Thread Ambarish Rapte
On Tue, 1 Mar 2022 02:42:54 GMT, Jay Bhaskar wrote: >> Issue: The current implementation of DOMWindow ::localStorage(..) returns >> null pointer in case of page is being closed. >> Fix: It should not return nullptr , as per the [w3c web storage >> spec](https://www.w3.org/TR/2016/REC-webstorag