On Mon, 28 Feb 2022 16:07:10 GMT, Kevin Rushforth wrote:
> Update `jfx11u` to the same version of VS2019 (16.9.3) that is used in
> mainline jfx. I tested this along with the other VS 2019 and WebKit 613.1
> fixes together in the `test-kcr-11.0.15` branch.
Pending a second reviewer.
@tiainen
> Issue: The current implementation of DOMWindow ::localStorage(..) returns
> null pointer in case of page is being closed.
> Fix: It should not return nullptr , as per the [w3c web storage
> spec](https://www.w3.org/TR/2016/REC-webstorage-20160419/)
> "User agents should expire data from the l
On Tue, 1 Mar 2022 10:00:58 GMT, Ambarish Rapte wrote:
>> Jay Bhaskar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Clean up test and fix
>
> modules/javafx.web/src/main/native/Source/WebCore/page/DOMWindow.cpp line 850:
>
>> 848:
> Issue: The DataObject uses m_availMimeTypes as Vector of strings, and
> appending mime types in pasteboard operation like setPlainText, Hence it will
> append duplicate mime types in m_availMimeTypes , in this case the length
> clipboardData.types would be wrong, and duplicates data would be c
> Issue: The DataObject uses m_availMimeTypes as Vector of strings, and
> appending mime types in pasteboard operation like setPlainText, Hence it will
> append duplicate mime types in m_availMimeTypes , in this case the length
> clipboardData.types would be wrong, and duplicates data would be c
> Issue: The end point of line in drawLinesForText , add thickness to the
> endPoint.y(). In this case origin which is start point and the end point
> would not be same, and line would be drawn not straight.
> Solution: Do not add thickness to the y position of end point of line.
> Start Point(x
