Re: [jfx11u] RFR: 8265399: Update to Visual Studio 2019 version 16.9.3

2022-03-04 Thread Joeri Sykora
On Mon, 28 Feb 2022 16:07:10 GMT, Kevin Rushforth wrote: > Update `jfx11u` to the same version of VS2019 (16.9.3) that is used in > mainline jfx. I tested this along with the other VS 2019 and WebKit 613.1 > fixes together in the `test-kcr-11.0.15` branch. Build and tests ran successfully. --

Re: RFR: 8280020: Underline and line-through not straight in WebView [v7]

2022-03-04 Thread Kevin Rushforth
On Fri, 4 Mar 2022 03:29:33 GMT, Jay Bhaskar wrote: >> Issue: The end point of line in drawLinesForText , add thickness to the >> endPoint.y(). In this case origin which is start point and the end point >> would not be same, and line would be drawn not straight. >> Solution: Do not add thickne

[jfx11u] Integrated: 8265399: Update to Visual Studio 2019 version 16.9.3

2022-03-04 Thread Kevin Rushforth
On Mon, 28 Feb 2022 16:07:10 GMT, Kevin Rushforth wrote: > Update `jfx11u` to the same version of VS2019 (16.9.3) that is used in > mainline jfx. I tested this along with the other VS 2019 and WebKit 613.1 > fixes together in the `test-kcr-11.0.15` branch. This pull request has now been integr

[jfx11u] Integrated: 8278980: Update WebKit to 613.1

2022-03-04 Thread Kevin Rushforth
On Mon, 28 Feb 2022 16:46:36 GMT, Kevin Rushforth wrote: > Nearly clean backport to `jfx11u` (the only conflict was in the copyright > years in one of the unit tests). I tested this along with the other VS 2019 > and WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch. This pull reque

[jfx11u] Integrated: 8281459: WebKit 613.1 build broken on M1

2022-03-04 Thread Kevin Rushforth
Clean backport to `jfx11u`. I tested this along with the other VS 2019 and WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch. - Commit messages: - 8281459: WebKit 613.1 build broken on M1 Changes: https://git.openjdk.java.net/jfx11u/pull/78/files Webrev: https://webrevs

[jfx11u] Integrated: 8281459: WebKit 613.1 build broken on M1

2022-03-04 Thread Kevin Rushforth
On Fri, 4 Mar 2022 14:16:14 GMT, Kevin Rushforth wrote: > Clean backport to `jfx11u`. I tested this along with the other VS 2019 and > WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch. This pull request has now been integrated. Changeset: 429f4181 Author:Kevin Rushforth URL:

[jfx11u] Integrated: 8281711: Cherry-pick WebKit 613.1 stabilization fixes

2022-03-04 Thread Kevin Rushforth
Clean backport to `jfx11u`. I tested this along with the other VS 2019 and WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch. - Commit messages: - 8281711: Cherry-pick WebKit 613.1 stabilization fixes Changes: https://git.openjdk.java.net/jfx11u/pull/79/files Webrev: ht

[jfx11u] Integrated: 8281711: Cherry-pick WebKit 613.1 stabilization fixes

2022-03-04 Thread Kevin Rushforth
On Fri, 4 Mar 2022 14:27:25 GMT, Kevin Rushforth wrote: > Clean backport to `jfx11u`. I tested this along with the other VS 2019 and > WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch. This pull request has now been integrated. Changeset: eda64804 Author:Kevin Rushforth URL:

[jfx11u] Integrated: 8282099: Cherry-pick WebKit 613.1 stabilization fixes (2)

2022-03-04 Thread Kevin Rushforth
On Fri, 4 Mar 2022 14:40:49 GMT, Kevin Rushforth wrote: > Clean backport to `jfx11u`. I tested this along with the other VS 2019 and > WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch. This pull request has now been integrated. Changeset: 90a0ae22 Author:Kevin Rushforth URL:

[jfx11u] Integrated: 8282099: Cherry-pick WebKit 613.1 stabilization fixes (2)

2022-03-04 Thread Kevin Rushforth
Clean backport to `jfx11u`. I tested this along with the other VS 2019 and WebKit 613.1 fixes together in the `test-kcr-11.0.15` branch. - Commit messages: - 8282099: Cherry-pick WebKit 613.1 stabilization fixes (2) Changes: https://git.openjdk.java.net/jfx11u/pull/80/files Webrev

Re: RFR: 8269115: WebView paste event contains old data [v7]

2022-03-04 Thread Kevin Rushforth
On Fri, 4 Mar 2022 02:50:24 GMT, Jay Bhaskar wrote: >> Issue: The DataObject uses m_availMimeTypes as Vector of strings, and >> appending mime types in pasteboard operation like setPlainText, Hence it >> will append duplicate mime types in m_availMimeTypes , in this case the >> length clipboar

Re: RFR: 8255940: localStorage is null after window.close() [v8]

2022-03-04 Thread Kevin Rushforth
On Thu, 3 Mar 2022 17:08:49 GMT, Jay Bhaskar wrote: >> Issue: The current implementation of DOMWindow ::localStorage(..) returns >> null pointer in case of page is being closed. >> Fix: It should not return nullptr , as per the [w3c web storage >> spec](https://www.w3.org/TR/2016/REC-webstorag

Re: RFR: 8255940: localStorage is null after window.close() [v8]

2022-03-04 Thread Jay Bhaskar
On Thu, 3 Mar 2022 17:08:49 GMT, Jay Bhaskar wrote: >> Issue: The current implementation of DOMWindow ::localStorage(..) returns >> null pointer in case of page is being closed. >> Fix: It should not return nullptr , as per the [w3c web storage >> spec](https://www.w3.org/TR/2016/REC-webstorag

Re: RFR: 8255940: localStorage is null after window.close() [v9]

2022-03-04 Thread Jay Bhaskar
> Issue: The current implementation of DOMWindow ::localStorage(..) returns > null pointer in case of page is being closed. > Fix: It should not return nullptr , as per the [w3c web storage > spec](https://www.w3.org/TR/2016/REC-webstorage-20160419/) > "User agents should expire data from the l

Re: RFR: 8255940: localStorage is null after window.close() [v9]

2022-03-04 Thread Kevin Rushforth
On Fri, 4 Mar 2022 16:55:48 GMT, Jay Bhaskar wrote: >> Issue: The current implementation of DOMWindow ::localStorage(..) returns >> null pointer in case of page is being closed. >> Fix: It should not return nullptr , as per the [w3c web storage >> spec](https://www.w3.org/TR/2016/REC-webstorag

Re: RFR: 8255940: localStorage is null after window.close() [v9]

2022-03-04 Thread Ambarish Rapte
On Fri, 4 Mar 2022 16:55:48 GMT, Jay Bhaskar wrote: >> Issue: The current implementation of DOMWindow ::localStorage(..) returns >> null pointer in case of page is being closed. >> Fix: It should not return nullptr , as per the [w3c web storage >> spec](https://www.w3.org/TR/2016/REC-webstorag