RFR: 8283318: Videos with unusual sizes cannot be played on windows
Fixed by removing check which enables dynamic format change, since it requires for portrait videos, not standard resolutions and anything that has width > 1920 or/and height > 1080. - Commit messages: - 8283318: Videos with unusual sizes cannot be played on windows Changes: https://git.openjdk.java.net/jfx/pull/775/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx=775=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8283318 Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/jfx/pull/775.diff Fetch: git fetch https://git.openjdk.java.net/jfx pull/775/head:pull/775 PR: https://git.openjdk.java.net/jfx/pull/775
Re: [jfx18, jfx17u, jfx11u] RFR: Request to backport April 2022 CPU changes
Approved. On Tue, Apr 19, 2022 at 6:03 PM Kevin Rushforth wrote: > Hi Johan, > > I request approval to backport the changes from the just-released April > 2022 CPU to jfx:jfx18 (for 18.0.1), jfx17u (for 17.0.3) and to jfx11u > (for 11.0.15) . > > https://github.com/kevinrushforth/jfx17u/compare/4af7ee97f3...cpu-2204-sync > https://github.com/kevinrushforth/jfx11u/compare/1c3d966688...cpu-2204-sync > https://github.com/kevinrushforth/jfx/compare/7e2cefba7f...18-cpu-2204-sync > > For each repo, this is a straight backport (patches initially applied > cleanly, but then the same merge conflict had to be resolved in each > code line as was done in the mainline) of the two FX fix that went into > the April CPU. > > NOTE: Since this is an integration of already-reviewed fixes, I will > push it directly to the jfx18 branch of the jfx repo, and to the master > branch of the jfx17u and jfx11u repos rather than via a pull request. > > Thanks. > > -- Kevin > >
Re: RFR: Request to sync April 2022 changes into jfx master
Approved. On Tue, Apr 19, 2022 at 6:03 PM Kevin Rushforth wrote: > Hi Johan, > > I request approval to sync changes from to the just-released April 2022 > CPU release into the 'master' branch of the 'jfx' repo. Here is the > aggregate set of changes for the fixes: > > https://github.com/kevinrushforth/jfx/compare/d1110f4795...cpu-2204-sync > > As a note, the patches initially applied cleanly, but there was a > subsequent merge conflict with the WebKit 613.1 update that had to be > resolved. > > NOTE: Since this is an integration of already-reviewed fixes, I will > push it directly to the master branch of the jfx repo rather than via a > pull request. > > -- Kevin > >
[jfx18, jfx17u, jfx11u] RFR: Request to backport April 2022 CPU changes
Hi Johan, I request approval to backport the changes from the just-released April 2022 CPU to jfx:jfx18 (for 18.0.1), jfx17u (for 17.0.3) and to jfx11u (for 11.0.15) . https://github.com/kevinrushforth/jfx17u/compare/4af7ee97f3...cpu-2204-sync https://github.com/kevinrushforth/jfx11u/compare/1c3d966688...cpu-2204-sync https://github.com/kevinrushforth/jfx/compare/7e2cefba7f...18-cpu-2204-sync For each repo, this is a straight backport (patches initially applied cleanly, but then the same merge conflict had to be resolved in each code line as was done in the mainline) of the two FX fix that went into the April CPU. NOTE: Since this is an integration of already-reviewed fixes, I will push it directly to the jfx18 branch of the jfx repo, and to the master branch of the jfx17u and jfx11u repos rather than via a pull request. Thanks. -- Kevin
RFR: Request to sync April 2022 changes into jfx master
Hi Johan, I request approval to sync changes from to the just-released April 2022 CPU release into the 'master' branch of the 'jfx' repo. Here is the aggregate set of changes for the fixes: https://github.com/kevinrushforth/jfx/compare/d1110f4795...cpu-2204-sync As a note, the patches initially applied cleanly, but there was a subsequent merge conflict with the WebKit 613.1 update that had to be resolved. NOTE: Since this is an integration of already-reviewed fixes, I will push it directly to the master branch of the jfx repo rather than via a pull request. -- Kevin
Re: RFR: 8251480: TableColumnHeader: calc of cell width must respect row styling
On Tue, 19 Apr 2022 06:06:25 GMT, Robert Lichtenberger wrote: > Is there a pre-existing issue for this? Otherwise I'll try and come up with > an example and create a new issue... I don't think so, you may need to create a new issue. I think it's pretty much the same problem and solution as this ticket was, so you can probably copy some information. - PR: https://git.openjdk.java.net/jfx/pull/757
Re: RFR: 8251480: TableColumnHeader: calc of cell width must respect row styling
On Wed, 16 Mar 2022 13:01:45 GMT, Robert Lichtenberger wrote: >> Might make sense to also adjust the TreeTableView sizing implementation? > >> Might make sense to also adjust the TreeTableView sizing implementation? > > Yes I think that may be a good idea. True to the idea of specific, narrow > commits I've not integrated this into this PR but would be willing to open a > new issue / produce a separate PR for TreeTableView. > @effad Do you have time and interest to take a look at this for the > `TreeTableView` as well? Just asking as otherwise I will have a look :) Sorry for late response (extended easter holidays ...). Yes I could also take a look at this for TreeTableView. Is there a pre-existing issue for this? Otherwise I'll try and come up with an example and create a new issue... - PR: https://git.openjdk.java.net/jfx/pull/757
