Re: Use ScenePulseListener to avoid expensive recalculations?

2013-11-07 Thread Martin Sladecek
It depends on what you need to recompute. If you invalidate some properties and the internal layout depends on these properties, then also your pref/min size depends on these properties. The layout (simplified) usually works in 3 steps: 1)compute the layout using min/pref/max size of children

Re: Use ScenePulseListener to avoid expensive recalculations?

2013-11-07 Thread Martin Sladecek
On 11/06/2013 07:31 PM, John Hendrikx wrote: On 5/11/2013 20:10, Jonathan Giles wrote: You're right in that controls don't tend to use ScenePulseListener. This may be due to an oversight on our part, or just that our requirements differ (I don't honestly know). You're also right that it is

Re: Scene Builder performance regression between 1.1 and 2.0

2013-11-07 Thread Yves JOAN
Hi Felix, I didn't notice such an issue. Can you please log a JIRA https://javafx-jira.kenai.com/browse/DTL so that we can track the details ? By the way what reads Help About Scene Builder window, especially for JavaFX section, in the two cases (Toolkit, Pipeline, Hardware acceleration) ?

hg: openjfx/8/graphics/rt: iOS build system: updated iOS version to 7.0, fixed media package for javah. Reviewed by omaticka

2013-11-07 Thread hang . vo
Changeset: 92583d8664ef Author:dpulkrab Date: 2013-11-07 10:14 +0100 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/92583d8664ef iOS build system: updated iOS version to 7.0, fixed media package for javah. Reviewed by omaticka ! buildSrc/ios.gradle

Re: Use ScenePulseListener to avoid expensive recalculations?

2013-11-07 Thread John Hendrikx
On 7/11/2013 09:20, Martin Sladecek wrote: On 11/06/2013 07:31 PM, John Hendrikx wrote: On 5/11/2013 20:10, Jonathan Giles wrote: You're right in that controls don't tend to use ScenePulseListener. This may be due to an oversight on our part, or just that our requirements differ (I don't

Minor issue with ColorPicker

2013-11-07 Thread Felix Bembrick
Why does the text Custom Color.. that appears when the colour selections appear in the drop-down section of ColorPicker use two dots (i.e. ..) instead of an ellipsis or three dots (i.e. ...) at the end of the text? The ellipsis is a standard scientific and mathematical symbol and is of course

Re: Scene Builder performance regression between 1.1 and 2.0

2013-11-07 Thread Artem Ananiev
On 11/7/2013 10:11 AM, Felix Bembrick wrote: Scene Builder 2.0 has very serious performance issues (on my machines at least). When running 1.1 2.0 side-by-side, 1.1 is very responsive and behaves very well. On the contrary, 2.0 is extremely sluggish with a few seconds between clicking on a

Re: GridPane prevents layouting

2013-11-07 Thread Martin Sladecek
Hi Mario, this is definitely a bug. Can you file this to JIRA, preferably with some test case that fails for you? Thanks, -Martin On 11/07/2013 11:48 AM, Mario Ivankovits wrote: Hi JavaFX-Devs! I do have a situation where the GridPane prevents the refreshing of parts of a scene. Unhappily

Review Request: RT-34077 [Graphics, Swing] JFXPanel with WebView in JDK

2013-11-07 Thread Petr Pchelko
Hello, OpenJFX community. Please review the fix for the issue: https://javafx-jira.kenai.com/browse/RT-34077 The webrev is available at: http://cr.openjdk.java.net/~pchelko/fx/34077/webrev/ Thank you. With best regards. Petr.

Re: Use ScenePulseListener to avoid expensive recalculations?

2013-11-07 Thread Martin Sladecek
This is something different. When properties depends on each other (using bindings), the binding computation is deferred to the first query (get() call) of the dependant. That means, if q depends on p, you can call p.set() as many times you want, but the recomputation will be triggered just

Re: Use ScenePulseListener to avoid expensive recalculations?

2013-11-07 Thread Tomas Mikula
Hi Martin, On Thu, Nov 7, 2013 at 2:32 PM, Martin Sladecek martin.slade...@oracle.com wrote: This is something different. When properties depends on each other (using bindings), the binding computation is deferred to the first query (get() call) of the dependant. That means, if q depends on

Re: Use ScenePulseListener to avoid expensive recalculations?

2013-11-07 Thread Martin Sladecek
On 11/07/2013 03:18 PM, Tomas Mikula wrote: Hi Martin, On Thu, Nov 7, 2013 at 2:32 PM, Martin Sladecek martin.slade...@oracle.com wrote: This is something different. When properties depends on each other (using bindings), the binding computation is deferred to the first query (get() call) of

Code Review Policies

2013-11-07 Thread Stephen F Northover
Hello Committers, Let me summarize how to initiate a code review, since this changed recently. All information about how a bug was fixed needs to be in the JIRA. This means that all patches, webrevs, discussions and who is doing the review needs to be captured there. The email to openjfx-dev

Re: Use ScenePulseListener to avoid expensive recalculations?

2013-11-07 Thread Tomas Mikula
On Thu, Nov 7, 2013 at 3:34 PM, Martin Sladecek martin.slade...@oracle.com wrote: On 11/07/2013 03:18 PM, Tomas Mikula wrote: Hi Martin, On Thu, Nov 7, 2013 at 2:32 PM, Martin Sladecek martin.slade...@oracle.com wrote: This is something different. When properties depends on each other

Re: Review Request: RT-34077 [Graphics, Swing] JFXPanel with WebView in JDK

2013-11-07 Thread Artem Ananiev
Hi, Petr, since the return value now depends on presence/absence of FX scene embedded into JFXPanel, shouldn't we also change setEmbeddedScene() in JFXPanel.HostContainer? Thanks, Artem On 11/7/2013 4:48 PM, Petr Pchelko wrote: Hello, OpenJFX community. Please review the fix for the

Re: Minor issue with ColorPicker

2013-11-07 Thread Leif Samuelsson
Good point (no pun intended). I'll address this when I move the string to the resource file for https://javafx-jira.kenai.com/browse/RT-34099. Leif On 2013-11-07 03:17, Felix Bembrick wrote: Why does the text Custom Color.. that appears when the colour selections appear in the drop-down

Re: Review Request: RT-34077 [Graphics, Swing] JFXPanel with WebView in JDK

2013-11-07 Thread Artem Ananiev
On 11/7/2013 7:38 PM, Stephen F Northover wrote: Artem old friend!! We are moving all sorts of comments like this over to the JIRA rather than sending them to the list. My bad. I've duplicated this question in RT-34077 comments. Thanks, Artem Steve On 2013-11-07 10:24 AM, Artem Ananiev

Re: Use ScenePulseListener to avoid expensive recalculations?

2013-11-07 Thread John Hendrikx
On 7/11/2013 14:08, Tomas Mikula wrote: On Thu, Nov 7, 2013 at 11:58 AM, John Hendrikxhj...@xs4all.nl wrote: Hm, I found it googling, and since it showed up here: http://docs.oracle.com/javafx/2/api/javafx/scene/Scene.ScenePulseListener.html I figured it was public, but I just noticed the

hg: openjfx/8/graphics/rt: 2 new changesets

2013-11-07 Thread hang . vo
Changeset: 10131ecdf85a Author:Felipe Heidrich felipe.heidr...@oracle.com Date: 2013-11-07 08:51 -0800 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/10131ecdf85a RT-34093: complext text are garbled when using some fonts to render the text. !

Re: Scene Builder performance regression between 1.1 and 2.0

2013-11-07 Thread Philipp Dörfler
I also noticed a performance regression (Linux x64). SceneBuilder 1.1 was already kind of slow, but 2.0 feels even less snappy. The menus feel particularly sluggish and I can even see parts of the GPU's memory content right before the menu items are being drawn over it. Am 07.11.2013 12:49 schrieb

[Fwd: Review request for RT-34111: Scaling problem when printing using Canon Inkjet iP100]

2013-11-07 Thread Kevin Rushforth
---BeginMessage--- Hi Phil, Kevin, Please review RT-34111. Bug Description and Webrev : https://javafx-jira.kenai.com/browse/RT-34111 Bug summary: Printout shows a scaled down version of the screen output. Thank you. Jennifer ---End Message---

Review request: RT-34115: DatePicker: space is inserted into the textfield when pressing space to close the popup.

2013-11-07 Thread Leif Samuelsson
Hi Jonathan, A fix description and patch are in JIRA. https://javafx-jira.kenai.com/browse/RT-34115 Thanks, Leif

hg: openjfx/8/graphics: RT-32156: Cleanup top-level openjfx repo for FX 8

2013-11-07 Thread kevin . rushforth
Changeset: b80799b32c69 Author:kcr Date: 2013-11-06 16:41 -0800 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rev/b80799b32c69 RT-32156: Cleanup top-level openjfx repo for FX 8 - .hgignore ! README - build-defs.xml - build-src/build-cache.xml -

Android replaces Dalvik with ART

2013-11-07 Thread Tobias Bley
Hi, after we reached the goal to use JavaFX on Android via Dalvik, Google announces the successor of Dalvik, called ART (Android Runtime). The start to move because of the legal issues with Java and Oracle…. http://source.android.com/devices/tech/dalvik/art.html The question is now: How to

hg: openjfx/8/graphics/rt: RT-33590 Ensemble8: remove playground and docs links/docs search references on embedded

2013-11-07 Thread hang . vo
Changeset: 5560bff5eea1 Author:dmasada Date: 2013-11-07 11:29 -0800 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/5560bff5eea1 RT-33590 Ensemble8: remove playground and docs links/docs search references on embedded !

Review Request: RT-26277 [API, Layout] Percentage doesn't work in CSS Insets anymore

2013-11-07 Thread David Grieve
Dear OpenJFX Community, Please review the fix for the issue: https://javafx-jira.kenai.com/browse/RT-26277 The webrev is available at: http://cr.openjdk.java.net/~kcr/RT-26277/webrev/ The JIRA issue contains detailed information. Thanks, David

Re: Android replaces Dalvik with ART

2013-11-07 Thread Stefan Fuchs
Hi, well if I understand it correctly, ART is just an Ahead of Time compiler like robovm. Therefore we can only hope, that they open-source it, so that we can use it on iOS :). See the German article on heise:

Re: Use ScenePulseListener to avoid expensive recalculations?

2013-11-07 Thread Martin Sladecek
On 11/07/2013 04:03 PM, Tomas Mikula wrote: On Thu, Nov 7, 2013 at 3:34 PM, Martin Sladecek martin.slade...@oracle.com wrote: On 11/07/2013 03:18 PM, Tomas Mikula wrote: Hi Martin, On Thu, Nov 7, 2013 at 2:32 PM, Martin Sladecek martin.slade...@oracle.com wrote: This is something different.

Review request for RT-34111: Scaling problem when printing using Canon Inkjet iP100

2013-11-07 Thread Jennifer Godinez
Hi Phil, Kevin, Please review RT-34111. Bug Description and Webrev : https://javafx-jira.kenai.com/browse/RT-34111 Bug summary: Printout shows a scaled down version of the screen output. Thank you. Jennifer

Re: Android replaces Dalvik with ART

2013-11-07 Thread Stephen F Northover
This is what .NET does. There was never an interpreter for any managed code. Steve On 2013-11-07 2:54 PM, Stefan Fuchs wrote: Hi, well if I understand it correctly, ART is just an Ahead of Time compiler like robovm. Therefore we can only hope, that they open-source it, so that we can use

Re: Scene Builder performance regression between 1.1 and 2.0

2013-11-07 Thread Darryl R
It seems ok for me so far on windows. Here is what I see in the about dialog: Product Version JavaFX Scene Builder 2.0 (Developer Preview) Build Information Version: 2.0-b05, Changeset: ae16937fb015 Date: 2013-10-24 10:43 JavaFX Toolkit = QuantumToolkit Pipeline = D3DPipeline Hardware

hg: openjfx/8/graphics/rt: RT_31134 MouseExited events can be correctly generated without mouse move.

2013-11-07 Thread hang . vo
Changeset: bb0048cd03c6 Author:psomashe Date: 2013-11-07 13:06 -0800 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/bb0048cd03c6 RT_31134 MouseExited events can be correctly generated without mouse move. ! modules/controls/src/main/java/javafx/scene/control/Tooltip.java

Re: Android replaces Dalvik with ART

2013-11-07 Thread Richard Bair
I *really* doubt this has anything to do with the legal battle, it is much more likely to be the fact that Dalvik is painfully slow. Using an AOT compiler is not actually changing anything with regards to the fact that their development language is Java with a non-TCK compliant set of class

Re: Code Review Policies

2013-11-07 Thread Richard Bair
Awesome! Thanks guys. I hope everybody else sees what I see here -- a constant continually effort to improve OpenJFX and make it a real Open Source project in every sense of the word. Major thanks to Steve for pushing on this so hard. Richard On Nov 7, 2013, at 6:36 AM, Stephen F Northover

Re: Code Review Policies

2013-11-07 Thread Mark Fortner
Did you guys ever take a look at Crucible (part of the Atlassian suite)? It makes diff's easier to read, and lets you provide feedback in the context of the code. Cheers, Mark On Thu, Nov 7, 2013 at 3:21 PM, Richard Bair richard.b...@oracle.comwrote: Awesome! Thanks guys. I hope everybody

Re: Code Review Policies

2013-11-07 Thread Kevin Rushforth
Yes, several of us have kicked the tires of Crucible for internal reviews. Many of us, including me, like it quite a bit. I am hopeful that OpenJDK will move to a modern tool than webrev + JIRA comments, and Crucible seems a good choice given that we already use JIRA. -- Kevin Richard Bair

Re: Use ScenePulseListener to avoid expensive recalculations?

2013-11-07 Thread Tomas Mikula
Sorry, you are right, I realized that on my way out. So a ChangeListener is necessary for my example to be right. Anyway, the problem of multiple invalidations exists and I hope I managed to demonstrate that the solution with ScenePulseListener doesn't scale. Regards, Tomas On Thu, Nov 7, 2013

Re: Code Review Policies

2013-11-07 Thread Richard Bair
Believe me, nothing is that easy when it comes to infrastructure in Oracle (or at Sun either, for that matter). Richard On Nov 7, 2013, at 4:08 PM, Mark Fortner phidia...@gmail.com wrote: Sorry, I didn't understand the connection between code review and external hosting. You currently use

hg: openjfx/8/graphics/rt: RT-33998 Ensemble8: port gauge sample to Ensemble8

2013-11-07 Thread hang . vo
Changeset: c1e5063a41c1 Author:dmasada Date: 2013-11-07 17:21 -0800 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/c1e5063a41c1 RT-33998 Ensemble8: port gauge sample to Ensemble8 ! apps/samples/Ensemble8/src/generated/java/ensemble/generated/Samples.java +

hg: openjfx/8/graphics/rt: 2 new changesets

2013-11-07 Thread hang . vo
Changeset: b47c5819f27b Author:mfang Date: 2013-11-06 23:38 -0800 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/b47c5819f27b RT-34117: NLS: javafx8 message drop 20 integration !