Review request RT-34557: JavaFX does not paint correctly when a window opens while the screen is locked
Hi Vadim, Kevin, Could you review the fix for https://javafx-jira.kenai.com/browse/RT-34557 Please find all details in the JIRA record. Thank you in advance, Dmitry
[8] Review request for RT-34196 [Controls, Menus] Gtk: JAVAFX default menu items are difficult to click
Hello Anthony, Martin, Please review fix for https://javafx-jira.kenai.com/browse/RT-34196 -- Thanks, Alexander.
[8] Review request for RT-33881: Mac: System menu bar doesn't work at all with MacOS 10.9
Petr, Steve, Please review a fix: https://javafx-jira.kenai.com/browse/RT-33881 -- best regards, Anthony
hg: openjfx/8/graphics/rt: RT-33792: Implement specular lighting as specified for the PhongMaterial
Changeset: f2b2903b65fa Author:vadim Date: 2013-11-28 14:47 +0400 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/f2b2903b65fa RT-33792: Implement specular lighting as specified for the PhongMaterial Reviewed-by: ckyang, kcr + apps/toys/FX8-3DFeatures/src/fx83dfeatures/Camera3D.java + apps/toys/FX8-3DFeatures/src/fx83dfeatures/CameraController.java ! apps/toys/FX8-3DFeatures/src/fx83dfeatures/SpecularColorTestApp.java + apps/toys/FX8-3DFeatures/src/resources/spec.png + apps/toys/FX8-3DFeatures/src/resources/spec_color.png ! build.gradle ! modules/graphics/src/main/java/com/sun/javafx/sg/prism/NGPhongMaterial.java ! modules/graphics/src/main/java/com/sun/prism/PhongMaterial.java ! modules/graphics/src/main/java/com/sun/prism/d3d/D3DContext.java ! modules/graphics/src/main/java/com/sun/prism/d3d/D3DPhongMaterial.java ! modules/graphics/src/main/java/com/sun/prism/es2/ES2Context.java ! modules/graphics/src/main/java/com/sun/prism/es2/ES2PhongMaterial.java ! modules/graphics/src/main/java/com/sun/prism/es2/ES2PhongShader.java ! modules/graphics/src/main/java/com/sun/prism/es2/GLContext.java ! modules/graphics/src/main/java/javafx/scene/paint/PhongMaterial.java ! modules/graphics/src/main/native-prism-d3d/D3DContext.cc ! modules/graphics/src/main/native-prism-d3d/D3DMeshView.cc ! modules/graphics/src/main/native-prism-d3d/D3DPhongMaterial.cc ! modules/graphics/src/main/native-prism-d3d/D3DPhongMaterial.h ! modules/graphics/src/main/native-prism-d3d/D3DPhongShader.cc ! modules/graphics/src/main/native-prism-d3d/D3DPhongShader.h ! modules/graphics/src/main/native-prism-d3d/D3DPhongShaderGen.cc ! modules/graphics/src/main/native-prism-d3d/hlsl/Mtl1PS.hlsl ! modules/graphics/src/main/native-prism-d3d/hlsl/psConstants.h ! modules/graphics/src/main/native-prism-d3d/hlsl/psMath.h ! modules/graphics/src/main/native-prism-es2/GLContext.c ! modules/graphics/src/main/native-prism-es2/PrismES2Defs.h ! modules/graphics/src/main/resources/com/sun/prism/es2/glsl/main1Light.frag ! modules/graphics/src/main/resources/com/sun/prism/es2/glsl/main2Lights.frag ! modules/graphics/src/main/resources/com/sun/prism/es2/glsl/main3Lights.frag ! modules/graphics/src/main/resources/com/sun/prism/es2/glsl/specular_color.frag + modules/graphics/src/main/resources/com/sun/prism/es2/glsl/specular_mix.frag ! modules/graphics/src/main/resources/com/sun/prism/es2/glsl/specular_texture.frag
hg: openjfx/8/graphics/rt: 2 new changesets
Changeset: ee94f7e65ab3 Author:Daniel Blaukopf daniel.blauk...@oracle.com Date: 2013-11-28 12:52 +0200 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/ee94f7e65ab3 RT-33388 Not processing events from Touchscreen eGalax RT-34338 Lens: Chalkboard Electronics touch screen declared as ID_INPUT_TABLET is not recognised Reviewed-by: ddhill ! modules/graphics/src/main/java/com/sun/glass/ui/lens/LensTouchInputSupport.java ! modules/graphics/src/main/native-glass/lens/input/udev/udevInput.c Changeset: 22039a8a6341 Author:Daniel Blaukopf daniel.blauk...@oracle.com Date: 2013-11-28 13:08 +0200 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/22039a8a6341 RT-33706 DFB: clear screen when application exits Reviewed-by: ddhill Contributed-by: kselle ! modules/graphics/src/main/java/com/sun/glass/ui/lens/LensApplication.java ! modules/graphics/src/main/native-glass/lens/wm/screen/fbdevScreen.c
hg: openjfx/8/graphics/rt: RT-34196 [Controls, Menus] Gtk: JAVAFX default menu items are difficult to click
Changeset: 8fd1e1131277 Author:azvegint alexander.zvegint...@oracle.com Date: 2013-11-28 16:18 +0400 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/8fd1e1131277 RT-34196 [Controls, Menus] Gtk: JAVAFX default menu items are difficult to click Reviewed-by: anthony, msladecek ! modules/graphics/src/main/native-glass/gtk/glass_window.cpp ! modules/graphics/src/main/native-glass/gtk/glass_window.h
Review request: RT-34513 : Regression: Popup in a popup behaves unexpectedly
Hi Jonathan, please review the following: JIRA: https://javafx-jira.kenai.com/browse/RT-34513 webrev: http://cr.openjdk.java.net/~msladecek/rt-34513/webrev.00/ http://cr.openjdk.java.net/%7Emsladecek/rt-34513/webrev.00/ Thanks, -Martin
hg: openjfx/8/graphics/rt: ECLIPSE ONLY: fix .classpath
Changeset: 4455a18dd959 Author:snorthov Date: 2013-11-28 10:41 -0500 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/4455a18dd959 ECLIPSE ONLY: fix .classpath ! apps/experiments/3DViewer/.classpath
hg: openjfx/8/graphics/rt: RT-34519 Rendering errors in NGRegion on SW pipeline after fix for RT-34055
Changeset: b6fb603c0399 Author:Daniel Blaukopf daniel.blauk...@oracle.com Date: 2013-11-28 18:17 +0200 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/b6fb603c0399 RT-34519 Rendering errors in NGRegion on SW pipeline after fix for RT-34055 Summary: Revert the fix to RT-34055 Reviewed-by: snorthov ! modules/graphics/src/main/java/com/sun/javafx/sg/prism/NGRegion.java
hg: openjfx/8/master/rt: 65 new changesets
Changeset: 4f9b346d09c6 Author:mv157916 Date: 2013-11-21 12:36 -0800 URL: http://hg.openjdk.java.net/openjfx/8/master/rt/rev/4f9b346d09c6 RT-34441: We need to update the JDK 8 build number (jfx.build.jdk.buildnum) to b117 in rt/build.properties file in the JavaFX 8 Master forest. ! build.properties Changeset: c786a74301ae Author:Felipe Heidrich felipe.heidr...@oracle.com Date: 2013-11-19 12:35 -0800 URL: http://hg.openjdk.java.net/openjfx/8/master/rt/rev/c786a74301ae RT-34365: On Windows, Hindi with Lucida fonts are rendered as missing glyph (box). ! modules/graphics/src/main/java/com/sun/javafx/font/directwrite/DWGlyphLayout.java Changeset: 779434338ec2 Author:jgiles Date: 2013-11-19 12:54 +1300 URL: http://hg.openjdk.java.net/openjfx/8/master/rt/rev/779434338ec2 RT-34200: [ListView, TableView, TreeTable] Focus resides on wrong cell after ctrl + shift + pgUp ! modules/controls/src/main/java/com/sun/javafx/scene/control/behavior/ListViewBehavior.java ! modules/controls/src/main/java/com/sun/javafx/scene/control/behavior/TableViewBehaviorBase.java ! modules/controls/src/main/java/com/sun/javafx/scene/control/behavior/TreeViewBehavior.java ! modules/controls/src/main/java/com/sun/javafx/scene/control/skin/TableViewSkinBase.java ! modules/controls/src/test/java/javafx/scene/control/ListViewKeyInputTest.java ! modules/controls/src/test/java/javafx/scene/control/TableViewKeyInputTest.java ! modules/controls/src/test/java/javafx/scene/control/TreeTableViewKeyInputTest.java ! modules/controls/src/test/java/javafx/scene/control/TreeViewKeyInputTest.java Changeset: bc971f203bad Author:jgiles Date: 2013-11-19 13:24 +1300 URL: http://hg.openjdk.java.net/openjfx/8/master/rt/rev/bc971f203bad RT-33897: TableView, TreeTableView : getSelectedCells contains incorrect info. ! modules/controls/src/main/java/com/sun/javafx/scene/control/behavior/TableCellBehaviorBase.java ! modules/controls/src/main/java/com/sun/javafx/scene/control/behavior/TreeTableCellBehavior.java ! modules/controls/src/test/java/javafx/scene/control/TableViewMouseInputTest.java ! modules/controls/src/test/java/javafx/scene/control/TreeTableViewMouseInputTest.java Changeset: 6822b605f971 Author:jgiles Date: 2013-11-19 15:16 +1300 URL: http://hg.openjdk.java.net/openjfx/8/master/rt/rev/6822b605f971 RT-34103: in TreeTableView wrong items are selected when the parent item is collapsed ! modules/controls/src/main/java/javafx/scene/control/TreeTableView.java ! modules/controls/src/main/java/javafx/scene/control/TreeView.java ! modules/controls/src/test/java/javafx/scene/control/TreeTableViewSelectionModelImplTest.java ! modules/controls/src/test/java/javafx/scene/control/TreeViewTest.java Changeset: ffe2faef0e0a Author:jgiles Date: 2013-11-20 10:53 +1300 URL: http://hg.openjdk.java.net/openjfx/8/master/rt/rev/ffe2faef0e0a RT-34269: Shift+PgUp doesn't move focus to the beginning of the list ! modules/controls/src/main/java/com/sun/javafx/scene/control/behavior/ListViewBehavior.java ! modules/controls/src/main/java/com/sun/javafx/scene/control/behavior/TableViewBehaviorBase.java ! modules/controls/src/main/java/com/sun/javafx/scene/control/behavior/TreeViewBehavior.java ! modules/controls/src/main/java/javafx/scene/control/TableView.java ! modules/controls/src/main/java/javafx/scene/control/TreeTableView.java ! modules/controls/src/test/java/javafx/scene/control/ListViewKeyInputTest.java ! modules/controls/src/test/java/javafx/scene/control/TableViewKeyInputTest.java ! modules/controls/src/test/java/javafx/scene/control/TreeTableViewKeyInputTest.java ! modules/controls/src/test/java/javafx/scene/control/TreeViewKeyInputTest.java Changeset: df2083ee4833 Author:jgiles Date: 2013-11-20 14:37 +1300 URL: http://hg.openjdk.java.net/openjfx/8/master/rt/rev/df2083ee4833 RT-26718: [TreeView] focus and anchor are set incorrectly on collapsing of item. ! modules/controls/src/main/java/javafx/scene/control/MultipleSelectionModelBase.java ! modules/controls/src/main/java/javafx/scene/control/TableView.java ! modules/controls/src/main/java/javafx/scene/control/TreeTableView.java ! modules/controls/src/main/java/javafx/scene/control/TreeView.java ! modules/controls/src/test/java/javafx/scene/control/TreeTableViewTest.java ! modules/controls/src/test/java/javafx/scene/control/TreeViewTest.java Changeset: cb5374d6bbde Author:jgiles Date: 2013-11-20 15:00 +1300 URL: http://hg.openjdk.java.net/openjfx/8/master/rt/rev/cb5374d6bbde Fix for typo in changeset for RT-34269 (cb5cd83b0f7f) ! modules/controls/src/main/java/com/sun/javafx/scene/control/behavior/ListViewBehavior.java Changeset: d36961aec425 Author:jgiles Date: 2013-11-20 15:32 +1300 URL: http://hg.openjdk.java.net/openjfx/8/master/rt/rev/d36961aec425 [TEST ONLY] Fixing up the TreeTableViewSelectionModelImplTest test class - it doesn't need to
hg: openjfx/8/graphics/rt: 2 new changesets
Changeset: 1db4c60bfd5b Author:Anthony Petrov anthony.pet...@oracle.com Date: 2013-11-28 22:52 +0400 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/1db4c60bfd5b RT-33881: Mac: System menu bar doesn't work at all with MacOS 10.9 Reviewed-by: snorthov, pchelko ! modules/graphics/src/main/native-glass/mac/GlassApplication.m Changeset: 7d1dfcec57c0 Author:snorthov Date: 2013-11-28 14:00 -0500 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/7d1dfcec57c0 IOS CHANGE ONLY: avoid exception when UUID algorithm not present ! modules/web/src/ios/java/javafx/scene/web/JS2JavaBridge.java
hg: openjfx/8/graphics/rt: 4 new changesets
Changeset: 022ac7cdcad1 Author:jgiles Date: 2013-11-28 15:12 +1300 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/022ac7cdcad1 RT-33613: TableView, TreeTableView moves focus to the wrong item in selection ! modules/controls/src/main/java/com/sun/javafx/scene/control/behavior/TableViewBehaviorBase.java ! modules/controls/src/test/java/javafx/scene/control/TableViewKeyInputTest.java ! modules/controls/src/test/java/javafx/scene/control/TreeTableViewKeyInputTest.java Changeset: 24dda4be6617 Author:jgiles Date: 2013-11-28 15:22 +1300 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/24dda4be6617 RT-34239: TableViewKeyInputTest tests fails in Linux ! modules/controls/src/main/java/com/sun/javafx/scene/control/behavior/TableViewBehaviorBase.java Changeset: 24f2584b90eb Author:jgiles Date: 2013-11-29 08:16 +1300 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/24f2584b90eb RT-34573: Resetting ComboBox items makes the buttonCell display the invalid last selected item ! modules/controls/src/main/java/com/sun/javafx/scene/control/skin/ComboBoxListViewSkin.java ! modules/controls/src/test/java/javafx/scene/control/ComboBoxTest.java Changeset: 20724ec5e62e Author:jgiles Date: 2013-11-29 08:25 +1300 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/20724ec5e62e [TEST ONLY] Test for RT-34566, which happened to be fixed by RT-34573. ! modules/controls/src/test/java/javafx/scene/control/ComboBoxTest.java
hg: openjfx/8/graphics/rt: RT-34579: Mac: OS X System MenuBar causes null pointer exception with a graphic that has a null Image.
Changeset: cc089c819470 Author:Anthony Petrov anthony.pet...@oracle.com Date: 2013-11-29 00:40 +0400 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/cc089c819470 RT-34579: Mac: OS X System MenuBar causes null pointer exception with a graphic that has a null Image. Summary: Added a null check ! modules/graphics/src/main/java/com/sun/javafx/tk/quantum/GlassSystemMenu.java
hg: openjfx/8/graphics/rt: RT-34513 Regression: Popup in a popup behaves unexpectedly
Changeset: ff6e3fb3b1e8 Author:Martin Sladecek martin.slade...@oracle.com Date: 2013-11-29 08:17 +0100 URL: http://hg.openjdk.java.net/openjfx/8/graphics/rt/rev/ff6e3fb3b1e8 RT-34513 Regression: Popup in a popup behaves unexpectedly Reviewed by: jgiles ! modules/controls/src/main/java/com/sun/javafx/scene/control/skin/ContextMenuContent.java
