Re: openjfx-8u20-b23: Stuck in monocle build for armv7hf

2014-07-30 Thread Prasant J
On Thu, Jul 31, 2014 at 10:10 AM, Prasant J  wrote:
> On Wed, Jul 30, 2014 at 11:16 PM, Lisa Selle  wrote:
>> How did you install your arm toolchain?
>>
>
> I'm using yocto (poky distribution) for my iMX6. I can build my own
> SDK (toolchain). I'm using that.
> I may have made some mistake is setting up the toolchain (I will look
> into that one again).
>

I have now corrected the toolchian setup!

>
>> https://wiki.openjdk.java.net/display/OpenJFX/Cross+Building+for+Arm+Hard+Float
>>
>> If it's installed according to these instructions pkg-config should get
>> picked up from the correct place and there should be no need to set any
>> environment variables.
>
> Is there a way to set environment variables?
>
>>

Still stuck at the same point.

In my linux shell I executed the following commands:

./pkg-config --cflags pangoft2  [cannot find package pangoft2]
PKG_CONFIG_PATH= ./pkg-config --cflags pangoft2  [finds the
package and lists the cflags]

So, is there any way to pass the environment variable PKG_CONFIG_PATH
before executing 'commandLine' ?


Regards, Pj


Re: openjfx-8u20-b23: Stuck in monocle build for armv7hf

2014-07-30 Thread Prasant J
On Wed, Jul 30, 2014 at 11:16 PM, Lisa Selle  wrote:
> How did you install your arm toolchain?
>

I'm using yocto (poky distribution) for my iMX6. I can build my own
SDK (toolchain). I'm using that.
I may have made some mistake is setting up the toolchain (I will look
into that one again).


> https://wiki.openjdk.java.net/display/OpenJFX/Cross+Building+for+Arm+Hard+Float
>
> If it's installed according to these instructions pkg-config should get
> picked up from the correct place and there should be no need to set any
> environment variables.

Is there a way to set environment variables?

>
> Thanks,
>
> Lisa
>
> On 7/30/2014 10:24 AM, Prasant J wrote:
>>
>> Hi,
>>
>> I'm trying to cross compile openjfx-8u20-b23 for armv7hf (Freescale
>> iMX6Q).
>>
>> However, I'm stuck at this point:
>> in file buildSrc/armv7hf.gradle
>> pangoft cflags are being queried using exec { commandline...}.
>>
>> However, the pkg-config returns null as it does not find the correct
>> PKG_CONFIG_PATH environment.
>>
>>
>> How do I set the required linux environment variables (when using gradle
>> exec)?
>>
>>
>> Regards, Pj
>
>


Re: How to pause service when it's not visible in TabPane

2014-07-30 Thread Tomas Mikula
On Thu, Jul 31, 2014 at 12:51 AM, Tomas Mikula  wrote:
> I'm not sure I understand: you have many service subclasses, each of
> them associated with a tab? If so, they can take the tab as an
> argument to the constructor:
>
> abstract class TabService extends Service {
> protected MyAbstractService(Tab tab) {

This should have been

protected TabService(Tab tab) {

> tab.selectedProperty().addListener((obs, old, selected) -> {
> if(selected) {
> restart();
> } else {
> cancel();
> }
> });
> }
> }
>
> class FooService extends TabService {
> public FooService(Tab tab) {
> super(tab);
> }
> }
>
> Alternatively, you can have a Tab subclass that takes Service as
> constructor argument.
>
> Alternatively, you can have a static helper method that binds the
> service to the tab and use it from any class:
>
> static bind(Service service, Tab tab) {
> tab.selectedProperty().addListener((obs, old, selected) -> {
> if(selected) {
> service.restart();
> } else {
> service.cancel();
> }
> });
> }
>
> Was that an answer to your question?
>
> Best,
> Tomas
>
> On Wed, Jul 30, 2014 at 3:44 PM, Peter Penzov  wrote:
>> Hi Tomas,
>>   I'm not 100% sure but I tested the proposed code and it seems that it's
>> working. One more question. I have too many Java Classes into which I need
>> to implement this. Is there a quick and easy way to get the Tab Object into
>> the service class where I need to implement this?
>>
>> BR,
>> Peter
>>
>>
>> On Wed, Jul 30, 2014 at 1:22 PM, Tomas Mikula 
>> wrote:
>>>
>>> What about
>>>
>>> tab.selectedProperty().addListener((obs, old, selected) -> {
>>> if(selected) {
>>> service.restart();
>>> } else {
>>> service.cancel();
>>> }
>>> });
>>>
>>> ?
>>>
>>> Best,
>>> Tomas
>>>
>>> On Wed, Jul 30, 2014 at 9:07 AM, Peter Penzov 
>>> wrote:
>>> > Hi All,
>>> >I have a TabPane with JavaFX service which displays some data. I'm
>>> > interested is there a way to pause the service when I switch the tabs
>>> > and
>>> > the service is not visible? It 'will same me a lot of CPU resources if
>>> > there is a way to implement this.
>>> >
>>> > BR,
>>> > Peter
>>
>>


Re: How to pause service when it's not visible in TabPane

2014-07-30 Thread Tomas Mikula
I'm not sure I understand: you have many service subclasses, each of
them associated with a tab? If so, they can take the tab as an
argument to the constructor:

abstract class TabService extends Service {
protected MyAbstractService(Tab tab) {
tab.selectedProperty().addListener((obs, old, selected) -> {
if(selected) {
restart();
} else {
cancel();
}
});
}
}

class FooService extends TabService {
public FooService(Tab tab) {
super(tab);
}
}

Alternatively, you can have a Tab subclass that takes Service as
constructor argument.

Alternatively, you can have a static helper method that binds the
service to the tab and use it from any class:

static bind(Service service, Tab tab) {
tab.selectedProperty().addListener((obs, old, selected) -> {
if(selected) {
service.restart();
} else {
service.cancel();
}
});
}

Was that an answer to your question?

Best,
Tomas

On Wed, Jul 30, 2014 at 3:44 PM, Peter Penzov  wrote:
> Hi Tomas,
>   I'm not 100% sure but I tested the proposed code and it seems that it's
> working. One more question. I have too many Java Classes into which I need
> to implement this. Is there a quick and easy way to get the Tab Object into
> the service class where I need to implement this?
>
> BR,
> Peter
>
>
> On Wed, Jul 30, 2014 at 1:22 PM, Tomas Mikula 
> wrote:
>>
>> What about
>>
>> tab.selectedProperty().addListener((obs, old, selected) -> {
>> if(selected) {
>> service.restart();
>> } else {
>> service.cancel();
>> }
>> });
>>
>> ?
>>
>> Best,
>> Tomas
>>
>> On Wed, Jul 30, 2014 at 9:07 AM, Peter Penzov 
>> wrote:
>> > Hi All,
>> >I have a TabPane with JavaFX service which displays some data. I'm
>> > interested is there a way to pause the service when I switch the tabs
>> > and
>> > the service is not visible? It 'will same me a lot of CPU resources if
>> > there is a way to implement this.
>> >
>> > BR,
>> > Peter
>
>


hg: openjfx/8u-dev/rt: [Accessibility] implementing expand and collapse action for treeitem and tabletreeitem on Mac, use Control+Option+\

2014-07-30 Thread felipe . heidrich
Changeset: cf703edd10f2
Author:Felipe Heidrich 
Date:  2014-07-30 14:48 -0700
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/cf703edd10f2

[Accessibility] implementing expand and collapse action for treeitem and 
tabletreeitem on Mac, use Control+Option+\

! modules/graphics/src/main/java/com/sun/glass/ui/mac/MacAccessible.java



Re: openjfx-8u20-b23: Stuck in monocle build for armv7hf

2014-07-30 Thread Lisa Selle

How did you install your arm toolchain?

https://wiki.openjdk.java.net/display/OpenJFX/Cross+Building+for+Arm+Hard+Float

If it's installed according to these instructions pkg-config should get 
picked up from the correct place and there should be no need to set any 
environment variables.


Thanks,

Lisa
On 7/30/2014 10:24 AM, Prasant J wrote:

Hi,

I'm trying to cross compile openjfx-8u20-b23 for armv7hf (Freescale iMX6Q).

However, I'm stuck at this point:
in file buildSrc/armv7hf.gradle
pangoft cflags are being queried using exec { commandline...}.

However, the pkg-config returns null as it does not find the correct
PKG_CONFIG_PATH environment.


How do I set the required linux environment variables (when using gradle exec)?


Regards, Pj




[8u40] Review reequest: RT-38012 Date/time converters use unwanted format patterns

2014-07-30 Thread Leif Samuelsson

Hi Jonathan,

Please review this fix which adds two new constructors to each of three 
converter classes.

  https://javafx-jira.kenai.com/browse/RT-38012

  http://cr.openjdk.java.net/~leifs/rt38012/webrev.01/

Thanks,
Leif


Re: [API REVIEW REQUEST] RT-19659 - [TabPane] Support for draggable tabs

2014-07-30 Thread Scott Palmer
There are a couple concepts here.. re-ordering, just like TableView
columns, and "detaching" which would be required to drag a tab out of the
TabPane.  The API should reflect these related, but distinct, concepts.


On Wed, Jul 30, 2014 at 11:51 AM, Stephen F Northover <
steve.x.northo...@oracle.com> wrote:

> Thanks Tom,
>
> We'll take a look at the patch in the JIRA: https://javafx-jira.kenai.com/
> browse/RT-19659
>
> Steve
>
>
> On 2014-07-30, 3:35 AM, Tom Schindl wrote:
>
>> Hi,
>>
>> I'd like you to review the API proposed to make TabPane Tabs draggable.
>>
>> The proposed public API only allows to put the TabPane in DnD mode:
>>
>> public boolean isDndEnabled()
>> public void setDndEnabled(boolean dndEnabled)
>> public BooleanProperty dndEnabledProperty()
>>
>> Tom
>>
>
>


Re: [API REVIEW REQUEST] RT-19659 - [TabPane] Support for draggable tabs

2014-07-30 Thread Stephen F Northover

Thanks Tom,

We'll take a look at the patch in the JIRA: 
https://javafx-jira.kenai.com/browse/RT-19659


Steve

On 2014-07-30, 3:35 AM, Tom Schindl wrote:

Hi,

I'd like you to review the API proposed to make TabPane Tabs draggable.

The proposed public API only allows to put the TabPane in DnD mode:

public boolean isDndEnabled()
public void setDndEnabled(boolean dndEnabled)
public BooleanProperty dndEnabledProperty()

Tom




Re: [8u40] Review request: RT-38074: [macosx] Separate QTKit platform code from core media code so it can be removed for MAS

2014-07-30 Thread David DeHaven

JIRA Issue:
https://javafx-jira.kenai.com/browse/RT-38074

Latest webrev:
http://cr.openjdk.java.net/~ddehaven/RT-38074/rt.2/

Removed new makefile (eyesore), cleaned up/enhanced existing Makefile, fixed a 
compiler warning.

Last iteration hopefully, I let it bake for 12 hours and haven't had the urge 
to change anything ;)

-DrD-

> 
> Kirill, Alexander, Kevin:
> 
> New version up for review, please take a look:
> http://cr.openjdk.java.net/~ddehaven/RT-38074/rt.1/
> 
> I moved OSXPlatform and OSXMediaPlayer code back to jfxmedia, since it was 
> meant to be an abstraction point for using either QTKit or AVFoundation in 
> the first place.
> 
> -DrD-
> 
>> 
>> Belay that review.. I have some (significant) changes to make, in 
>> preparation for the larger task of implementing the AVFoundation based code.
>> 
>> -DrD-
>> 
>>> JIRA:
>>> https://javafx-jira.kenai.com/browse/RT-38074
>>> 
>>> Webrev:
>>> http://cr.openjdk.java.net/~ddehaven/RT-38074/rt.0/
>>> 
>>> This change moves the QTKit based media platform code into it's own dylib. 
>>> NativeMediaManager had to be modified to allow detection of the new library 
>>> to determine if the platform was available or not. There may be a slight 
>>> performance impact due to loading the native libs sooner, but the bulk of 
>>> the initialization is still done at a later time.
>>> 
>>> -DrD-
>>> 
>> 
> 



Re: Skin layoutChildren: when to get bounds of child nodes?

2014-07-30 Thread Martin Sladecek

On 07/30/2014 05:12 PM, Werner Lehmann wrote:


layoutChildren() {
  ...
  bip = child1.getBoundsInParent()
  if (bip.getMinX() == 0 && bip.getWidth() == 0) {
vbox.layout();
bip = child1.getBoundsInParent();
  }
  ...
}

I assume you don't change "child1" Nodes, so it should work.

It sure does. I have created pane-based controls with manual layouting 
before but it is some work to get it right, especially with the 
computeMinPrefMaxWidthHeight methods (sometimes +baseline), snapsize 
etc pp. I figured it is not worth the hassle here if a vbox and hbox 
do 95% of what I need :)  A cleaner approach would be to make child2 
unmanaged as you suggest but then I need to reserve vertical space in 
its vbox container, currently done with css padding on the region 
itself. For the time being I have to stick with this and move on.


Yeah, one problem with layouts is when you want to do some layout that 
is almost the same as some predefined layout, but you need to tweak it 
somehow. Maybe in the future we could add some abstraction and extract 
some (parts of) the algorithms we use in our layout containers so they 
can be reused in custom layouts.
If you reuse some predefined layout, you'll probably end up with some 
hacky code since you'll usually mess up with the inputs for the layout. 
The rule of thumb is to use some more complex (GridPane) or free form 
(AnchorPane) layout instead of trying to slightly tweak some simple layout.
In your case, wouldn't GridPane do the job? Basically, you have a row of 
text nodes and you need a second row where a single rectangle is in the 
same column as currently selected (?) text node. The size of the 
rectangle can be set to fillWidth the column, so GridPane will do all 
the work for you.


-Martin


Re: Skin layoutChildren: when to get bounds of child nodes?

2014-07-30 Thread Werner Lehmann

Martin,

thanks a lot for this elaborate explanation :)  Here's an image of what 
I am talking about.


http://postimg.org/image/t9a6esc71/

child1 is one of the labels in a hbox, e.g. "Query" or "Result"
child2 is the blueish region. It needs to be positioned under one of 
those labels. I am doing this with translateX and prefWidth.


On 28.07.2014 07:38, Martin Sladecek wrote:

The super.layoutChildren should size every child of the control (which
is VBox), but not child's children. The control must finish the layout
before children can do theirs. If you need to do layout on some child
before that, you can call .layout() on it. It will do it's layout using
it's current size. You should have all the bounds correct after that call.



But that would not work in your case anyway. You have both childs in a
HBox, which takes care of resizing the children. This means you need to
layout the HBox to get children size and in order to do that, you need
HBox to be at it's final size, which will happen during the VBox layout.
So your steps would be:
1) super.layoutChildren() - VBox is resized to Controls content size
2) now the VBox is resized, you can call vbox.layout()
3) now HBox is resized, so call hbox.layout()
4) children are resized. They have correct layout bounds now. But in
order to get correct boundsInParent (but maybe you really need layout
bounds?), you need to call .layout() on children too.


I my tests it was sufficient to do this:

layoutChildren() {
  ...
  bip = child1.getBoundsInParent()
  if (bip.getMinX() == 0 && bip.getWidth() == 0) {
vbox.layout();
bip = child1.getBoundsInParent();
  }
  ...
}

Might not be efficient (or pretty) but seems to work.


Even if you do all these steps, calling setPrefWidth() on child2 marks
the whole tree dirty again. Because HBox needs to resize child2 using
it's new PrefWidth. This also means, HBox prefwidth will be different,
so it's parent (VBox) must do the same. Ditto with the control. Also,
the HBox (VBox, control) may not have enough size to resize child2 to
it's pref width, so child1 might be shrinked as a result, which breaks
your invariant. You are basically changing the input for HBox's layout
(child2.pref size) based on it's output (child1 size), which makes this
a loop.


Makes sense.


So in order to really make this work, you need to manage the child nodes
directly and compute your layout by yourself. This can be done either by
using your own subclass of Pane and overriding it's layoutChildren. Or
if you want to do everything in Skin's layoutChildren, you can make the
children unmanaged, but then it doesn't really matter where they are in
the scenegraph, HBox won't be managing them.

Hope this helps!


It sure does. I have created pane-based controls with manual layouting 
before but it is some work to get it right, especially with the 
computeMinPrefMaxWidthHeight methods (sometimes +baseline), snapsize etc 
pp. I figured it is not worth the hassle here if a vbox and hbox do 95% 
of what I need :)  A cleaner approach would be to make child2 unmanaged 
as you suggest but then I need to reserve vertical space in its vbox 
container, currently done with css padding on the region itself. For the 
time being I have to stick with this and move on.


Thanks again.

Werner


openjfx-8u20-b23: Stuck in monocle build for armv7hf

2014-07-30 Thread Prasant J
Hi,

I'm trying to cross compile openjfx-8u20-b23 for armv7hf (Freescale iMX6Q).

However, I'm stuck at this point:
in file buildSrc/armv7hf.gradle
pangoft cflags are being queried using exec { commandline...}.

However, the pkg-config returns null as it does not find the correct
PKG_CONFIG_PATH environment.


How do I set the required linux environment variables (when using gradle exec)?


Regards, Pj


hg: openjfx/8u-dev/rt: Restoring some erroneously pushed files to previous changeset

2014-07-30 Thread mo . chicharro
Changeset: 72ae8aa29e73
Author:mchicharro
Date:  2014-07-30 15:20 +0100
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/72ae8aa29e73

Restoring some erroneously pushed files to previous changeset

! .idea/copyright/profiles_settings.xml
! .idea/vcs.xml
! apps/samples/Modena/src/main/java/modena/SamplePage.java



hg: openjfx/8u-dev/rt: Spinner CSS tweaks for Modena - partial fix for RT-38028

2014-07-30 Thread mo . chicharro
Changeset: ca0e03f527ba
Author:mchicharro
Date:  2014-07-30 14:59 +0100
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/ca0e03f527ba

Spinner CSS tweaks for Modena - partial fix for RT-38028

! .idea/copyright/profiles_settings.xml
! .idea/vcs.xml
! apps/samples/Modena/src/main/java/modena/SamplePage.java
! 
modules/controls/src/main/resources/com/sun/javafx/scene/control/skin/modena/modena.css



Re: How to pause service when it's not visible in TabPane

2014-07-30 Thread Peter Penzov
Hi Tomas,
  I'm not 100% sure but I tested the proposed code and it seems that it's
working. One more question. I have too many Java Classes into which I need
to implement this. Is there a quick and easy way to get the Tab Object into
the service class where I need to implement this?

BR,
Peter


On Wed, Jul 30, 2014 at 1:22 PM, Tomas Mikula 
wrote:

> What about
>
> tab.selectedProperty().addListener((obs, old, selected) -> {
> if(selected) {
> service.restart();
> } else {
> service.cancel();
> }
> });
>
> ?
>
> Best,
> Tomas
>
> On Wed, Jul 30, 2014 at 9:07 AM, Peter Penzov 
> wrote:
> > Hi All,
> >I have a TabPane with JavaFX service which displays some data. I'm
> > interested is there a way to pause the service when I switch the tabs and
> > the service is not visible? It 'will same me a lot of CPU resources if
> > there is a way to implement this.
> >
> > BR,
> > Peter
>


Re: Skin layoutChildren: when to get bounds of child nodes?

2014-07-30 Thread Werner Lehmann

Richard,

since I need to get x and width of child1 (the one inside the hbox) I 
have to use boundsInParent. According to the docs layoutBounds.x/y are 
always zero for resizable nodes so it does not work here. As to the 
question whether the parent might be size 0: the HBox is indeed size 0 
after the initial call to super.layoutChildren. The containing VBox has 
some 800x400 px though.


I think the reason is probably in Martin's reply although I may not like 
it ;-)


Werner

On 25.07.2014 18:56, Richard Bair wrote:

Hmmm. The first question I have is whether boundsInParent is really
what you want to use, vs. layout bounds. But assuming it is what you
want, why are the bounds zero? This is during the layout pass, which
is the right place to be doing what you’re doing. The super
layoutChildren call will size everything based on the contentX,
contentY, contentWidth, contentHeight
(http://hg.openjdk.java.net/openjfx/8u-dev/rt/file/4b8d06211312/modules/controls/src/main/java/javafx/scene/control/SkinBase.java).
Is it possible that the parent itself is size 0? boundsInParent
should always be invalidated automatically whenever the
width/height/transforms/etc changes. If not that is definitely a bug
(that you can write a simple test case for to prove).

But my first guess is maybe the parent is size 0 as well, due to
something else (maybe the pref size of the control is 0 to start with
or something…)

Richard




Re: [API REVIEW REQUEST] RT-19659 - [TabPane] Support for draggable tabs

2014-07-30 Thread Mikael Grev
Wouldn’t you still need to specify the “kind” of drag you are moderating?

With just a boolean on/off now, a later API where one needs to say what kinds 
of drags (reorder, between tabpanes and drag out) would be hard to create. 
One don’t want an API with a master switch AND one for each kind of drag IMO.

Cheers,
Mikael

On 30 Jul 2014, at 10:47, Tom Schindl  wrote:

> Hi,
> 
> The proposed API only allows to turn on/off dragging all together.
> 
> For your usecase I'd envision a future API which would allow one to
> control the aspects you are asking for like.
> 
> The API i currently have in mind is but I have not yet explored:
> 
> // Would allow to cancel dragging of certain tabs
> tabDndDragStartCallback: BiFunction
> 
> // Would allow to cancel the dragging of the tab outside the container
> // == only allows reordering
> tabDndDragExitedCallback: BiFunction
> 
> // Would allow the SOURCE to cancel the dragging to a specific target //
> (could make tabDndDragExitedCallback obsolete)
> tabDndDragOverTargetCallback: BiFunction
> 
> // Would allow to cancel the drag over in the TARGET
> tabDndDragOverCallback: BiFunction
> 
> // Would allow to cancel the dropping of a tab in a container
> tabDndDropCallback: BiFunction
> 
> Tom
> 
> On 30.07.14 10:27, Mikael Grev wrote:
>> That is decidedly awesome!
>> 
>> Is there some other way of deciding whether to to do one or the other? I 
>> mean one might want to reorder but not drag to another pane.
>> 
>> Cheers,
>> Mikael
>> 
>> On 30 Jul 2014, at 10:09, Tom Schindl  wrote:
>> 
>>> No - it allows also to drag the tab to another TabPane as well and in
>>> future outside the window to detach it.
>>> 
>>> Tom
>>> 
>>> On 30.07.14 10:07, Eric Le Ponner wrote:
 Hi Tom,
 
 I wonder if we should really use the wording « dnd ».
 The feature is really to enable the user to re-order the tabs 
 inside a TabPane, right ?
 
 So may be:
 
 public boolean isTabReorderingEnabled();
 public void setTabReorderingEnabled(boolean tabReorderingEnabled);
 public BooleanProperty tabReorderingEnabledProperty();
 
 Eric
 
 PS: I’m assuming you don’t expect this gesture to work between two 
 different TabPanes.
 
 
 
 Le 30 juil. 2014 à 09:35, Tom Schindl  a 
 écrit :
 
> Hi,
> 
> I'd like you to review the API proposed to make TabPane Tabs draggable.
> 
> The proposed public API only allows to put the TabPane in DnD mode:
> 
> public boolean isDndEnabled()
> public void setDndEnabled(boolean dndEnabled)
> public BooleanProperty dndEnabledProperty()
> 
> Tom
 
>>> 
>> 
> 



hg: openjfx/8u-dev/rt: Added inner shadow grad for Editable ComboBox and DatePicker textfields - partial fix for RT-38028

2014-07-30 Thread mo . chicharro
Changeset: 78bac6b0c37e
Author:mchicharro
Date:  2014-07-30 12:02 +0100
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/78bac6b0c37e

Added inner shadow grad for Editable ComboBox and DatePicker textfields - 
partial fix for RT-38028

! 
modules/controls/src/main/resources/com/sun/javafx/scene/control/skin/modena/modena.css



hg: openjfx/8u-dev/rt: Spinner CSS for Caspian - removed pixel based padding - partial fix for RT-38028

2014-07-30 Thread mo . chicharro
Changeset: 59b63ebbd0be
Author:mchicharro
Date:  2014-07-30 11:43 +0100
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/59b63ebbd0be

Spinner CSS for Caspian - removed pixel based padding - partial fix for RT-38028

! 
modules/controls/src/main/resources/com/sun/javafx/scene/control/skin/caspian/caspian.css



hg: openjfx/8u-dev/rt: Spinner CSS for Caspian - partial fix for RT-38028

2014-07-30 Thread mo . chicharro
Changeset: 562928b80d15
Author:mchicharro
Date:  2014-07-30 11:30 +0100
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/562928b80d15

Spinner CSS for Caspian - partial fix for RT-38028

! 
modules/controls/src/main/resources/com/sun/javafx/scene/control/skin/caspian/caspian.css



Re: How to pause service when it's not visible in TabPane

2014-07-30 Thread Tomas Mikula
What about

tab.selectedProperty().addListener((obs, old, selected) -> {
if(selected) {
service.restart();
} else {
service.cancel();
}
});

?

Best,
Tomas

On Wed, Jul 30, 2014 at 9:07 AM, Peter Penzov  wrote:
> Hi All,
>I have a TabPane with JavaFX service which displays some data. I'm
> interested is there a way to pause the service when I switch the tabs and
> the service is not visible? It 'will same me a lot of CPU resources if
> there is a way to implement this.
>
> BR,
> Peter


hg: openjfx/8u-dev/rt: RT-37824 [Charts] Series: NPE when adding data items multiple times

2014-07-30 Thread martin . sladecek
Changeset: d515c3182f1c
Author:Martin Sladecek 
Date:  2014-07-30 10:51 +0200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/d515c3182f1c

RT-37824 [Charts] Series: NPE when adding data items multiple times
Reviewed by: snorthov, jgiles

! modules/controls/src/main/java/javafx/scene/chart/AreaChart.java
! modules/controls/src/main/java/javafx/scene/chart/BarChart.java
! modules/controls/src/main/java/javafx/scene/chart/LineChart.java
! modules/controls/src/main/java/javafx/scene/chart/ScatterChart.java
! modules/controls/src/main/java/javafx/scene/chart/StackedAreaChart.java
! modules/controls/src/main/java/javafx/scene/chart/XYChart.java



Re: [API REVIEW REQUEST] RT-19659 - [TabPane] Support for draggable tabs

2014-07-30 Thread Tom Schindl
Hi,

The proposed API only allows to turn on/off dragging all together.

For your usecase I'd envision a future API which would allow one to
control the aspects you are asking for like.

The API i currently have in mind is but I have not yet explored:

// Would allow to cancel dragging of certain tabs
tabDndDragStartCallback: BiFunction

// Would allow to cancel the dragging of the tab outside the container
// == only allows reordering
tabDndDragExitedCallback: BiFunction

// Would allow the SOURCE to cancel the dragging to a specific target //
(could make tabDndDragExitedCallback obsolete)
tabDndDragOverTargetCallback: BiFunction

// Would allow to cancel the drag over in the TARGET
tabDndDragOverCallback: BiFunction

// Would allow to cancel the dropping of a tab in a container
tabDndDropCallback: BiFunction

Tom

On 30.07.14 10:27, Mikael Grev wrote:
> That is decidedly awesome!
> 
> Is there some other way of deciding whether to to do one or the other? I mean 
> one might want to reorder but not drag to another pane.
> 
> Cheers,
> Mikael
> 
> On 30 Jul 2014, at 10:09, Tom Schindl  wrote:
> 
>> No - it allows also to drag the tab to another TabPane as well and in
>> future outside the window to detach it.
>>
>> Tom
>>
>> On 30.07.14 10:07, Eric Le Ponner wrote:
>>> Hi Tom,
>>>
>>> I wonder if we should really use the wording « dnd ».
>>> The feature is really to enable the user to re-order the tabs 
>>> inside a TabPane, right ?
>>>
>>> So may be:
>>>
>>> public boolean isTabReorderingEnabled();
>>> public void setTabReorderingEnabled(boolean tabReorderingEnabled);
>>> public BooleanProperty tabReorderingEnabledProperty();
>>>
>>> Eric
>>>
>>> PS: I’m assuming you don’t expect this gesture to work between two 
>>> different TabPanes.
>>>
>>>
>>>
>>> Le 30 juil. 2014 à 09:35, Tom Schindl  a écrit 
>>> :
>>>
 Hi,

 I'd like you to review the API proposed to make TabPane Tabs draggable.

 The proposed public API only allows to put the TabPane in DnD mode:

 public boolean isDndEnabled()
 public void setDndEnabled(boolean dndEnabled)
 public BooleanProperty dndEnabledProperty()

 Tom
>>>
>>
> 



Re: [API REVIEW REQUEST] RT-19659 - [TabPane] Support for draggable tabs

2014-07-30 Thread Eric Le Ponner
Interesting.
Then may be ‘drag’ wording would more consistent with remaining APIs.
‘dnd’ is currently used nowhere else.

Eric


Le 30 juil. 2014 à 10:09, Tom Schindl  a écrit :

> No - it allows also to drag the tab to another TabPane as well and in
> future outside the window to detach it.
> 
> Tom
> 
> On 30.07.14 10:07, Eric Le Ponner wrote:
>> Hi Tom,
>> 
>> I wonder if we should really use the wording « dnd ».
>> The feature is really to enable the user to re-order the tabs 
>> inside a TabPane, right ?
>> 
>> So may be:
>> 
>> public boolean isTabReorderingEnabled();
>> public void setTabReorderingEnabled(boolean tabReorderingEnabled);
>> public BooleanProperty tabReorderingEnabledProperty();
>> 
>> Eric
>> 
>> PS: I’m assuming you don’t expect this gesture to work between two different 
>> TabPanes.
>> 
>> 
>> 
>> Le 30 juil. 2014 à 09:35, Tom Schindl  a écrit :
>> 
>>> Hi,
>>> 
>>> I'd like you to review the API proposed to make TabPane Tabs draggable.
>>> 
>>> The proposed public API only allows to put the TabPane in DnD mode:
>>> 
>>> public boolean isDndEnabled()
>>> public void setDndEnabled(boolean dndEnabled)
>>> public BooleanProperty dndEnabledProperty()
>>> 
>>> Tom
>> 
> 



Re: [API REVIEW REQUEST] RT-19659 - [TabPane] Support for draggable tabs

2014-07-30 Thread Mikael Grev
That is decidedly awesome!

Is there some other way of deciding whether to to do one or the other? I mean 
one might want to reorder but not drag to another pane.

Cheers,
Mikael

On 30 Jul 2014, at 10:09, Tom Schindl  wrote:

> No - it allows also to drag the tab to another TabPane as well and in
> future outside the window to detach it.
> 
> Tom
> 
> On 30.07.14 10:07, Eric Le Ponner wrote:
>> Hi Tom,
>> 
>> I wonder if we should really use the wording « dnd ».
>> The feature is really to enable the user to re-order the tabs 
>> inside a TabPane, right ?
>> 
>> So may be:
>> 
>> public boolean isTabReorderingEnabled();
>> public void setTabReorderingEnabled(boolean tabReorderingEnabled);
>> public BooleanProperty tabReorderingEnabledProperty();
>> 
>> Eric
>> 
>> PS: I’m assuming you don’t expect this gesture to work between two different 
>> TabPanes.
>> 
>> 
>> 
>> Le 30 juil. 2014 à 09:35, Tom Schindl  a écrit :
>> 
>>> Hi,
>>> 
>>> I'd like you to review the API proposed to make TabPane Tabs draggable.
>>> 
>>> The proposed public API only allows to put the TabPane in DnD mode:
>>> 
>>> public boolean isDndEnabled()
>>> public void setDndEnabled(boolean dndEnabled)
>>> public BooleanProperty dndEnabledProperty()
>>> 
>>> Tom
>> 
> 



hg: openjfx/8u-dev/rt: [TOYS] disable LocalDate and LocalTime spinners in HelloSpinner

2014-07-30 Thread jonathan . giles
Changeset: fd925446754b
Author:jgiles
Date:  2014-07-30 20:17 +1200
URL:   http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/fd925446754b

[TOYS] disable LocalDate and LocalTime spinners in HelloSpinner

! apps/toys/Hello/src/main/java/hello/HelloSpinner.java



Re: [API REVIEW REQUEST] RT-19659 - [TabPane] Support for draggable tabs

2014-07-30 Thread Tom Schindl
No - it allows also to drag the tab to another TabPane as well and in
future outside the window to detach it.

Tom

On 30.07.14 10:07, Eric Le Ponner wrote:
> Hi Tom,
> 
> I wonder if we should really use the wording « dnd ».
> The feature is really to enable the user to re-order the tabs 
> inside a TabPane, right ?
> 
> So may be:
> 
> public boolean isTabReorderingEnabled();
> public void setTabReorderingEnabled(boolean tabReorderingEnabled);
> public BooleanProperty tabReorderingEnabledProperty();
> 
> Eric
> 
> PS: I’m assuming you don’t expect this gesture to work between two different 
> TabPanes.
> 
> 
> 
> Le 30 juil. 2014 à 09:35, Tom Schindl  a écrit :
> 
>> Hi,
>>
>> I'd like you to review the API proposed to make TabPane Tabs draggable.
>>
>> The proposed public API only allows to put the TabPane in DnD mode:
>>
>> public boolean isDndEnabled()
>> public void setDndEnabled(boolean dndEnabled)
>> public BooleanProperty dndEnabledProperty()
>>
>> Tom
> 



Re: [API REVIEW REQUEST] RT-19659 - [TabPane] Support for draggable tabs

2014-07-30 Thread Eric Le Ponner
Hi Tom,

I wonder if we should really use the wording « dnd ».
The feature is really to enable the user to re-order the tabs 
inside a TabPane, right ?

So may be:

public boolean isTabReorderingEnabled();
public void setTabReorderingEnabled(boolean tabReorderingEnabled);
public BooleanProperty tabReorderingEnabledProperty();

Eric

PS: I’m assuming you don’t expect this gesture to work between two different 
TabPanes.



Le 30 juil. 2014 à 09:35, Tom Schindl  a écrit :

> Hi,
> 
> I'd like you to review the API proposed to make TabPane Tabs draggable.
> 
> The proposed public API only allows to put the TabPane in DnD mode:
> 
> public boolean isDndEnabled()
> public void setDndEnabled(boolean dndEnabled)
> public BooleanProperty dndEnabledProperty()
> 
> Tom



[API REVIEW REQUEST] RT-19659 - [TabPane] Support for draggable tabs

2014-07-30 Thread Tom Schindl
Hi,

I'd like you to review the API proposed to make TabPane Tabs draggable.

The proposed public API only allows to put the TabPane in DnD mode:

public boolean isDndEnabled()
public void setDndEnabled(boolean dndEnabled)
public BooleanProperty dndEnabledProperty()

Tom


Re: Making a smaller ComboBox

2014-07-30 Thread Jonathan Giles
More accurately, no one knows off-hand (and without absolute certainty) 
without looking in the code. If anyone should know, it is me, but I've 
been too bogged down to reassure myself that my gut feeling is correct. 
My gut feeling is that the gap is not settable because it is based on 
the width of the first x elements in the list. You'll find the answer in 
ComboBoxListViewSkin, if you are interested.


By default, if there is something you can't do (regardless of whether it 
is due to a lack of API or a lack of API understanding) there is no harm 
in filing a tweak request in Jira requesting the functionality. Either 
we'll respond with a pointer, or else we'll work on it as time permits.


-- Jonathan

On 30/07/2014 7:23 p.m., Mikael Grev wrote:

So, I guess no one knows how to remove the gap between the text and the button 
in ComboBox?

That probably means it’s a bug since padding can be removed from all sides 
except for between the text and the button.

Cheers,
Mikael Grev


On 23 Jul 2014, at 16:11, Mikael Grev  wrote:


Hello all!

(FYI this question has also been asked here without any correct answers: 
http://stackoverflow.com/questions/24852429/making-a-smaller-javafx-combobox )

I'm trying to make a smaller version of the ComboBox but the gap between the 
text and the arrow button is constant no matter what I do.

If I use the css:

.combo-box-base > *.arrow-button {
 -fx-padding: 0 0 0 0;
 -fx-background-color: pink, pink, pink, pink;
}
the arrow button gets smaller but the ComboBox itself still have the same size, 
only increasing the gap between the arrow and text to compensate.

If I do

.combo-box > .list-cell {
 -fx-padding: 0 0 0 0;
 -fx-border-insets: 0 0 0 0;
}
The combo get a smaller height but the width remain fixed.

Is there any way to make the preferred size of the combo smaller by reducing 
the size between the text and arrow?

I have a screenshot of the ComboBox attached.

Cheers,

Mikael Grev





Re: Making a smaller ComboBox

2014-07-30 Thread Mikael Grev
So, I guess no one knows how to remove the gap between the text and the button 
in ComboBox? 

That probably means it’s a bug since padding can be removed from all sides 
except for between the text and the button.

Cheers,
Mikael Grev


On 23 Jul 2014, at 16:11, Mikael Grev  wrote:

> Hello all!
> 
> (FYI this question has also been asked here without any correct answers: 
> http://stackoverflow.com/questions/24852429/making-a-smaller-javafx-combobox )
> 
> I'm trying to make a smaller version of the ComboBox but the gap between the 
> text and the arrow button is constant no matter what I do.
> 
> If I use the css:
> 
> .combo-box-base > *.arrow-button {
> -fx-padding: 0 0 0 0;
> -fx-background-color: pink, pink, pink, pink;
> }
> the arrow button gets smaller but the ComboBox itself still have the same 
> size, only increasing the gap between the arrow and text to compensate.
> 
> If I do
> 
> .combo-box > .list-cell {
> -fx-padding: 0 0 0 0;
> -fx-border-insets: 0 0 0 0;
> }
> The combo get a smaller height but the width remain fixed.
> 
> Is there any way to make the preferred size of the combo smaller by reducing 
> the size between the text and arrow?
> 
> I have a screenshot of the ComboBox attached.
> 
> Cheers,
> 
> Mikael Grev
> 



How to pause service when it's not visible in TabPane

2014-07-30 Thread Peter Penzov
Hi All,
   I have a TabPane with JavaFX service which displays some data. I'm
interested is there a way to pause the service when I switch the tabs and
the service is not visible? It 'will same me a lot of CPU resources if
there is a way to implement this.

BR,
Peter