[8u40] post-commit review: RT-38485: [Quantum] Cleanup renderLock usage to call QuantumToolkit runWith/WithoutRenderLock

2014-08-29 Thread Kevin Rushforth
Post-commit review for: JIRA: https://javafx-jira.kenai.com/browse/RT-38485 Changeset: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e0ac95b3aef1 Simple refactoring to move common code to a utility method in QuantumToolkit as a follow-up to https://javafx-jira.kenai.com/browse/RT-38289

Re: [8u40] post-commit review: RT-38457: Creating a ContextMenu on the JavaFX-Launcher thread causes an IllegalStateException

2014-08-29 Thread Kevin Rushforth
Take 2. I had to revert the original fix because it exposed a bug in StubToolkit causing several test failures. Rather than fixing the (rather fragile) StubToolkit, I just moved the fix for RT-38457 to QuantumToolkit. JIRA: https://javafx-jira.kenai.com/browse/RT-38457 Changeset: http://hg.o

hg: openjfx/8u-dev/rt: 2 new changesets

2014-08-29 Thread kevin . rushforth
Changeset: e0ac95b3aef1 Author:kcr Date: 2014-08-29 15:47 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e0ac95b3aef1 RT-38485: [Quantum] Cleanup renderLock usage to call QuantumToolkit runWith/WithoutRenderLock ! modules/graphics/src/main/java/com/sun/javafx/tk/quant

hg: openjfx/8u-dev/rt: Fix RT-38183: ManagedResource error warnings when screen configuration changes

2014-08-29 Thread james . graham
Changeset: 1777099fe570 Author:flar Date: 2014-08-29 14:28 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/1777099fe570 Fix RT-38183: ManagedResource error warnings when screen configuration changes Reviewed by: Felipe ! modules/graphics/src/main/java/com/sun/javafx/sg

[8u40] Code Review Request: RT-26108 - Implement auto-mipmap support

2014-08-29 Thread Chien Yang
Hi Kevin and Jim, Can you please the proposed implementation? https://javafx-jira.kenai.com/browse/RT-26108 Thanks, - Chien

hg: openjfx/8u-dev/rt: Revert fix for RT-38457 which broke several tests using the StubToolkit

2014-08-29 Thread kevin . rushforth
Changeset: dec228482740 Author:kcr Date: 2014-08-29 13:52 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/dec228482740 Revert fix for RT-38457 which broke several tests using the StubToolkit Backed out changeset 5e65b34a175b ! modules/graphics/src/main/java/com/sun/java

Re: In(Sanity) Testing... Tuesday!!!

2014-08-29 Thread Kevin Rushforth
To be extra clear, the lock is from 1am PDT TUESDAY morning (only in Hawaii is it still Monday night at that time). -- Kevin Lisa Selle wrote: Due to the US holiday on Monday, we'll do our sanity testing on Tuesday instead of Monday this week. The repo will be locked from 1am PDT on MONDAY

In(Sanity) Testing... Tuesday!!!

2014-08-29 Thread Lisa Selle
Due to the US holiday on Monday, we'll do our sanity testing on Tuesday instead of Monday this week. The repo will be locked from 1am PDT on MONDAY (not Sunday) until 11am PDT on TUESDAY. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing If

[8u40] post-commit review: RT-38457: Creating a ContextMenu on the JavaFX-Launcher thread causes an IllegalStateException

2014-08-29 Thread Kevin Rushforth
Post-commit review for: JIRA: https://javafx-jira.kenai.com/browse/RT-38457 Changeset: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/5e65b34a175b This fixes a problem that was exposed by the fix for https://javafx-jira.kenai.com/browse/RT-17716 and is needed to allow creation of ContextMe

hg: openjfx/8u-dev/rt: 2 new changesets

2014-08-29 Thread kevin . rushforth
Changeset: 566591f1da88 Author:kcr Date: 2014-08-29 11:10 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/566591f1da88 RT-38289: [Quantum] Control ActionEvent is fired on Stage closing and the App hangs if modal window is then shown Reviewed-by: anthony, felipe, snortho

Re: Any plans to support CSS transitions?

2014-08-29 Thread David Grieve
Although the CSS features for 9 haven't been settled yet, this is high on my wish list. On 8/29/14, 12:06 PM, Mike Hearn wrote: I enjoy iterating on my UI using JFX CSS and a simple hot reload feature I added to my app, but I still have to drop back into writing code for doing animations. In pr

Any plans to support CSS transitions?

2014-08-29 Thread Mike Hearn
I enjoy iterating on my UI using JFX CSS and a simple hot reload feature I added to my app, but I still have to drop back into writing code for doing animations. In practice this means I use fewer nice animations than I otherwise would, as perfecting them takes longer. CSS3 has a way to denote tra

hg: openjfx/8u-dev/rt: [SCENEBUILDER] Fix issue when deleting Root object

2014-08-29 Thread sandra . lions-piron
Changeset: de7ad70a06f9 Author:slions Date: 2014-08-29 17:35 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/de7ad70a06f9 [SCENEBUILDER] Fix issue when deleting Root object ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/SetDocumen

hg: openjfx/8u-dev/rt: [SCENEBUILDER] FindBugs MS_SHOULD_BE_FINAL

2014-08-29 Thread yves . joan
Changeset: 190eb7e2d1ff Author:yjoan Date: 2014-08-29 17:31 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/190eb7e2d1ff [SCENEBUILDER] FindBugs MS_SHOULD_BE_FINAL ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/util/Deprecation.java

hg: openjfx/8u-dev/rt: [SCENEBUILDER] Fix DTL-6842: Cleanup the code returning URL of CSS files

2014-08-29 Thread yves . joan
Changeset: 4d31c9c55102 Author:yjoan Date: 2014-08-29 16:58 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/4d31c9c55102 [SCENEBUILDER] Fix DTL-6842: Cleanup the code returning URL of CSS files ! apps/scenebuilder/SceneBuilderApp/src/com/oracle/javafx/scenebuilder/app/

TableView column header bug?

2014-08-29 Thread Robert Fisher
Hi guys, it's me again J I found another bug in TableView. I didn't find a JIRA issue for it, so again I want to check if it's known. To reproduce: . Start Java 8 / Modena Ensemble app. . Load TableView control. . Increase the size of one of the columns so they spill

hg: openjfx/8u-dev/rt: [SCENEBUILDER] Fix for DTL-6846 (Dropping an object between two GridPane rows does not reorganize the grid content correctly).

2014-08-29 Thread eric . le . ponner
Changeset: 8a83d139c837 Author:eric.le.pon...@oracle.com Date: 2014-08-29 16:03 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/8a83d139c837 [SCENEBUILDER] Fix for DTL-6846 (Dropping an object between two GridPane rows does not reorganize the grid content correctly). !

hg: openjfx/8u-dev/rt: [SCENEBUILDER] Fix latent bug in row/column jobs by using a LinkedHashSet instead of unsorted HashSet.

2014-08-29 Thread sandra . lions-piron
Changeset: c157e2f9a534 Author:slions Date: 2014-08-29 15:54 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/c157e2f9a534 [SCENEBUILDER] Fix latent bug in row/column jobs by using a LinkedHashSet instead of unsorted HashSet. This should fix the SB unit tests instability

AW: TableView bug?

2014-08-29 Thread Robert Fisher
Ah yep, that looks like it. Cheers, Rob

hg: openjfx/8u-dev/rt: RT-38483: [CSS] add indefinite as a value for duration type

2014-08-29 Thread david . grieve
Changeset: 4c3674e9ab57 Author:David Grieve Date: 2014-08-29 09:37 -0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/4c3674e9ab57 RT-38483: [CSS] add indefinite as a value for duration type ! modules/graphics/src/main/docs/javafx/scene/doc-files/cssref.html ! modules/gra

hg: openjfx/8u-dev/rt: [SCENEBUILDER] FindBugs SBSC_USE_STRINGBUFFER_CONCATENATION

2014-08-29 Thread yves . joan
Changeset: fd2937307d22 Author:yjoan Date: 2014-08-29 15:41 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/fd2937307d22 [SCENEBUILDER] FindBugs SBSC_USE_STRINGBUFFER_CONCATENATION ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/library/Built

Re: TableView bug?

2014-08-29 Thread David Grieve
Possibly https://javafx-jira.kenai.com/browse/RT-38013? On 8/29/14, 8:29 AM, Robert Fisher wrote: Hi guys, I am having some difficulties fine-tuning the style of my TableView and I'm wondering if I've found a bug. It may well be related to an existing JIRA issue, so I thought I'd check her

TableView bug?

2014-08-29 Thread Robert Fisher
Hi guys, I am having some difficulties fine-tuning the style of my TableView and I'm wondering if I've found a bug. It may well be related to an existing JIRA issue, so I thought I'd check here first to see if I should create a new one. http://i.imgur.com/9tGc2FB.png These screenshots are

hg: openjfx/8u-dev/rt: [SCENEBUILDER] FindBugs SBSC_USE_STRINGBUFFER_CONCATENATION

2014-08-29 Thread yves . joan
Changeset: d1505b59555d Author:yjoan Date: 2014-08-29 14:29 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/d1505b59555d [SCENEBUILDER] FindBugs SBSC_USE_STRINGBUFFER_CONCATENATION ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/library/Built

hg: openjfx/8u-dev/rt: RT-37810: [SwingNode]: Swing Nodes have serious rendering artifacts when first displayed on the primary Stage

2014-08-29 Thread anthony . petrov
Changeset: f1184656721a Author:Anthony Petrov Date: 2014-08-29 16:09 +0400 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/f1184656721a RT-37810: [SwingNode]: Swing Nodes have serious rendering artifacts when first displayed on the primary Stage Summary: A partial fix. It el

hg: openjfx/8u-dev/rt: 6 new changesets

2014-08-29 Thread sandra . lions-piron
Changeset: f3731ef0c7f4 Author:slions Date: 2014-08-29 08:57 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/f3731ef0c7f4 [SCENEBUILDER] Going on fixing DTL-6783: Rationalize job implementation between Hierarchy and Content Panels => Adapt Span jobs ! apps/scenebuilde

hg: openjfx/8u-dev/rt: [SCENEBUILDER] Fix DTL-6845: Add a non empty flavor of DialogPane in the Library

2014-08-29 Thread yves . joan
Changeset: a3783295a258 Author:yjoan Date: 2014-08-29 09:48 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/a3783295a258 [SCENEBUILDER] Fix DTL-6845: Add a non empty flavor of DialogPane in the Library ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuil