Compiling 8u20-b26 for iOS
Hi,
I'm trying to compile OpenJFX 8u20-b26 for iOS but run into problems with
the web project. The first problem seems to be with the ios.gradle script.
IIUC (I have very limited experience with Gradle) it disables the
compilation of the ordinary web Java code:
compileJava {
enabled = false
}
and then builds the iOS specific web Java code:
afterEvaluate {
def compileWebJavaIos = task(compileWebJavaIos,
type: JavaCompile, group: Build) {
The problem with this is that the builders project gets built before the
compileWebJavaIos task is run and there is code in builders which depends
on the web classes (e.g. WebViewBuilder depends on WebView) so I get a lot
of unknown symbols Gradle builds the builders project. E.g.:
[ant:javac]
/Users/niklas/Projects/openjfx/modules/builders/src/main/java/javafx/scene/web/WebViewBuilder.java:60:
error: cannot find symbol
[ant:javac] WebView x = new WebView();
[ant:javac] ^
[ant:javac] symbol: class WebView
[ant:javac] location: class WebViewBuilder
I'd like to fix this but before I make a serious attempt I'd like to know
whether I'm doing something wrong. I have Gradle 1.8 installed and I am
building using the 1.8.0_20-b26 JDK. OS X is 10.9.4 and I have the latest
Xcode 5.1 installed. I'm using this command line to build
gradle -PCOMPILE_TARGETS=ios -PUSE_LIPO=true -PIOS_VERSION=7.1
Also, how is the jfxrt.jar that comes with my Java8 installation treated by
the build? I guess it is ignored since otherwise I wouldn't get any
compilation problems due to missing WebView etc since those classes are in
Java8's jfxrt.jar?
Thanks!
/Niklas
Re: Compiling 8u20-b26 for iOS
I’ll let one of the other guys answer about the web component build order, but ... On Sep 1, 2014, at 11:58 PM, Niklas Therning nik...@therning.org wrote: Also, how is the jfxrt.jar that comes with my Java8 installation treated by the build? I guess it is ignored since otherwise I wouldn't get any compilation problems due to missing WebView etc since those classes are in Java8's jfxrt.jar? The jfxrt.jar that comes with the JDK is in the lib/ext directory (as is Nashorn). We simply omit both from the class path when we build by setting java.ext.dirs= (to empty). Richard
Re: Compiling 8u20-b26 for iOS
I'll take a look at the build order, but it sounds like a bug. Perhaps you can just locally disable the builders or add a dependency on the compilation task for the IOS web files. As to your other question, Richard is right that we omit lib/ext from compilation, but there can be issues in doing this (e.g., when running tests or building apps). We recommend that you remove (not just rename) the jfxrt.jar from the JDK you use to build. -- Kevin Richard Bair wrote: I’ll let one of the other guys answer about the web component build order, but ... On Sep 1, 2014, at 11:58 PM, Niklas Therning nik...@therning.org wrote: Also, how is the jfxrt.jar that comes with my Java8 installation treated by the build? I guess it is ignored since otherwise I wouldn't get any compilation problems due to missing WebView etc since those classes are in Java8's jfxrt.jar? The jfxrt.jar that comes with the JDK is in the lib/ext directory (as is Nashorn). We simply omit both from the class path when we build by setting java.ext.dirs= (to empty). Richard
Re: Compiling 8u20-b26 for iOS
I couldn't keep my hands off and by looking at how it's done in
dalvik.gradle from javafxports [1] I managed to get it to build the iOS
web.jar. Here's the patch for ios.gradle:
diff -r e56a8bbcba20 buildSrc/ios.gradle
--- a/buildSrc/ios.gradle Thu Jul 24 21:23:07 2014 -0700
+++ b/buildSrc/ios.gradle Tue Sep 02 16:35:41 2014 +0200
@@ -340,7 +340,17 @@
apply plugin: 'java'
compileJava {
-enabled = false
+sourceSets.main.java.srcDirs = ['src/ios/java'];
+}
+sourceSets {
+main {
+java {
+srcDirs= ['src/ios/java']
+}
+}
+}
+dependencies {
+ compile files(../graphics/build/classes/ios);
}
afterEvaluate {
Let me know if you want me to create a JIRA and post this there instead.
This patch helped me get past the first problem with the builders project
failing. I then had to fix a few compilation problems in the web module's
iOS code. A few classes (PopupFeature and PromptData) were missing and a
few of the others had to be brought up to date with the code in src/main/.
Haven't been able to test the patched web iOS code yet but at least it
compiles now. I should probably create an issue for all of this and attach
a patch, right?
[1]
https://bitbucket.org/javafxports/8u20-rt/src/772ccf341457a1bbabef278cfe4dd6b22f5d7e72/buildSrc/dalvik.gradle?at=default
On Tue, Sep 2, 2014 at 4:34 PM, Kevin Rushforth kevin.rushfo...@oracle.com
wrote:
I'll take a look at the build order, but it sounds like a bug. Perhaps
you can just locally disable the builders or add a dependency on the
compilation task for the IOS web files.
As to your other question, Richard is right that we omit lib/ext from
compilation, but there can be issues in doing this (e.g., when running
tests or building apps). We recommend that you remove (not just rename) the
jfxrt.jar from the JDK you use to build.
-- Kevin
Richard Bair wrote:
I’ll let one of the other guys answer about the web component build order,
but ...
On Sep 1, 2014, at 11:58 PM, Niklas Therning nik...@therning.org
nik...@therning.org wrote:
Also, how is the jfxrt.jar that comes with my Java8 installation treated by
the build? I guess it is ignored since otherwise I wouldn't get any
compilation problems due to missing WebView etc since those classes are in
Java8's jfxrt.jar?
The jfxrt.jar that comes with the JDK is in the lib/ext directory (as is
Nashorn). We simply omit both from the class path when we build by setting
java.ext.dirs= (to empty).
Richard
Re: Compiling 8u20-b26 for iOS
I should probably create an issue for all of this and attach a patch,
right?
Yes, please. We can get the patch into 8u-dev.
-- Kevin
Niklas Therning wrote:
I couldn't keep my hands off and by looking at how it's done in
dalvik.gradle from javafxports [1] I managed to get it to build the
iOS web.jar. Here's the patch for ios.gradle:
diff -r e56a8bbcba20 buildSrc/ios.gradle
--- a/buildSrc/ios.gradle Thu Jul 24 21:23:07 2014 -0700
+++ b/buildSrc/ios.gradle Tue Sep 02 16:35:41 2014 +0200
@@ -340,7 +340,17 @@
apply plugin: 'java'
compileJava {
-enabled = false
+sourceSets.main.java.srcDirs = ['src/ios/java'];
+}
+sourceSets {
+main {
+java {
+srcDirs= ['src/ios/java']
+}
+}
+}
+dependencies {
+ compile files(../graphics/build/classes/ios);
}
afterEvaluate {
Let me know if you want me to create a JIRA and post this there
instead. This patch helped me get past the first problem with the
builders project failing. I then had to fix a few compilation problems
in the web module's iOS code. A few classes (PopupFeature and
PromptData) were missing and a few of the others had to be brought up
to date with the code in src/main/. Haven't been able to test the
patched web iOS code yet but at least it compiles now. I should
probably create an issue for all of this and attach a patch, right?
[1]
https://bitbucket.org/javafxports/8u20-rt/src/772ccf341457a1bbabef278cfe4dd6b22f5d7e72/buildSrc/dalvik.gradle?at=default
On Tue, Sep 2, 2014 at 4:34 PM, Kevin Rushforth
kevin.rushfo...@oracle.com mailto:kevin.rushfo...@oracle.com wrote:
I'll take a look at the build order, but it sounds like a bug.
Perhaps you can just locally disable the builders or add a
dependency on the compilation task for the IOS web files.
As to your other question, Richard is right that we omit lib/ext
from compilation, but there can be issues in doing this (e.g.,
when running tests or building apps). We recommend that you remove
(not just rename) the jfxrt.jar from the JDK you use to build.
-- Kevin
Richard Bair wrote:
I’ll let one of the other guys answer about the web component build order,
but ...
On Sep 1, 2014, at 11:58 PM, Niklas Therning nik...@therning.org
mailto:nik...@therning.org wrote:
Also, how is the jfxrt.jar that comes with my Java8 installation treated by
the build? I guess it is ignored since otherwise I wouldn't get any
compilation problems due to missing WebView etc since those classes are in
Java8's jfxrt.jar?
The jfxrt.jar that comes with the JDK is in the lib/ext directory (as is
Nashorn). We simply omit both from the class path when we build by setting
java.ext.dirs= (to empty).
Richard
Tabs placement on a TabPane
Hi all, I'm trying again since no one answered the last time I asked this. Is there any way of placing tabs on a TabPane starting from the left AND from the right? Thanks Pedro Serra
Re: hg: openjfx/8u-dev/rt: 3 new changesets
Sandra, We are frozen for sanity testing [1] so this changeset should not have been pushed. Since it only affects SceneBuilder code which isn't shipped with the FX build, we don't need to back this out, but please be aware of the lockout period (usually Monday, but is on Tuesday this week) in the future. Thanks. -- Kevin [1] https://www.mail-archive.com/openjfx-dev@openjdk.java.net/msg07594.html sandra.lions-pi...@oracle.com wrote: Changeset: 4ecd15e8a082 Author:slions Date: 2014-09-01 09:18 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/4ecd15e8a082 [SCENEBUILDER] Going on fixing DTL-6783: Rationalize job implementation between Hierarchy and Content Panels = Adapt Insert and Move GridPane Row/Column jobs ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/gridpane/v2/InsertColumnJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/gridpane/v2/InsertRowJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/gridpane/v2/MoveColumnContentJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/gridpane/v2/MoveRowContentJob.java Changeset: 60e8da40fca3 Author:slions Date: 2014-09-01 09:19 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/60e8da40fca3 [SCENEBUILDER] Going on fixing DTL-6783: Rationalize job implementation between Hierarchy and Content Panels = Adapt DebugMenu controller jobs ! apps/scenebuilder/SceneBuilderApp/src/com/oracle/javafx/scenebuilder/app/menubar/DebugMenuController.java Changeset: 8fa9c7b3b5c8 Author:slions Date: 2014-09-01 09:42 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/8fa9c7b3b5c8 [SCENEBUILDER] Going on fixing DTL-6783: Rationalize job implementation between Hierarchy and Content Panels = Move jobs that do not define a list of other jobs in the new xxx.job.atomic package ! apps/scenebuilder/SceneBuilderApp/src/com/oracle/javafx/scenebuilder/app/info/InfoPanelController.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/EditorController.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/drag/DragController.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/drag/target/AccessoryDropTarget.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/drag/target/ContainerXYDropTarget.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/drag/target/ContainerZDropTarget.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/drag/target/GridPaneDropTarget.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/drag/target/ImageViewDropTarget.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/BringForwardJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/BringToFrontJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/DeleteObjectJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/DuplicateSelectionJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/FitToParentObjectJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/InsertAsAccessoryJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/InsertAsSubComponentJob.java - apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/ModifyFxControllerJob.java - apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/ModifyFxIdJob.java - apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/ModifyObjectJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/ModifySelectionJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/PasteJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/PrunePropertiesJob.java - apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/ReIndexObjectJob.java - apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/RelocateNodeJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/RelocateSelectionJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/SendBackwardJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/SendToBackJob.java -
Re: hg: openjfx/8u-dev/rt: 3 new changesets
Never mind. I misread the time stamp on the changeset. Sorry about that! -- Kevin Kevin Rushforth wrote: Sandra, We are frozen for sanity testing [1] so this changeset should not have been pushed. Since it only affects SceneBuilder code which isn't shipped with the FX build, we don't need to back this out, but please be aware of the lockout period (usually Monday, but is on Tuesday this week) in the future. Thanks. -- Kevin [1] https://www.mail-archive.com/openjfx-dev@openjdk.java.net/msg07594.html sandra.lions-pi...@oracle.com wrote: Changeset: 4ecd15e8a082 Author:slions Date: 2014-09-01 09:18 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/4ecd15e8a082 [SCENEBUILDER] Going on fixing DTL-6783: Rationalize job implementation between Hierarchy and Content Panels = Adapt Insert and Move GridPane Row/Column jobs ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/gridpane/v2/InsertColumnJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/gridpane/v2/InsertRowJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/gridpane/v2/MoveColumnContentJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/gridpane/v2/MoveRowContentJob.java Changeset: 60e8da40fca3 Author:slions Date: 2014-09-01 09:19 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/60e8da40fca3 [SCENEBUILDER] Going on fixing DTL-6783: Rationalize job implementation between Hierarchy and Content Panels = Adapt DebugMenu controller jobs ! apps/scenebuilder/SceneBuilderApp/src/com/oracle/javafx/scenebuilder/app/menubar/DebugMenuController.java Changeset: 8fa9c7b3b5c8 Author:slions Date: 2014-09-01 09:42 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/8fa9c7b3b5c8 [SCENEBUILDER] Going on fixing DTL-6783: Rationalize job implementation between Hierarchy and Content Panels = Move jobs that do not define a list of other jobs in the new xxx.job.atomic package ! apps/scenebuilder/SceneBuilderApp/src/com/oracle/javafx/scenebuilder/app/info/InfoPanelController.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/EditorController.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/drag/DragController.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/drag/target/AccessoryDropTarget.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/drag/target/ContainerXYDropTarget.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/drag/target/ContainerZDropTarget.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/drag/target/GridPaneDropTarget.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/drag/target/ImageViewDropTarget.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/BringForwardJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/BringToFrontJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/DeleteObjectJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/DuplicateSelectionJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/FitToParentObjectJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/InsertAsAccessoryJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/InsertAsSubComponentJob.java - apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/ModifyFxControllerJob.java - apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/ModifyFxIdJob.java - apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/ModifyObjectJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/ModifySelectionJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/PasteJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/PrunePropertiesJob.java - apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/ReIndexObjectJob.java - apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/RelocateNodeJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/RelocateSelectionJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/SendBackwardJob.java !
Re: outstanding resource locks
Any time you see this message, it isn't your fault. Rather this is a bug in the JavaFX runtime. Please file a JIRA. -- Kevin Mario Ivankovits wrote: Hi! Is there anything further I can do to see which resources are locked so I can see if this is my fault and to release them properly? How to interpret this output? Thanks for any info. Outstanding resource locks detected: ES2 Vram Pool: 76.571.592 used (28,5%), 76.571.592 managed (28,5%), 268.435.456 total 118 total resources being managed average resource age is 540,5 frames 57 resources at maximum supported age (48,3%) 6 resources marked permanent (5,1%) 2 resources have had mismatched locks (1,7%) 2 resources locked (1,7%) 79 resources contain interesting data (66,9%) 0 resources disappeared (0,0%) Outstanding resource locks detected: ES2 Vram Pool: 141.193.956 used (52,6%), 141.193.956 managed (52,6%), 268.435.456 total 136 total resources being managed average resource age is 467,8 frames 57 resources at maximum supported age (41,9%) 6 resources marked permanent (4,4%) 5 resources have had mismatched locks (3,7%) 5 resources locked (3,7%) 82 resources contain interesting data (60,3%) 0 resources disappeared (0,0%) Best regards, Mario
Re: outstanding resource locks
I see this message quite frequently. What sort of things do you need in these bug reports? On Tue, Sep 2, 2014 at 5:38 PM, Kevin Rushforth kevin.rushfo...@oracle.com wrote: Any time you see this message, it isn't your fault. Rather this is a bug in the JavaFX runtime. Please file a JIRA. -- Kevin Mario Ivankovits wrote: Hi! Is there anything further I can do to see which resources are locked so I can see if this is my fault and to release them properly? How to interpret this output? Thanks for any info. Outstanding resource locks detected: ES2 Vram Pool: 76.571.592 used (28,5%), 76.571.592 managed (28,5%), 268.435.456 total 118 total resources being managed average resource age is 540,5 frames 57 resources at maximum supported age (48,3%) 6 resources marked permanent (5,1%) 2 resources have had mismatched locks (1,7%) 2 resources locked (1,7%) 79 resources contain interesting data (66,9%) 0 resources disappeared (0,0%) Outstanding resource locks detected: ES2 Vram Pool: 141.193.956 used (52,6%), 141.193.956 managed (52,6%), 268.435.456 total 136 total resources being managed average resource age is 467,8 frames 57 resources at maximum supported age (41,9%) 6 resources marked permanent (4,4%) 5 resources have had mismatched locks (3,7%) 5 resources locked (3,7%) 82 resources contain interesting data (60,3%) 0 resources disappeared (0,0%) Best regards, Mario
hg: openjfx/8u-dev/rt: RT-38511: [Canvas] Several tests get IllegalStateException: Operation requires resource lock
Changeset: b4976c12c98b Author:kcr Date: 2014-09-02 09:12 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/b4976c12c98b RT-38511: [Canvas] Several tests get IllegalStateException: Operation requires resource lock Backed out changeset 1777099fe570 for RT-38183 ! modules/graphics/src/main/java/com/sun/javafx/sg/prism/NGNode.java ! modules/graphics/src/main/java/com/sun/scenario/effect/impl/ImagePool.java - modules/graphics/src/main/java/com/sun/scenario/effect/impl/PoolFilterable.java ! modules/graphics/src/main/java/com/sun/scenario/effect/impl/Renderer.java ! modules/graphics/src/main/java/com/sun/scenario/effect/impl/prism/PrDrawable.java
Re: outstanding resource locks
Ideally we need a reproducible test case with a set of instructions to demonstrate the bug. I know this can be a challenge for an intermittent bug. -- Kevin Mike Hearn wrote: I see this message quite frequently. What sort of things do you need in these bug reports? On Tue, Sep 2, 2014 at 5:38 PM, Kevin Rushforth kevin.rushfo...@oracle.com mailto:kevin.rushfo...@oracle.com wrote: Any time you see this message, it isn't your fault. Rather this is a bug in the JavaFX runtime. Please file a JIRA. -- Kevin Mario Ivankovits wrote: Hi! Is there anything further I can do to see which resources are locked so I can see if this is my fault and to release them properly? How to interpret this output? Thanks for any info. Outstanding resource locks detected: ES2 Vram Pool: 76.571.592 used (28,5%), 76.571.592 managed (28,5%), 268.435.456 total 118 total resources being managed average resource age is 540,5 frames 57 resources at maximum supported age (48,3%) 6 resources marked permanent (5,1%) 2 resources have had mismatched locks (1,7%) 2 resources locked (1,7%) 79 resources contain interesting data (66,9%) 0 resources disappeared (0,0%) Outstanding resource locks detected: ES2 Vram Pool: 141.193.956 used (52,6%), 141.193.956 managed (52,6%), 268.435.456 total 136 total resources being managed average resource age is 467,8 frames 57 resources at maximum supported age (41,9%) 6 resources marked permanent (4,4%) 5 resources have had mismatched locks (3,7%) 5 resources locked (3,7%) 82 resources contain interesting data (60,3%) 0 resources disappeared (0,0%) Best regards, Mario
Re: outstanding resource locks
OK. What is the impact of the bugs? I haven't noticed any obvious problems when it occurs. Sounds like a GPU resource leak of some kind? On Tue, Sep 2, 2014 at 6:24 PM, Kevin Rushforth kevin.rushfo...@oracle.com wrote: Ideally we need a reproducible test case with a set of instructions to demonstrate the bug. I know this can be a challenge for an intermittent bug. -- Kevin Mike Hearn wrote: I see this message quite frequently. What sort of things do you need in these bug reports? On Tue, Sep 2, 2014 at 5:38 PM, Kevin Rushforth kevin.rushfo...@oracle.com wrote: Any time you see this message, it isn't your fault. Rather this is a bug in the JavaFX runtime. Please file a JIRA. -- Kevin Mario Ivankovits wrote: Hi! Is there anything further I can do to see which resources are locked so I can see if this is my fault and to release them properly? How to interpret this output? Thanks for any info. Outstanding resource locks detected: ES2 Vram Pool: 76.571.592 used (28,5%), 76.571.592 managed (28,5%), 268.435.456 total 118 total resources being managed average resource age is 540,5 frames 57 resources at maximum supported age (48,3%) 6 resources marked permanent (5,1%) 2 resources have had mismatched locks (1,7%) 2 resources locked (1,7%) 79 resources contain interesting data (66,9%) 0 resources disappeared (0,0%) Outstanding resource locks detected: ES2 Vram Pool: 141.193.956 used (52,6%), 141.193.956 managed (52,6%), 268.435.456 total 136 total resources being managed average resource age is 467,8 frames 57 resources at maximum supported age (41,9%) 6 resources marked permanent (4,4%) 5 resources have had mismatched locks (3,7%) 5 resources locked (3,7%) 82 resources contain interesting data (60,3%) 0 resources disappeared (0,0%) Best regards, Mario
Re: outstanding resource locks
Jim can provide a more detailed answer, but in general, yes it would indicate a (likely small) resource leak. The interesting part being: 2 resources locked (1,7%) and later 5 resources locked (3,7%) -- Kevin Mike Hearn wrote: OK. What is the impact of the bugs? I haven't noticed any obvious problems when it occurs. Sounds like a GPU resource leak of some kind? On Tue, Sep 2, 2014 at 6:24 PM, Kevin Rushforth kevin.rushfo...@oracle.com mailto:kevin.rushfo...@oracle.com wrote: Ideally we need a reproducible test case with a set of instructions to demonstrate the bug. I know this can be a challenge for an intermittent bug. -- Kevin Mike Hearn wrote: I see this message quite frequently. What sort of things do you need in these bug reports? On Tue, Sep 2, 2014 at 5:38 PM, Kevin Rushforth kevin.rushfo...@oracle.com mailto:kevin.rushfo...@oracle.com wrote: Any time you see this message, it isn't your fault. Rather this is a bug in the JavaFX runtime. Please file a JIRA. -- Kevin Mario Ivankovits wrote: Hi! Is there anything further I can do to see which resources are locked so I can see if this is my fault and to release them properly? How to interpret this output? Thanks for any info. Outstanding resource locks detected: ES2 Vram Pool: 76.571.592 used (28,5%), 76.571.592 managed (28,5%), 268.435.456 total 118 total resources being managed average resource age is 540,5 frames 57 resources at maximum supported age (48,3%) 6 resources marked permanent (5,1%) 2 resources have had mismatched locks (1,7%) 2 resources locked (1,7%) 79 resources contain interesting data (66,9%) 0 resources disappeared (0,0%) Outstanding resource locks detected: ES2 Vram Pool: 141.193.956 used (52,6%), 141.193.956 managed (52,6%), 268.435.456 total 136 total resources being managed average resource age is 467,8 frames 57 resources at maximum supported age (41,9%) 6 resources marked permanent (4,4%) 5 resources have had mismatched locks (3,7%) 5 resources locked (3,7%) 82 resources contain interesting data (60,3%) 0 resources disappeared (0,0%) Best regards, Mario
8u-dev unlocked following this week's sanity testing eom
hg: openjfx/8u-dev/rt: 6 new changesets
Changeset: 64c45eaad799 Author:eric.le.ponner eric.le.pon...@oracle.com Date: 2014-09-02 12:53 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/64c45eaad799 [SCENEBUILDER] added FXOMObject.collectReferences() method (with 'scope' parameter). ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMCollection.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMInstance.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMIntrinsic.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMObject.java Changeset: b798513fd328 Author:eric.le.ponner eric.le.pon...@oracle.com Date: 2014-09-02 12:56 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/b798513fd328 [SCENEBUILDER] AbstractDropTarget subclasses and edit jobs now uses RemoveObjectJob in place of DeleteObjectJob. DeleteObjectJob semantic is going to change and it will be reserved to delete command only. ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/drag/target/AccessoryDropTarget.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/drag/target/ContainerXYDropTarget.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/drag/target/ContainerZDropTarget.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/drag/target/GridPaneDropTarget.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/TrimSelectionJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/gridpane/MoveColumnJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/gridpane/MoveRowJob.java Changeset: 92121f1d5ae1 Author:eric.le.ponner eric.le.pon...@oracle.com Date: 2014-09-02 13:02 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/92121f1d5ae1 [SCENEBUILDER] Second step for DTL-6774 implementation. Delete command is now reference aware: - DeleteObjectJob now relies on ObjectDeleter - DeleteObjectSelection no longer needs to invoke AdjustAllToggleGroupsJob ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/DeleteObjectJob.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/DeleteObjectSelectionJob.java + apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/editor/job/reference/ObjectDeleter.java Changeset: a0da8fd3717c Author:eric.le.ponner eric.le.pon...@oracle.com Date: 2014-09-02 13:04 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/a0da8fd3717c [SCENEBUILDER] Debug menu now displays sub jobs attached to UpdateReferencesJob. ! apps/scenebuilder/SceneBuilderApp/src/com/oracle/javafx/scenebuilder/app/menubar/DebugMenuController.java Changeset: 1e20da46a3c7 Author:eric.le.pon...@oracle.com Date: 2014-09-02 14:19 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/1e20da46a3c7 [SCENEBUILDER] Removed FXOMObject.lookupFirstReference() (no longer used). ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMCollection.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMInstance.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMIntrinsic.java ! apps/scenebuilder/SceneBuilderKit/src/com/oracle/javafx/scenebuilder/kit/fxom/FXOMObject.java Changeset: 043cd5a12fd9 Author:eric.le.pon...@oracle.com Date: 2014-09-02 20:05 +0200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/043cd5a12fd9 [SCENEBUILDER] merge (no conflict).
hg: openjfx/8u-dev/rt: [Accessibility] Reduce method/field visibility
Changeset: f98785bfc2f9 Author:Felipe Heidrich felipe.heidr...@oracle.com Date: 2014-09-02 11:20 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/f98785bfc2f9 [Accessibility] Reduce method/field visibility ! modules/graphics/src/main/java/com/sun/glass/ui/Accessible.java ! modules/graphics/src/main/java/com/sun/glass/ui/mac/MacAccessible.java ! modules/graphics/src/main/java/com/sun/glass/ui/mac/MacVariant.java
Re: outstanding resource locks
Originally it would complain about the resources being locked on every frame since they remained locked. More recently we installed a report and forgive mechanism that reports that the locks were outstanding (because that is a bug), but then it conditionally can either mark the resource as untrackable or it simply unlocks all of the locks. Either way, you should now only see the messages once since we either fix the problem or we mark it so that we don't complain on the next frame. We use the unlock all the locks part of the mechanism if the render loop fielded an Exception from the rendering code. When an exception happens then it is very probably that some resources were left locked. Arguably though the code really should be doing try/finally around the locks to prevent locks even in the case of an exception, but it is very hard to do that in some cases given the chain of events that happens between the lock and unlock. We use the just mark it and stop complaining but leave it locked part of the mechanism if there was no exception. It represents an unbalanced lock/unlock in the code or it may represent some code that wants to have a resource locked across multiple frames on purpose without registering it as such. If that code had a plan to eventually unlock the texture then there really is no leak, but it should have registered the resource as being locked long term and it didn't. If this a case of an unbalanced lock/unlock in our code, then the resource could very well leak, but eventually garbage collection may step in and reclaim the resource non-aggressively as well... ...jim On 9/2/14 9:45 AM, Kevin Rushforth wrote: Jim can provide a more detailed answer, but in general, yes it would indicate a (likely small) resource leak. The interesting part being: 2 resources locked (1,7%) and later 5 resources locked (3,7%) -- Kevin Mike Hearn wrote: OK. What is the impact of the bugs? I haven't noticed any obvious problems when it occurs. Sounds like a GPU resource leak of some kind? On Tue, Sep 2, 2014 at 6:24 PM, Kevin Rushforth kevin.rushfo...@oracle.com mailto:kevin.rushfo...@oracle.com wrote: Ideally we need a reproducible test case with a set of instructions to demonstrate the bug. I know this can be a challenge for an intermittent bug. -- Kevin Mike Hearn wrote: I see this message quite frequently. What sort of things do you need in these bug reports? On Tue, Sep 2, 2014 at 5:38 PM, Kevin Rushforth kevin.rushfo...@oracle.com mailto:kevin.rushfo...@oracle.com wrote: Any time you see this message, it isn't your fault. Rather this is a bug in the JavaFX runtime. Please file a JIRA. -- Kevin Mario Ivankovits wrote: Hi! Is there anything further I can do to see which resources are locked so I can see if this is my fault and to release them properly? How to interpret this output? Thanks for any info. Outstanding resource locks detected: ES2 Vram Pool: 76.571.592 used (28,5%), 76.571.592 managed (28,5%), 268.435.456 total 118 total resources being managed average resource age is 540,5 frames 57 resources at maximum supported age (48,3%) 6 resources marked permanent (5,1%) 2 resources have had mismatched locks (1,7%) 2 resources locked (1,7%) 79 resources contain interesting data (66,9%) 0 resources disappeared (0,0%) Outstanding resource locks detected: ES2 Vram Pool: 141.193.956 used (52,6%), 141.193.956 managed (52,6%), 268.435.456 total 136 total resources being managed average resource age is 467,8 frames 57 resources at maximum supported age (41,9%) 6 resources marked permanent (4,4%) 5 resources have had mismatched locks (3,7%) 5 resources locked (3,7%) 82 resources contain interesting data (60,3%) 0 resources disappeared (0,0%) Best regards, Mario
hg: openjfx/8u-dev/rt: [Accessibility] Reduce method/field visibility
Changeset: 397bbdd03f90 Author:Felipe Heidrich felipe.heidr...@oracle.com Date: 2014-09-02 13:24 -0700 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/397bbdd03f90 [Accessibility] Reduce method/field visibility ! modules/graphics/src/main/java/com/sun/glass/ui/win/WinAccessible.java ! modules/graphics/src/main/java/com/sun/glass/ui/win/WinTextRangeProvider.java ! modules/graphics/src/main/java/com/sun/glass/ui/win/WinVariant.java
Re: 8u40 review request: RT-38183 - ManagedResource warnings when switching screen configurations
A new version of this fix was just posted for review after the sanity testing failures from this morning... ...jim On 8/27/14 7:21 PM, Jim Graham wrote: webrev: http://cr.openjdk.java.net/~flar/RT-38183/webrev.00/ Jira: https://javafx-jira.kenai.com/browse/RT-38183 Short and long explanations of the fix are in the Jira comments... ...jim
hg: openjfx/8u-dev/rt: 2 new changesets
Changeset: e118f2891b38 Author:jgiles Date: 2014-09-02 15:32 +1200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/e118f2891b38 [DOC ONLY] fix typos in ButtonType javadoc ! modules/controls/src/main/java/javafx/scene/control/ButtonType.java Changeset: 258d08a27dc0 Author:jgiles Date: 2014-09-03 12:12 +1200 URL: http://hg.openjdk.java.net/openjfx/8u-dev/rt/rev/258d08a27dc0 RT-38464: [TableView] Regression TableView: cannot start editing via keyboard ! apps/toys/Hello/src/main/java/hello/HelloTableView.java ! modules/controls/src/main/java/com/sun/javafx/scene/control/SelectedCellsMap.java ! modules/controls/src/main/java/com/sun/javafx/scene/control/behavior/TableCellBehaviorBase.java ! modules/controls/src/main/java/javafx/scene/control/ListCell.java ! modules/controls/src/main/java/javafx/scene/control/ListView.java ! modules/controls/src/main/java/javafx/scene/control/MultipleSelectionModelBase.java ! modules/controls/src/main/java/javafx/scene/control/TableCell.java ! modules/controls/src/main/java/javafx/scene/control/TableView.java ! modules/controls/src/main/java/javafx/scene/control/TreeCell.java ! modules/controls/src/main/java/javafx/scene/control/TreeTableCell.java ! modules/controls/src/main/java/javafx/scene/control/TreeTableView.java ! modules/controls/src/main/java/javafx/scene/control/TreeView.java ! modules/controls/src/test/java/com/sun/javafx/scene/control/infrastructure/VirtualFlowTestUtils.java ! modules/controls/src/test/java/javafx/scene/control/ListCellTest.java ! modules/controls/src/test/java/javafx/scene/control/ListViewTest.java ! modules/controls/src/test/java/javafx/scene/control/MultipleSelectionModelImplTest.java ! modules/controls/src/test/java/javafx/scene/control/SelectionModelImplTest.java ! modules/controls/src/test/java/javafx/scene/control/TableViewKeyInputTest.java ! modules/controls/src/test/java/javafx/scene/control/TableViewMouseInputTest.java ! modules/controls/src/test/java/javafx/scene/control/TableViewSelectionModelImplTest.java ! modules/controls/src/test/java/javafx/scene/control/TableViewTest.java ! modules/controls/src/test/java/javafx/scene/control/TreeTableViewKeyInputTest.java ! modules/controls/src/test/java/javafx/scene/control/TreeTableViewMouseInputTest.java ! modules/controls/src/test/java/javafx/scene/control/TreeTableViewSelectionModelImplTest.java ! modules/controls/src/test/java/javafx/scene/control/TreeTableViewTest.java ! modules/controls/src/test/java/javafx/scene/control/TreeViewTest.java
Re: Tabs placement on a TabPane
Pedro, At present there is no API that supports this, and no plans to add API to support this. If this is something you would like to see, the first step is to file a feature request in our jira issue tracker here: http://javafx-jira.kenai.org Thanks, -- Jonathan On 3/09/2014 2:44 a.m., Pedro Serra wrote: Hi all, I'm trying again since no one answered the last time I asked this. Is there any way of placing tabs on a TabPane starting from the left AND from the right? Thanks Pedro Serra
Re: TableView column header bug?
A quick Jira search for 'column alignment' turned up https://javafx-jira.kenai.com/browse/RT-37553 as the third result, which sounds like your problem. So yes, this is a known problem. In future feel free to file bugs directly in Jira - there is no harm in doing so and there is no need to check on this list first. -- Jonathan On 30/08/2014 2:39 a.m., Robert Fisher wrote: Hi guys, it's me again J I found another bug in TableView. I didn't find a JIRA issue for it, so again I want to check if it's known. To reproduce: . Start Java 8 / Modena Ensemble app. . Load TableView control. . Increase the size of one of the columns so they spill outside the available space and a scrollbar appears. . Scroll all the way to the right. . Maximize the ensemble app to full screen. . Observe that the column header positions are out of sync with the columns, like so: http://i.imgur.com/IadhcwO.png Known bug? Cheers, Rob
