[8u40] Review request for RT-38855: DoubleProperty.doubleProperty() Javadoc needs small fix

2014-10-03 Thread Vadim Pakhnushev
Hi Kevin, Please review this simple javadoc fix: https://javafx-jira.kenai.com/browse/RT-38855 http://cr.openjdk.java.net/~vadim/RT-38855/webrev.00/ Thanks, Vadim

Re: How do I find out why the render loop is running?

2014-10-03 Thread Mike Hearn
Well, this was a pain in the ass. The cause is indeed ProgressBar/ProgressIndicator. It turns out that they can leak animations even when removed from the scene graph or their parents are made invisible. I filed: https://javafx-jira.kenai.com/browse/RT-38894 I now have a bunch of hacks to set

Re: How do I find out why the render loop is running?

2014-10-03 Thread Tomas Mikula
This is just a tip: until the bug is fixed, you can use a subclass of ProgressBar like the one below to avoid a bunch of hacks. class MyProgressBar extends ProgressBar { private final DoubleProperty myProgress = new SimpleDoubleProperty(); public DoubleProperty myProgressProperty() {

Re: How do I find out why the render loop is running?

2014-10-03 Thread Kevin Rushforth
Can you add this workaround to the JIRA? Thanks. -- Kevin Tomas Mikula wrote: This is just a tip: until the bug is fixed, you can use a subclass of ProgressBar like the one below to avoid a bunch of hacks. class MyProgressBar extends ProgressBar { private final DoubleProperty myProgress

Re: How do I find out why the render loop is running?

2014-10-03 Thread Tomas Mikula
Okay :) So you are using opacityProperty() and not visibleProperty(), so my exact workaround would not work anyway. A nice thing about that kind of workaround though is that you would have the workaround in one place and once you remove it, the compiler points you to all other places you need to

Re: How do I find out why the render loop is running?

2014-10-03 Thread Mike Hearn
So you are using opacityProperty() and not visibleProperty(), so my exact workaround would not work anyway. I did originally put some code into animatedBind to set visible == false when opacity == 0.0 and vice versa, but it didn't seem to solve the animation leak so I took it out again. BTW

Re: How do I find out why the render loop is running?

2014-10-03 Thread Tomas Mikula
BTW animatedBind is a useful utility. It makes it much easier to make cool animations that adjust as the data model changes. Here it is: https://gist.github.com/mikehearn/f639176566d735b676e7 Something like that should be in the framework really. Nice indeed.