switching skins at runtime

2014-12-23 Thread Tom Eugelink 

Is it allowed / supported to execute setSkin with a new skin on a control that 
is part of a scene?

Tom

Re: switching skins at runtime

2014-12-23 Thread David Grieve 
Yes, it is allowed. But know that there is some code in setSkin that 
prevents setting a skin that is either instance equal or the same class.


On 12/23/14, 6:27 AM, Tom Eugelink wrote:
Is it allowed / supported to execute setSkin with a new skin on a 
control that is part of a scene?


Tom

Re: switching skins at runtime

2014-12-23 Thread Tom Eugelink 

Then this NPE on getSkinnable() when switching Agenda's skin when the control 
is already shown (instead of when created) must be my doing some how. Thanks!

Tom


On 23-12-2014 14:36, David Grieve wrote:

Yes, it is allowed. But know that there is some code in setSkin that prevents 
setting a skin that is either instance equal or the same class.

On 12/23/14, 6:27 AM, Tom Eugelink wrote:

Is it allowed / supported to execute setSkin with a new skin on a control that 
is part of a scene?

Tom

Re: SplitPane layout question

2014-12-23 Thread David Gilbert 
Maybe related to this bug:

https://javafx-jira.kenai.com/browse/RT-38851

Best regards,

David Gilbert
http://www.jfree.org/

On 22 Dec 2014, at 13:19, Scott Palmer swpal...@gmail.com wrote:

 The min/max sizes of the children are probably being respected.
 
 Scott
 
 On Dec 22, 2014, at 7:13 AM, Florian Brunner fbrunnerl...@gmx.ch wrote:
 
 Hi, 
 
 Sometimes when I'm setting the divider positions of a SplitPane 
 programmatically my value get overridden again by some JavaFX internal 
 layout 
 code.
 
 For debugging purposes I've added a listener to the position property of the 
 divider and have thrown a RuntimeException to see the stack trace. It looks 
 like this:
 
 --
 at 
 com.sun.javafx.binding.ExpressionHelper$Generic.fireValueChangedEvent(ExpressionHelper.java:361)
   at 
 com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:81)
   at 
 javafx.beans.property.DoublePropertyBase.fireValueChangedEvent(DoublePropertyBase.java:106)
   at 
 javafx.beans.property.DoublePropertyBase.markInvalid(DoublePropertyBase.java:113)
   at 
 javafx.beans.property.DoublePropertyBase.set(DoublePropertyBase.java:146)
   at javafx.scene.control.SplitPane$Divider.setPosition(SplitPane.java:486)
   at 
 com.sun.javafx.scene.control.skin.SplitPaneSkin.setAbsoluteDividerPos(SplitPaneSkin.java:310)
   at 
 com.sun.javafx.scene.control.skin.SplitPaneSkin.setupContentAndDividerForLayout(SplitPaneSkin.java:502)
   at 
 com.sun.javafx.scene.control.skin.SplitPaneSkin.layoutChildren(SplitPaneSkin.java:817)
   at javafx.scene.control.Control.layoutChildren(Control.java:589)
   at javafx.scene.Parent.layout(Parent.java:1074)
   at javafx.scene.Parent.layout(Parent.java:1080)
   at javafx.scene.Parent.layout(Parent.java:1080)
   at javafx.scene.Parent.layout(Parent.java:1080)
   at javafx.scene.Parent.layout(Parent.java:1080)
   at javafx.scene.Parent.layout(Parent.java:1080)
   at javafx.scene.Parent.layout(Parent.java:1080)
   at javafx.scene.Parent.layout(Parent.java:1080)
   at javafx.scene.Parent.layout(Parent.java:1080)
   at javafx.scene.Scene.doLayoutPass(Scene.java:532)
   at javafx.scene.Scene$ScenePulseListener.pulse(Scene.java:2363)
   at com.sun.javafx.tk.Toolkit.lambda$runPulse$28(Toolkit.java:314)
   at com.sun.javafx.tk.Toolkit$$Lambda$230/25595560.run(Unknown Source)
   at java.security.AccessController.doPrivileged(Native Method)
   at com.sun.javafx.tk.Toolkit.runPulse(Toolkit.java:313)
   at com.sun.javafx.tk.Toolkit.firePulse(Toolkit.java:340)
   at com.sun.javafx.tk.quantum.QuantumToolkit.pulse(QuantumToolkit.java:451)
   at com.sun.javafx.tk.quantum.QuantumToolkit.pulse(QuantumToolkit.java:431)
   at 
 com.sun.javafx.tk.quantum.QuantumToolkit.lambda$runToolkit$363(QuantumToolkit.java:298)
   at 
 com.sun.javafx.tk.quantum.QuantumToolkit$$Lambda$59/174792896.run(Unknown 
 Source)
   at 
 com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:95)
   at com.sun.glass.ui.gtk.GtkApplication._runLoop(Native Method)
   at 
 com.sun.glass.ui.gtk.GtkApplication.lambda$null$45(GtkApplication.java:126)
   at com.sun.glass.ui.gtk.GtkApplication$$Lambda$55/1472148546.run(Unknown 
 Source)
   at java.lang.Thread.run(Thread.java:745)
 --
 
 It doesn't seem to get triggered by some code of mine (at least not directly 
 according to the stack trace).
 
 Why is this re-layout happing here?
 Why does it override the values I've set for the divider positions?
 How can stop this?
 
 Thanks for some insights.
 
 -Florian

[8u40] review request: RT-39733 - Packaging with a JRE as installed fails codesign on OSX 10.9.5 or 10.10

2014-12-23 Thread Danno Ferrin 
Kevin, David, please review

JIRA: https://javafx-jira.kenai.com/browse/RT-39733
Webrev: http://cr.openjdk.java.net/~shemnon/RT-39733/webrev.00/

Current Webrev is against 8u-dev , I'll get one against 8u40 soonish.