Re: Behavior of TitledPane concerning the ENTER key and focus

2015-03-19 Thread Jonathan Giles
Hi Christoph, It would be best to repost this into the jira issue (RT-40166), so that all context is recorded there. If you do that we can carry on the discussion. In general, I agree with you - we should consider removing the ENTER key binding, so this should be considered further. -- Jonat

Code Review Request For RT-37862: [ScenePulseListener] NPE in synchronizeSceneProperties

2015-03-19 Thread Chien Yang
Hi Kevin, Please review the proposed fix. JIRA: https://javafx-jira.kenai.com/browse/RT-37862 Thanks, - Chien

[8u] Review request: RT-40280 Refactor duplicated editor code in ComboBox and DatePicker skins.

2015-03-19 Thread Leif Samuelsson
Hi Jonathan, Please review this fix involving skins based on ComboBoListViewSkin. https://javafx-jira.kenai.com/browse/RT-40280 http://cr.openjdk.java.net/~leifs/rt40280/webrev.01/ Thanks, Leif

Behavior of TitledPane concerning the ENTER key and focus

2015-03-19 Thread Keimel, Christoph
Hello I would like to address two difficulties we are having with TitledPane: - TitledPaneBehavior sets up a KeyBinding for ENTER to trigger the TitledPane to toggle its expanded property. (Issue A) - TitledPane accepts the focus even when is not collapsible (Issue B) *** Why I would like to ch