Re: hg: openjfx/9-dev/rt: 8043352: JEP 257: Update JavaFX/Media to Newer Version of GStreamer

2015-09-01 Thread David DeHaven

> On Aug 27, 2015, at 6:08 PM, kevin.rushfo...@oracle.com wrote:
> 
> Changeset: 241f9696e3ad
> Author:almatvee
> Date:  2015-08-27 14:35 -0700
> URL:   http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/241f9696e3ad
> 
> 8043352: JEP 257: Update JavaFX/Media to Newer Version of GStreamer
> Reviewed-by: stayer, ddehaven, kcr




-DrD-



Re: [9] Review request for 8131066: JavaFX MediaPlayer crashes on dispose with certain MP4s

2015-09-01 Thread David DeHaven

> Hi David,
> 
> Please review the fix:
> https://bugs.openjdk.java.net/browse/JDK-8131066
> http://cr.openjdk.java.net/~almatvee/8131066/webrev.00/
> 
> Crash happens, because AVPlayer was trying to notify AVFMediaPlayer about 
> frame change after AVFMediaPlayer was released. Fixed by unregistering 
> notification callback before AVFMediaPlayer is released.

Change looks good, approved. I also updated the JBS issue.

-DrD-



Re: JEP 253 Update: new JavaDoc ready for review

2015-09-01 Thread Jonathan Giles
This is likely true, to a degree. The thing is, most people who customise their 
controls do this at the skin level and retain the same behavior. This isn't 
always true of course, but it generally is. For this reason the priority is on 
getting the skins public first. Behaviors will come second, which is 
unfortunate, but we don't have enough runway to do everything we want.

-- Jonathan
Sent from a touch device. Please excuse my brevity.

On 1 September 2015 19:10:01 GMT+12:00, Robert Zenz 
 wrote:
>Am I seeing this right that this means that overriding/extending
>existing controls in JDK9 will become real hard because we have no way
>to get the already existing behavior and build upon it?
>
>
>On 31.08.2015 10:06, Jonathan Giles wrote:
>> That is correct. The feasibility of doing this in a JDK 9 update
>release
>> is another issue entirely, so the main point is that it will be at
>> some point after the first JDK 9 release, but no guarantees when.
>> -- Jonathan


Re: JEP 253 Update: new JavaDoc ready for review

2015-09-01 Thread Robert Zenz
Am I seeing this right that this means that overriding/extending
existing controls in JDK9 will become real hard because we have no way
to get the already existing behavior and build upon it?


On 31.08.2015 10:06, Jonathan Giles wrote:
> That is correct. The feasibility of doing this in a JDK 9 update release
> is another issue entirely, so the main point is that it will be at
> some point after the first JDK 9 release, but no guarantees when.
> -- Jonathan