date:20160105

RE: Review Request for 8090160 8090252 8089111

2016-01-05 Thread Ankit Srivastava

 

Hi Kevin, Alexander,

 

 

Please review the fix for  below JIRA defects :

 

JIRA: https://bugs.openjdk.java.net/browse/JDK-8090160?filter=-1

 

JIRA: https://bugs.openjdk.java.net/browse/JDK-8090252?filter=-1

 

JIRA: https://bugs.openjdk.java.net/browse/JDK-8089111?filter=-1

 

 

 

 

Webrev:  http://cr.openjdk.java.net/~arajkumar/ankit/8090160/webrev.00

Above mentioned JIRA defect consist if media related drt. 

Webrev is for below DRT test cases :

LayoutTests/media/video-fast-seek.html

LayoutTests/media/video-canvas-drawing-output.html

LayoutTests/media/video-seek-multiple.html

 

RootCause and Solution:

1)  The root cause is canPlayThroughEvent firing continuously for the test 
case, added check to fire the event for the first time.

2)  Playing event firing incorrectly, added check to fire the event for 
correctly.

3)  Added function hasSingleSecurityOrigin with return value as "true" in 
MediaPlayerPrivateJava.h so that canvas can get data without being tainted.
 
I have verified all the media DRT cases in Win and Linux .
Also I have verified "playing" event functionality with video play/pause.
 
NOTE:
 
1)  In the issue HYPERLINK 
"https://bugs.openjdk.java.net/browse/JDK-8090252"8090252 a test case 
media/video-canvas-drawing.html, which is getting failed due to media source 
corruption not able to play the media file.
.Avprobe  output  for the media file is :
 
avprobe version 9.18-6:9.18-0ubuntu0.14.04.1, Copyright (c) 2007-2014 the Libav 
developers
  built on Mar 16 2015 13:19:10 with gcc 4.8 (Ubuntu 4.8.2-19ubuntu1)
[mov,mp4,m4a,3gp,3g2,mj2 @ 0x1f8e320] max_analyze_duration reached
Input #0, mov,mp4,m4a,3gp,3g2,mj2, from 
'/home/ankit/drt/LayoutTests/media/content/counting.mp4':
  Metadata:
major_brand : mp42
minor_version   : 1
compatible_brands: mp42mp41
creation_time   : 2009-05-01 01:17:30
  Duration: 00:00:09.83, start: 0.00, bitrate: 253 kb/s
Stream #0.0(eng): Video: mpeg4 (Advanced Simple Profile), yuv420p, 352x288 
[PAR 1:1 DAR 11:9], 250 kb/s, 30 fps, 30 tbr, 600 tbn, 1k tbc
Metadata:
  creation_time   : 2009-05-01 01:17:30
Stream #0.1(eng): Data: mp4s / 0x7334706D, 0 kb/s
Metadata:
  creation_time   : 2009-05-01 01:17:30
Stream #0.2(eng): Data: mp4s / 0x7334706D, 0 kb/s
Metadata:
  creation_time   : 2009-05-01 01:17:30
Unsupported codec with id 0 for input stream 1
Unsupported codec with id 0 for input stream 2
# avprobe output
 
I will open a new issue for this test case.
 
2)  In the issue HYPERLINK 
"https://bugs.openjdk.java.net/browse/JDK-8090252"8090252  a test case 
media/video-canvas-drawing-output is getting failed on Win environment due to 
difference in colorspace management and/or media player on windows. I will open 
a new defect for the same.
The test has to be modified as per the Win environment.
 
3)  For test case media/video-load-preload-metadata.html and 
media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2.html,
 I have sent a mail to HYPERLINK 
"mailto:kirill.kiriche...@oracle.com"kirill.kiriche...@oracle.com and HYPERLINK 
"mailto:alexander.matv...@oracle.com"alexander.matv...@oracle.com to discuss 
some doubts.
 
 
 
 
Regards,
Ankit Srivastava

Re: including fonts

2016-01-05 Thread Philip Race


Hi,
That was a bit too vague for me to know what you mean.

Also there is no relationship with "AWT" (actually "Java 2D") fonts.
The Java FX API and implementation is completely independent of
anything in the core Java SE platform.

One point that might not have been clear enough is that you
shouldn't expect (for example) DirectWrite or CoreText to
understand the semantics of CSS and directly support accepting
CSS style parameters and managing CSS contexts. All of that
needs to belong to an "application layer" which is what the brower 
really  is,

and sits on top of those platform APIs.
And in this case the equivalent is the FX CSS implementation which sits
on top of the FX font API.

-phil.

On 1/5/16, 5:35 AM, Tom Eugelink wrote:
It should, but it does not. It seems the whole font management is 
based on AWT Font and that is missing a lot of CSS features.


Tom

On 4-1-2016 22:46, Phil Race wrote:

Hi,

I'm not certain I understand what it is that is missing.
I don't think Font.loadFont would need to accept the CSS parameters
and do the CSS-style lookup. @font-face should populate a CSS table
of names and styles. I expect that is what browsers do.
The CSS lookup code would then consult this internal table of fonts 
loaded

for the current CSS context and then ask the font system to use the one
that corresponds. If there is no match then it would be assumed it is a
request for a system provided font.

One thing that might be missing in Font.loadFont() is a way to keep 
the CSS
loaded fonts partioned. And there's a need for deriving a font with 
different attributes

as simple as a different size.


-phil.


On 01/04/2016 01:36 PM, David Grieve wrote:
The reason CSS ignores everything but src is that there is no public 
API in Font for providing the additional information.


CSS uses Font.loadFont to load a font from a @font-face src url. See 
com/sun/javafx/css/StyleManager.java


On 1/4/16 2:43 PM, Phil Race wrote:

Hi,

I can't speak authoritatively on the CSS implementation because I 
am not
familiar with it but here are some thoughts and observations that 
might help.


Suppose you have :
@font-face {
  font-family: RobotoMedium
  src: url("robotomedium.ttf"
}

My reading of the W3C spec. is that the name you specify as 
font-family
is used by CSS as the family name regardless of the *actual* name 
of the font
but I don't think FX can be working like that if it ignores 
font-family.


If CSS is ignoring everything except src that seems like
you then need to know for sure yourself what the family + style of 
the font is

and per that bug then use it via fx-font using the actual name+style.
This suggests CSS is loading the font into the list of fonts 
available to be used

by creating fonts directly from JavaFX API.
This seems to be confirmed by you seeing that Font.getFontNames()
reports these.

So you'd need to do the following for both font files
ie.

@font-face {
  font-family: BlahBlahDoesNotMatterApparently
  src: url("robotomedium.ttf")
}


@font-face {
  font-family: BlahBlahDoesNotMatterEither
  src: url("robotomediumitalic.ttf")
}

and reference as :

-fx-font: normal normal 12 "Roboto Medium"
-fx-font: italic normal 12 "Roboto Medium"

If this does not work then I don't know what CSS might be doing in 
its lookup.
The comment about only the last one loaded being available does not 
add up to me

unless CSS is doing some buggy filtering or remembering of its own.
Perhaps explicitly specifying "normal" will fix that.

-phil.

On 01/04/2016 12:08 AM, Tom Eugelink wrote:

No problem, thanks for the suggestion!

What I expect to be the cause is that the attributes in 
@font-face, specifying if a font is italic or not, are not 
supported. And they probably aren't populated based on the TTF 
metadata either. But before I dive too deep, maybe someone can 
prevent me from swimming in the wrong direction.


Tom


On 4-1-2016 00:02, cogmission (David Ray) wrote:
I guess I was assuming the "ideal"/expected behavior applied? 
Sorry...


On Sun, Jan 3, 2016 at 10:14 AM, Tom Eugelink > wrote:


Hi David,

Which would assume that if I specify no keywords, then it 
should take the normal version. It does not. Whatever version is 
loaded last is used.


Tom



On 3-1-2016 17:09, cogmission (David Ray) wrote:

Hi Tom,

I Believe in CSS, once you establish the family you can 
access the sub-types via type keywords?

...via

-fx-font-weight: bold,bolder etc.
-fx-font-style: plain, italic

Cheers,
David

On Sun, Jan 3, 2016 at 8:52 AM, Tom Eugelink 
 >> wrote:


Addendum:

If I list the font families using Font.getFamilies() 
I get "Roboto Medium" once, given that both TTF files are added 
using @font-face. But if I examine Font.getFontNames() I get 
separate entries for "Roboto Medium" and

Re: Full Screen Mode in JavaFX WebView

2016-01-05 Thread Kevin Rushforth

That might work, if implementing it directly turns out to be too much 
effort or is not a good fit.


-- Kevin


BoydEdmondson-NebulaSoftware wrote:

My theory is that one's Java code could override the JavaScript callbacks (defined at 
https://fullscreen.spec.whatwg.org, such as "element.requestFullscreen()" and 
"document.exitFullscreen()") and make the Stage go full screen and possibly do JavaScript on the 
element to style it with "width=100%;height=100%;".

So, if WebKit took the requestFullscreen() call, then Java could override it with 
application explicit customized support, and then WebView would have 
"implemented" full screen mode (by allowing Java applications to get the 
necessary notification hooks).

Boyd

-Original Message-
From: openjfx-dev [mailto:openjfx-dev-boun...@openjdk.java.net] On Behalf Of 
Dr. Michael Paus
Sent: January 5, 2016 7:35 AM
To: openjfx-dev@openjdk.java.net
Subject: Re: Full Screen Mode in JavaFX WebView

If I navigate with my WebView to a page with an embedded video player, 
like for example youtube,
and I then hit the full-screen button of this player how would my 
application know that the web page
would now like to be shown in full-screen mode, so that I can handle 
that in the way you explained?


Am 05.01.16 um 16:21 schrieb Kevin Rushforth:
  
Thank you for filing the RFE. Since WebView is an embedded component 
in a JavaFX scene graph, I'm not sure how easily we can (or whether we 
want to) implement browser full screen, but we can take a look at it 
and see whether it makes sense as a future enhancement.


Note that a JavaFX application Stage can become full-screen via 
Stage.setFullScreen(true). If you set up your scene graph with a 
StackPane as the root and a WebView node is the only child of the 
root, then you should be able to accomplish the same thing.


-- Kevin


BoydEdmondson-NebulaSoftware wrote:


http://bugs.java.com, ID's of JI-9028282 and JI-9028283.

Boyd

-Original Message-
From: BoydEdmondson-NebulaSoftware Sent: January 5, 2016 5:31 AM
To: 'Guru Hb'
Cc: 'openjfx-dev@openjdk.java.net'
Subject: RE: Full Screen Mode in JavaFX WebView

setPrefWidth/Height() do not help.

I submitted a request for enhancement to support 
https://fullscreen.spec.whatwg.org.
I submitted a bug for WebView hanging on 
http://browserbench.org/JetStream compliance test.


Boyd

-Original Message-
From: BoydEdmondson-NebulaSoftware Sent: January 4, 2016 8:36 AM
To: 'Guru Hb'
Cc: openjfx-dev@openjdk.java.net
Subject: RE: Full Screen Mode in JavaFX WebView

I'll give that a try, thanks.

The application works fine in all other browsers I've tested. It just 
fails in WebView.  I'll log defects as you suggest.


Boyd

-Original Message-
From: Guru Hb [mailto:guru...@oracle.com] Sent: January 4, 2016 8:33 AM
To: BoydEdmondson-NebulaSoftware
Cc: openjfx-dev@openjdk.java.net
Subject: RE: Full Screen Mode in JavaFX WebView

Please see comments embedded
-Original Message-
From: BoydEdmondson-NebulaSoftware 
[mailto:boydedmond...@nebulasoftware.com] Sent: Monday, January 04, 
2016 7:01 PM

To: openjfx-dev@openjdk.java.net
Subject: Full Screen Mode in JavaFX WebView

I have a custom Java application that uses JavaFX WebView to create a 
web browser (which uses WebKit).  I am trying to get the browser full 
screen mode to work (https://fullscreen.spec.whatwg.org/).




How can I get full screen mode to work in WebKit?
[WebView is an Embedded component and current it doesn't have full 
screen context menu (Like what we see in browser). WebView exposes 
two api setPrefWidth  & setPrefHeight, you can try setting it to max 
allowable view port size based on screen resolution. In addition (But 
I don't suggest), set the stage or group border to 0. But do NOTE 
that there won't be scroll bars visible, But you can drag the webpage]



I'm also trying to get WebKit's Web Inspector to work in my browser 
to help me debug this issue.  How can I activate Web Inspector in 
JavaFX WebView?
[Sorry, Web Inspector is not enabled in this port (Webkit port of 
JavaFX), alternatively you could  debug the application on Chrome or 
Safari. If you find a difference in the Rendering, JavaScript or 
other defect, feel free to log a defect ref 
https://wiki.openjdk.java.net/display/OpenJFX/Submitting+a+Bug+Report]

Thanks for any information.

Re: including fonts

2016-01-05 Thread Tom Eugelink


You are right, the PrismFontLoader is used to load the font. I was mistaken 
because of the use of the Toolkit class.

Interestingly, in PrismFontFactory a text is appended to the family if the font 
is italic or bold (e.g. Roboto italic.italic). So the information is recorded. 
I need to dig deeper to find out where this is going wrong.

Tom



On 5-1-2016 17:11, Philip Race wrote:

Hi,
That was a bit too vague for me to know what you mean.

Also there is no relationship with "AWT" (actually "Java 2D") fonts.
The Java FX API and implementation is completely independent of
anything in the core Java SE platform.

One point that might not have been clear enough is that you
shouldn't expect (for example) DirectWrite or CoreText to
understand the semantics of CSS and directly support accepting
CSS style parameters and managing CSS contexts. All of that
needs to belong to an "application layer" which is what the brower really  is,
and sits on top of those platform APIs.
And in this case the equivalent is the FX CSS implementation which sits
on top of the FX font API.

-phil.

On 1/5/16, 5:35 AM, Tom Eugelink wrote:

It should, but it does not. It seems the whole font management is based on AWT 
Font and that is missing a lot of CSS features.

Tom

On 4-1-2016 22:46, Phil Race wrote:

Hi,

I'm not certain I understand what it is that is missing.
I don't think Font.loadFont would need to accept the CSS parameters
and do the CSS-style lookup. @font-face should populate a CSS table
of names and styles. I expect that is what browsers do.
The CSS lookup code would then consult this internal table of fonts loaded
for the current CSS context and then ask the font system to use the one
that corresponds. If there is no match then it would be assumed it is a
request for a system provided font.

One thing that might be missing in Font.loadFont() is a way to keep the CSS
loaded fonts partioned. And there's a need for deriving a font with different 
attributes
as simple as a different size.


-phil.


On 01/04/2016 01:36 PM, David Grieve wrote:

The reason CSS ignores everything but src is that there is no public API in 
Font for providing the additional information.

CSS uses Font.loadFont to load a font from a @font-face src url. See 
com/sun/javafx/css/StyleManager.java

On 1/4/16 2:43 PM, Phil Race wrote:

Hi,

I can't speak authoritatively on the CSS implementation because I am not
familiar with it but here are some thoughts and observations that might help.

Suppose you have :
@font-face {
  font-family: RobotoMedium
  src: url("robotomedium.ttf"
}

My reading of the W3C spec. is that the name you specify as font-family
is used by CSS as the family name regardless of the *actual* name of the font
but I don't think FX can be working like that if it ignores font-family.

If CSS is ignoring everything except src that seems like
you then need to know for sure yourself what the family + style of the font is
and per that bug then use it via fx-font using the actual name+style.
This suggests CSS is loading the font into the list of fonts available to be 
used
by creating fonts directly from JavaFX API.
This seems to be confirmed by you seeing that Font.getFontNames()
reports these.

So you'd need to do the following for both font files
ie.

@font-face {
  font-family: BlahBlahDoesNotMatterApparently
  src: url("robotomedium.ttf")
}


@font-face {
  font-family: BlahBlahDoesNotMatterEither
  src: url("robotomediumitalic.ttf")
}

and reference as :

-fx-font: normal normal 12 "Roboto Medium"
-fx-font: italic normal 12 "Roboto Medium"

If this does not work then I don't know what CSS might be doing in its lookup.
The comment about only the last one loaded being available does not add up to me
unless CSS is doing some buggy filtering or remembering of its own.
Perhaps explicitly specifying "normal" will fix that.

-phil.

On 01/04/2016 12:08 AM, Tom Eugelink wrote:

No problem, thanks for the suggestion!

What I expect to be the cause is that the attributes in @font-face, specifying 
if a font is italic or not, are not supported. And they probably aren't 
populated based on the TTF metadata either. But before I dive too deep, maybe 
someone can prevent me from swimming in the wrong direction.

Tom


On 4-1-2016 00:02, cogmission (David Ray) wrote:

I guess I was assuming the "ideal"/expected behavior applied? Sorry...

On Sun, Jan 3, 2016 at 10:14 AM, Tom Eugelink > wrote:

Hi David,

Which would assume that if I specify no keywords, then it should take the 
normal version. It does not. Whatever version is loaded last is used.

Tom



On 3-1-2016 17:09, cogmission (David Ray) wrote:

Hi Tom,

I Believe in CSS, once you establish the family you can access the 
sub-types via type keywords?
...via

-fx-font-weight: bold,bolder etc.
-fx-font-style: plain, italic

Cheers,
David

On Sun, Jan 3, 2016 at 8:52 AM, Tom

Re: Full Screen Mode in JavaFX WebView

2016-01-05 Thread Kevin Rushforth

Thank you for filing the RFE. Since WebView is an embedded component in 
a JavaFX scene graph, I'm not sure how easily we can (or whether we want 
to) implement browser full screen, but we can take a look at it and see 
whether it makes sense as a future enhancement.


Note that a JavaFX application Stage can become full-screen via 
Stage.setFullScreen(true). If you set up your scene graph with a 
StackPane as the root and a WebView node is the only child of the root, 
then you should be able to accomplish the same thing.


-- Kevin


BoydEdmondson-NebulaSoftware wrote:

http://bugs.java.com, ID's of JI-9028282 and JI-9028283.

Boyd

-Original Message-
From: BoydEdmondson-NebulaSoftware 
Sent: January 5, 2016 5:31 AM

To: 'Guru Hb'
Cc: 'openjfx-dev@openjdk.java.net'
Subject: RE: Full Screen Mode in JavaFX WebView

setPrefWidth/Height() do not help.

I submitted a request for enhancement to support https://fullscreen.spec.whatwg.org. 


I submitted a bug for WebView hanging on  http://browserbench.org/JetStream 
compliance test.

Boyd

-Original Message-
From: BoydEdmondson-NebulaSoftware 
Sent: January 4, 2016 8:36 AM

To: 'Guru Hb'
Cc: openjfx-dev@openjdk.java.net
Subject: RE: Full Screen Mode in JavaFX WebView

I'll give that a try, thanks.

The application works fine in all other browsers I've tested.  It just fails in 
WebView.  I'll log defects as you suggest.

Boyd

-Original Message-
From: Guru Hb [mailto:guru...@oracle.com] 
Sent: January 4, 2016 8:33 AM

To: BoydEdmondson-NebulaSoftware
Cc: openjfx-dev@openjdk.java.net
Subject: RE: Full Screen Mode in JavaFX WebView

Please see comments embedded 


-Original Message-
From: BoydEdmondson-NebulaSoftware [mailto:boydedmond...@nebulasoftware.com] 
Sent: Monday, January 04, 2016 7:01 PM

To: openjfx-dev@openjdk.java.net
Subject: Full Screen Mode in JavaFX WebView

I have a custom Java application that uses JavaFX WebView to create a web 
browser (which uses WebKit).  I am trying to get the browser full screen mode 
to work (https://fullscreen.spec.whatwg.org/).



How can I get full screen mode to work in WebKit?
[WebView is an Embedded component and current it doesn't have full screen context 
menu (Like what we see in browser). WebView exposes two api setPrefWidth  & 
setPrefHeight, you can try setting it to max allowable view port size based on 
screen resolution. In addition (But I don't suggest), set the stage or group border 
to 0. But do NOTE that there won't be scroll bars visible, But you can drag the 
webpage]


I'm also trying to get WebKit's Web Inspector to work in my browser to help me 
debug this issue.  How can I activate Web Inspector in JavaFX WebView?
[Sorry, Web Inspector is not enabled in this port (Webkit port of JavaFX), alternatively you could  debug the application on Chrome or Safari. If you find a difference in the Rendering, JavaScript or other defect, feel free to log a defect ref https://wiki.openjdk.java.net/display/OpenJFX/Submitting+a+Bug+Report] 


Thanks for any information.

Result: New OpenJFX Committer: Johan Vos

2016-01-05 Thread David Hill



Voting for Johan Vos to OpenJFX Committer [1] is now closed.

Yes: 11
Veto: 0
Abstain: 0

According to the Bylaws definition of Lazy Consensus, this is sufficient to 
approve the nomination.

Dave

[1] http://mail.openjdk.java.net/pipermail/openjfx-dev/2014-May/013881.html

--
David Hill 
Java Embedded Development

"The most likely way for the world to be destroyed, most experts agree, is by 
accident. That's where we come in; we're computer professionals. We cause accidents."
-- Nathaniel Borenstein (1957 - )

RE: Full Screen Mode in JavaFX WebView

2016-01-05 Thread BoydEdmondson-NebulaSoftware

My theory is that one's Java code could override the JavaScript callbacks 
(defined at https://fullscreen.spec.whatwg.org, such as 
"element.requestFullscreen()" and "document.exitFullscreen()") and make the 
Stage go full screen and possibly do JavaScript on the element to style it with 
"width=100%;height=100%;".

So, if WebKit took the requestFullscreen() call, then Java could override it 
with application explicit customized support, and then WebView would have 
"implemented" full screen mode (by allowing Java applications to get the 
necessary notification hooks).

Boyd

-Original Message-
From: openjfx-dev [mailto:openjfx-dev-boun...@openjdk.java.net] On Behalf Of 
Dr. Michael Paus
Sent: January 5, 2016 7:35 AM
To: openjfx-dev@openjdk.java.net
Subject: Re: Full Screen Mode in JavaFX WebView

If I navigate with my WebView to a page with an embedded video player, 
like for example youtube,
and I then hit the full-screen button of this player how would my 
application know that the web page
would now like to be shown in full-screen mode, so that I can handle 
that in the way you explained?

Am 05.01.16 um 16:21 schrieb Kevin Rushforth:
> Thank you for filing the RFE. Since WebView is an embedded component 
> in a JavaFX scene graph, I'm not sure how easily we can (or whether we 
> want to) implement browser full screen, but we can take a look at it 
> and see whether it makes sense as a future enhancement.
>
> Note that a JavaFX application Stage can become full-screen via 
> Stage.setFullScreen(true). If you set up your scene graph with a 
> StackPane as the root and a WebView node is the only child of the 
> root, then you should be able to accomplish the same thing.
>
> -- Kevin
>
>
> BoydEdmondson-NebulaSoftware wrote:
>> http://bugs.java.com, ID's of JI-9028282 and JI-9028283.
>>
>> Boyd
>>
>> -Original Message-
>> From: BoydEdmondson-NebulaSoftware Sent: January 5, 2016 5:31 AM
>> To: 'Guru Hb'
>> Cc: 'openjfx-dev@openjdk.java.net'
>> Subject: RE: Full Screen Mode in JavaFX WebView
>>
>> setPrefWidth/Height() do not help.
>>
>> I submitted a request for enhancement to support 
>> https://fullscreen.spec.whatwg.org.
>> I submitted a bug for WebView hanging on 
>> http://browserbench.org/JetStream compliance test.
>>
>> Boyd
>>
>> -Original Message-
>> From: BoydEdmondson-NebulaSoftware Sent: January 4, 2016 8:36 AM
>> To: 'Guru Hb'
>> Cc: openjfx-dev@openjdk.java.net
>> Subject: RE: Full Screen Mode in JavaFX WebView
>>
>> I'll give that a try, thanks.
>>
>> The application works fine in all other browsers I've tested. It just 
>> fails in WebView.  I'll log defects as you suggest.
>>
>> Boyd
>>
>> -Original Message-
>> From: Guru Hb [mailto:guru...@oracle.com] Sent: January 4, 2016 8:33 AM
>> To: BoydEdmondson-NebulaSoftware
>> Cc: openjfx-dev@openjdk.java.net
>> Subject: RE: Full Screen Mode in JavaFX WebView
>>
>> Please see comments embedded
>> -Original Message-
>> From: BoydEdmondson-NebulaSoftware 
>> [mailto:boydedmond...@nebulasoftware.com] Sent: Monday, January 04, 
>> 2016 7:01 PM
>> To: openjfx-dev@openjdk.java.net
>> Subject: Full Screen Mode in JavaFX WebView
>>
>> I have a custom Java application that uses JavaFX WebView to create a 
>> web browser (which uses WebKit).  I am trying to get the browser full 
>> screen mode to work (https://fullscreen.spec.whatwg.org/).
>>
>>
>>
>> How can I get full screen mode to work in WebKit?
>> [WebView is an Embedded component and current it doesn't have full 
>> screen context menu (Like what we see in browser). WebView exposes 
>> two api setPrefWidth  & setPrefHeight, you can try setting it to max 
>> allowable view port size based on screen resolution. In addition (But 
>> I don't suggest), set the stage or group border to 0. But do NOTE 
>> that there won't be scroll bars visible, But you can drag the webpage]
>>
>>
>> I'm also trying to get WebKit's Web Inspector to work in my browser 
>> to help me debug this issue.  How can I activate Web Inspector in 
>> JavaFX WebView?
>> [Sorry, Web Inspector is not enabled in this port (Webkit port of 
>> JavaFX), alternatively you could  debug the application on Chrome or 
>> Safari. If you find a difference in the Rendering, JavaScript or 
>> other defect, feel free to log a defect ref 
>> https://wiki.openjdk.java.net/display/OpenJFX/Submitting+a+Bug+Report]
>> Thanks for any information.

Re: including fonts

2016-01-05 Thread Tom Eugelink

It should, but it does not. It seems the whole font management is based on AWT
Font and that is missing a lot of CSS features.

Tom

On 4-1-2016 22:46, Phil Race wrote:

Hi,

I'm not certain I understand what it is that is missing.
I don't think Font.loadFont would need to accept the CSS parameters
and do the CSS-style lookup. @font-face should populate a CSS table
of names and styles. I expect that is what browsers do.
The CSS lookup code would then consult this internal table of fonts loaded
for the current CSS context and then ask the font system to use the one
that corresponds. If there is no match then it would be assumed it is a
request for a system provided font.

One thing that might be missing in Font.loadFont() is a way to keep the CSS
loaded fonts partioned. And there's a need for deriving a font with different
attributes
as simple as a different size.

-phil.

On 01/04/2016 01:36 PM, David Grieve wrote:

The reason CSS ignores everything but src is that there is no public API in
Font for providing the additional information.

CSS uses Font.loadFont to load a font from a @font-face src url. See
com/sun/javafx/css/StyleManager.java

On 1/4/16 2:43 PM, Phil Race wrote:

Hi,

I can't speak authoritatively on the CSS implementation because I am not
familiar with it but here are some thoughts and observations that might help.

Suppose you have :
@font-face {
font-family: RobotoMedium
src: url("robotomedium.ttf"
}

My reading of the W3C spec. is that the name you specify as font-family
is used by CSS as the family name regardless of the *actual* name of the font
but I don't think FX can be working like that if it ignores font-family.

If CSS is ignoring everything except src that seems like
you then need to know for sure yourself what the family + style of the font is
and per that bug then use it via fx-font using the actual name+style.
This suggests CSS is loading the font into the list of fonts available to be
used
by creating fonts directly from JavaFX API.
This seems to be confirmed by you seeing that Font.getFontNames()
reports these.

So you'd need to do the following for both font files
ie.

@font-face {
font-family: BlahBlahDoesNotMatterApparently
src: url("robotomedium.ttf")
}

@font-face {
font-family: BlahBlahDoesNotMatterEither
src: url("robotomediumitalic.ttf")
}

and reference as :

-fx-font: normal normal 12 "Roboto Medium"
-fx-font: italic normal 12 "Roboto Medium"

If this does not work then I don't know what CSS might be doing in its lookup.
The comment about only the last one loaded being available does not add up to me
unless CSS is doing some buggy filtering or remembering of its own.
Perhaps explicitly specifying "normal" will fix that.

-phil.

On 01/04/2016 12:08 AM, Tom Eugelink wrote:

No problem, thanks for the suggestion!

What I expect to be the cause is that the attributes in @font-face, specifying
if a font is italic or not, are not supported. And they probably aren't
populated based on the TTF metadata either. But before I dive too deep, maybe
someone can prevent me from swimming in the wrong direction.

Tom

On 4-1-2016 00:02, cogmission (David Ray) wrote:

I guess I was assuming the "ideal"/expected behavior applied? Sorry...

On Sun, Jan 3, 2016 at 10:14 AM, Tom Eugelink > wrote:

Hi David,

Which would assume that if I specify no keywords, then it should take the
normal version. It does not. Whatever version is loaded last is used.

Tom

On 3-1-2016 17:09, cogmission (David Ray) wrote:

Hi Tom,

I Believe in CSS, once you establish the family you can access the
sub-types via type keywords?
...via

-fx-font-weight: bold,bolder etc.
-fx-font-style: plain, italic

Cheers,
David

On Sun, Jan 3, 2016 at 8:52 AM, Tom Eugelink
>> wrote:

Addendum:

If I list the font families using Font.getFamilies() I get "Roboto Medium" once, given
that both TTF files are added using @font-face. But if I examine Font.getFontNames() I get separate entries
for "Roboto Medium" and "Roboto Medium Italic". Closer examination of the font loading
reveals that indeed each font has its own distinct name and some fonts shared the same family name. That
makes sense.

The thing is that in CSS -as far as I can see- fonts can only
accessed through its family name, not its own name.

Tom

On 3-1-2016 11:21, Tom Eugelink wrote:

I'm currently including Google's Roboto font in JFXtras and making it
easily available to other users. I noticed that the font-family attribute in font-face is
ignored, and you have to use the name as it is specified in the TTF file. I found
https://bugs.openjdk.java.net/browse/JDK-8094516 which says "/Please note that all
@font‑face descriptors are ignored except

RE: Full Screen Mode in JavaFX WebView

2016-01-05 Thread BoydEdmondson-NebulaSoftware

http://bugs.java.com, ID's of JI-9028282 and JI-9028283.

Boyd

-Original Message-
From: BoydEdmondson-NebulaSoftware 
Sent: January 5, 2016 5:31 AM
To: 'Guru Hb'
Cc: 'openjfx-dev@openjdk.java.net'
Subject: RE: Full Screen Mode in JavaFX WebView

setPrefWidth/Height() do not help.

I submitted a request for enhancement to support 
https://fullscreen.spec.whatwg.org. 

I submitted a bug for WebView hanging on  http://browserbench.org/JetStream 
compliance test.

Boyd

-Original Message-
From: BoydEdmondson-NebulaSoftware 
Sent: January 4, 2016 8:36 AM
To: 'Guru Hb'
Cc: openjfx-dev@openjdk.java.net
Subject: RE: Full Screen Mode in JavaFX WebView

I'll give that a try, thanks.

The application works fine in all other browsers I've tested.  It just fails in 
WebView.  I'll log defects as you suggest.

Boyd

-Original Message-
From: Guru Hb [mailto:guru...@oracle.com] 
Sent: January 4, 2016 8:33 AM
To: BoydEdmondson-NebulaSoftware
Cc: openjfx-dev@openjdk.java.net
Subject: RE: Full Screen Mode in JavaFX WebView

Please see comments embedded 

-Original Message-
From: BoydEdmondson-NebulaSoftware [mailto:boydedmond...@nebulasoftware.com] 
Sent: Monday, January 04, 2016 7:01 PM
To: openjfx-dev@openjdk.java.net
Subject: Full Screen Mode in JavaFX WebView

I have a custom Java application that uses JavaFX WebView to create a web 
browser (which uses WebKit).  I am trying to get the browser full screen mode 
to work (https://fullscreen.spec.whatwg.org/).

How can I get full screen mode to work in WebKit?
[WebView is an Embedded component and current it doesn't have full screen 
context menu (Like what we see in browser). WebView exposes two api 
setPrefWidth  & setPrefHeight, you can try setting it to max allowable view 
port size based on screen resolution. In addition (But I don't suggest), set 
the stage or group border to 0. But do NOTE that there won't be scroll bars 
visible, But you can drag the webpage]

I'm also trying to get WebKit's Web Inspector to work in my browser to help me 
debug this issue.  How can I activate Web Inspector in JavaFX WebView?
[Sorry, Web Inspector is not enabled in this port (Webkit port of JavaFX), 
alternatively you could  debug the application on Chrome or Safari. If you find 
a difference in the Rendering, JavaScript or other defect, feel free to log a 
defect ref 
https://wiki.openjdk.java.net/display/OpenJFX/Submitting+a+Bug+Report] 

Thanks for any information.

Re: Full Screen Mode in JavaFX WebView

2016-01-05 Thread Dr. Michael Paus

If I navigate with my WebView to a page with an embedded video player, 
like for example youtube,
and I then hit the full-screen button of this player how would my 
application know that the web page
would now like to be shown in full-screen mode, so that I can handle 
that in the way you explained?


Am 05.01.16 um 16:21 schrieb Kevin Rushforth:
Thank you for filing the RFE. Since WebView is an embedded component 
in a JavaFX scene graph, I'm not sure how easily we can (or whether we 
want to) implement browser full screen, but we can take a look at it 
and see whether it makes sense as a future enhancement.


Note that a JavaFX application Stage can become full-screen via 
Stage.setFullScreen(true). If you set up your scene graph with a 
StackPane as the root and a WebView node is the only child of the 
root, then you should be able to accomplish the same thing.


-- Kevin


BoydEdmondson-NebulaSoftware wrote:

http://bugs.java.com, ID's of JI-9028282 and JI-9028283.

Boyd

-Original Message-
From: BoydEdmondson-NebulaSoftware Sent: January 5, 2016 5:31 AM
To: 'Guru Hb'
Cc: 'openjfx-dev@openjdk.java.net'
Subject: RE: Full Screen Mode in JavaFX WebView

setPrefWidth/Height() do not help.

I submitted a request for enhancement to support 
https://fullscreen.spec.whatwg.org.
I submitted a bug for WebView hanging on 
http://browserbench.org/JetStream compliance test.


Boyd

-Original Message-
From: BoydEdmondson-NebulaSoftware Sent: January 4, 2016 8:36 AM
To: 'Guru Hb'
Cc: openjfx-dev@openjdk.java.net
Subject: RE: Full Screen Mode in JavaFX WebView

I'll give that a try, thanks.

The application works fine in all other browsers I've tested. It just 
fails in WebView.  I'll log defects as you suggest.


Boyd

-Original Message-
From: Guru Hb [mailto:guru...@oracle.com] Sent: January 4, 2016 8:33 AM
To: BoydEdmondson-NebulaSoftware
Cc: openjfx-dev@openjdk.java.net
Subject: RE: Full Screen Mode in JavaFX WebView

Please see comments embedded
-Original Message-
From: BoydEdmondson-NebulaSoftware 
[mailto:boydedmond...@nebulasoftware.com] Sent: Monday, January 04, 
2016 7:01 PM

To: openjfx-dev@openjdk.java.net
Subject: Full Screen Mode in JavaFX WebView

I have a custom Java application that uses JavaFX WebView to create a 
web browser (which uses WebKit).  I am trying to get the browser full 
screen mode to work (https://fullscreen.spec.whatwg.org/).




How can I get full screen mode to work in WebKit?
[WebView is an Embedded component and current it doesn't have full 
screen context menu (Like what we see in browser). WebView exposes 
two api setPrefWidth  & setPrefHeight, you can try setting it to max 
allowable view port size based on screen resolution. In addition (But 
I don't suggest), set the stage or group border to 0. But do NOTE 
that there won't be scroll bars visible, But you can drag the webpage]



I'm also trying to get WebKit's Web Inspector to work in my browser 
to help me debug this issue.  How can I activate Web Inspector in 
JavaFX WebView?
[Sorry, Web Inspector is not enabled in this port (Webkit port of 
JavaFX), alternatively you could  debug the application on Chrome or 
Safari. If you find a difference in the Rendering, JavaScript or 
other defect, feel free to log a defect ref 
https://wiki.openjdk.java.net/display/OpenJFX/Submitting+a+Bug+Report]

Thanks for any information.

[9] review request: JDK-8146512 Table Borders are not drawn properly

2016-01-05 Thread Murali Billa

 

Hi Kevin, Alexander, Guru,

 

Please review the fix for below issue :

 

JIRA: https://bugs.openjdk.java.net/browse/JDK-8146512

 

Webrev:  http://cr.openjdk.java.net/~arajkumar/murali/8146512/webrev.00/

 

 

Root Cause: Table Borders are not drawn properly in web sites like wikipedia. 
There is a regression with r153510 (http://trac.webkit.org/changeset/153510) 
and r154622 (http://trac.webkit.org/changeset/154622) from 8u60, which involves 
drawing dotted line and painting collapsed border. The commits r153510 and 
r154622  caused regressions in websites like wikipedia  where table borders are 
not drawn properly.



Fix: Applying webkit patch http://trac.webkit.org/changeset/169814   and 
Verified the fix for above mentioned website.
 
 
Also below DRT cases ran  and passed.
 

fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl.html
 

fast/table/border-collapsing/collapsed-borders-painted-once-on-inner-cells.html

fast/table/border-collapsing/dotted-collapsed-border.html

 

Thanks,

Murali

RE: Full Screen Mode in JavaFX WebView

2016-01-05 Thread BoydEdmondson-NebulaSoftware

setPrefWidth/Height() do not help.

I submitted a request for enhancement to support 
https://fullscreen.spec.whatwg.org. 

I submitted a bug for WebView hanging on  http://browserbench.org/JetStream 
compliance test.

Boyd

-Original Message-
From: BoydEdmondson-NebulaSoftware 
Sent: January 4, 2016 8:36 AM
To: 'Guru Hb'
Cc: openjfx-dev@openjdk.java.net
Subject: RE: Full Screen Mode in JavaFX WebView

I'll give that a try, thanks.

The application works fine in all other browsers I've tested.  It just fails in 
WebView.  I'll log defects as you suggest.

Boyd

-Original Message-
From: Guru Hb [mailto:guru...@oracle.com] 
Sent: January 4, 2016 8:33 AM
To: BoydEdmondson-NebulaSoftware
Cc: openjfx-dev@openjdk.java.net
Subject: RE: Full Screen Mode in JavaFX WebView

Please see comments embedded 

-Original Message-
From: BoydEdmondson-NebulaSoftware [mailto:boydedmond...@nebulasoftware.com] 
Sent: Monday, January 04, 2016 7:01 PM
To: openjfx-dev@openjdk.java.net
Subject: Full Screen Mode in JavaFX WebView

I have a custom Java application that uses JavaFX WebView to create a web 
browser (which uses WebKit).  I am trying to get the browser full screen mode 
to work (https://fullscreen.spec.whatwg.org/).



How can I get full screen mode to work in WebKit?
[WebView is an Embedded component and current it doesn't have full screen 
context menu (Like what we see in browser). WebView exposes two api 
setPrefWidth  & setPrefHeight, you can try setting it to max allowable view 
port size based on screen resolution. In addition (But I don't suggest), set 
the stage or group border to 0. But do NOTE that there won't be scroll bars 
visible, But you can drag the webpage]


I'm also trying to get WebKit's Web Inspector to work in my browser to help me 
debug this issue.  How can I activate Web Inspector in JavaFX WebView?
[Sorry, Web Inspector is not enabled in this port (Webkit port of JavaFX), 
alternatively you could  debug the application on Chrome or Safari. If you find 
a difference in the Rendering, JavaScript or other defect, feel free to log a 
defect ref 
https://wiki.openjdk.java.net/display/OpenJFX/Submitting+a+Bug+Report] 

Thanks for any information.

[9] Review request: 8145604: Change minimum version of OS X SDK to 10.9

2016-01-05 Thread Kevin Rushforth

Please review the following change to the OS X build files to require a 
minimum version of SDK 10.9.


https://bugs.openjdk.java.net/browse/JDK-8145604
http://cr.openjdk.java.net/~kcr/8145604/webrev.01/

The bulk of the changes are in media, so anyone who wishes to test this 
should do:


gradle -PCOMPILE_MEDIA=true clean sdk

Thanks to Dave D for the media Makefile changes.

-- Kevin

RE: Review Request for 8090160 8090252 8089111

Re: including fonts

Re: Full Screen Mode in JavaFX WebView

Re: including fonts

Re: Full Screen Mode in JavaFX WebView

Result: New OpenJFX Committer: Johan Vos

RE: Full Screen Mode in JavaFX WebView

Re: including fonts

RE: Full Screen Mode in JavaFX WebView

Re: Full Screen Mode in JavaFX WebView

[9] review request: JDK-8146512 Table Borders are not drawn properly

RE: Full Screen Mode in JavaFX WebView

[9] Review request: 8145604: Change minimum version of OS X SDK to 10.9

13 matches

Site Navigation

Mail list logo

Footer information