Re: GLS language errors (Was: Internal error: Error loading stock shader FillRoundRect_LinearGradient,_PAD on Vivante ARM)

2016-03-01 Thread Maurice
Jim, A solution in line of that of Johan Vos [1] works. JavaFX can be run and doesn't crash on startup when compiling the shaders. I think they should be taken into account for at least JavaFX 9, as it reduces a very serious bug to a possible optimization. Maurice. [1]

[9] Review request for 8147851: jvm crash at javafx com.sun.webkit.WebPage.twkPrePaint

2016-03-01 Thread Nakul Natu
Hello, Please review the webrev: http://cr.openjdk.java.net/~kcr/nnatu/8147851/webrev.00/ JBS: https://bugs.openjdk.java.net/browse/JDK-8147851 Regards, Nakul

Re: GLS language errors (Was: Internal error: Error loading stock shader FillRoundRect_LinearGradient,_PAD on Vivante ARM)

2016-03-01 Thread Jim Graham
The thing about this use of pixcoord is that the same information can be supplied much more efficiently as a pair of texture coordinates. The value of pixcoord ends up being a linear equation over the area of the primitive which is exactly what texture coordinate samples give you for free.

Request Review: 8148654 [packager] Add support for module path when calling jdeps

2016-03-01 Thread Chris Bensen
Hi Kevin, Small packager change to pass module path to to the call to JDEPS. JIRA: https://bugs.openjdk.java.net/browse/JDK-8148654 Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8148654/webrev.00/ Thanks, Chris

Re: GLS language errors

2016-03-01 Thread Maurice
Not only does it reduce the amount of errors, but I'm able to run Ensemble, until now without any errors. Therefore it seems to be the right solution. Maurice. Prism pipeline init order: es2 sw Using native-based Pisces rasterizer Using dirty region optimizations Using system sized mask for

Re: GLS language errors

2016-03-01 Thread Maurice
Moving the declaration into the main() method reduces the amount of errors found by the glslangValidator drastically, though it still finds several issues: ./modules/graphics/src/main/resources/com/sun/prism/es2/glsl/normalMap_texture.frag ERROR: 0:53: 'oTexCoords' : undeclared identifier

Re: GLS language errors (Was: Internal error: Error loading stock shader FillRoundRect_LinearGradient,_PAD on Vivante ARM)

2016-03-01 Thread Maurice
Erik, I've included the generated source code of FillRoundRect_LinearGradient_PAD. I've made the offending lines bold. I've experimented with adding some modifiers, but to no avail. Maurice. #ifdef GL_ES #extension GL_OES_standard_derivatives : enable #ifdef GL_FRAGMENT_PRECISION_HIGH

Re: GLS language errors (Was: Internal error: Error loading stock shader FillRoundRect_LinearGradient,_PAD on Vivante ARM)

2016-03-01 Thread Erik De Rijcke
I'm not a shader expert either but I have worked (and written some myself) with them, so I'll give my 0.02$ (given that I have no idea what the complete shader looks like) It looks to me like the initialization of a default scoped global (eg Johan's vec2 pixcoord) is done using non constant

Re: GLS language errors (Was: Internal error: Error loading stock shader FillRoundRect_LinearGradient,_PAD on Vivante ARM)

2016-03-01 Thread Maurice
I'm not very familiar with shader coding, but can't this be solved by putting a non-constant modifier in fron of it? I notice other variables are declared as 'varying' or 'uniform'. Maurice. Op 29-02-16 om 20:45 schreef Johan Vos: Hi, It seems to me you might be running in the same issue we

[9] RFR for 8149737:JRE crash in com.sun.webkit.network.URLLoader.twkDidFinishLoading

2016-03-01 Thread mikhail cherkasov
Hi Guru, Kevin, Please review the webrev : http://cr.openjdk.java.net/~mcherkas/8149737/webrev/ Crash occurs during the page destroy and still there is are some pending sub-resource from network. I added a check for null, see line 814 in CachedResourceLoader.cpp to prevent crash. JBS: