[9] Code Review Request: 8144556: Add support to allow user specified rendering order

[Chien Yang]

Please review the proposed specification and implementation.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8144556
Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8144556/webrev.00/

- Chien

review: convert addExports to new syntax

[David Hill]

Kevin,
yet another review for you to look at :-)

https://bugs.openjdk.java.net/browse/JDK-8153231
http://cr.openjdk.java.net/~ddhill/8153231/

--
David Hill
Java Embedded Development

"A man's feet should be planted in his country, but his eyes should survey the 
world."
-- George Santayana (1863 - 1952)

Re: CFV: New OpenJFX Committer: Murali Billa

[David Hill]

On 3/31/16, 5:04 PM, Kevin Rushforth wrote:

VOTE: yes

I hereby nominate Murali Billa [1] to OpenJFX Committer.

Murali is a member of JavaFX team at Oracle working on WebKit, who has 
contributed 10 changesets [5] to OpenJFX, at least 8 of which are significant.

Votes are due by April 14, 2016.

Only current OpenJFX Committers [2] are eligible to vote on this nomination. 
Votes must be cast in the open by replying to this mailing list.

For Lazy Consensus voting instructions, see [3]. Nomination to a project 
Committer is described in [4].

Thanks,

-- Kevin

[1] http://openjdk.java.net/census#mbilla

[2] http://openjdk.java.net/census#openjfx

[3] http://openjdk.java.net/bylaws#lazy-consensus

[4] http://openjdk.java.net/projects#project-committer

[5] List of changesets:
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/a251a1d65932
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/ecea43f5734c
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/42b461505f27
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/82ecaebd44cf
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/8643ca988cef
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/765fd07f22fc
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/ae75f92d5e53
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/25db4b2e47a1
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/51c2129d282c
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/cb8a24f5db2a




--
David Hill
Java Embedded Development

"A man's feet should be planted in his country, but his eyes should survey the 
world."
-- George Santayana (1863 - 1952)

Re: CFV: New OpenJFX Committer: Murali Billa

[Phil Race]

Vote: yes

-phil.

On 03/31/2016 02:04 PM, Kevin Rushforth wrote:

I hereby nominate Murali Billa [1] to OpenJFX Committer.

Re: CFV: New OpenJFX Committer: Murali Billa

[Jonathan Giles]

Vote: YES

-- Jonathan

On 1/04/16 10:04 AM, Kevin Rushforth wrote:

I hereby nominate Murali Billa [1] to OpenJFX Committer.

Murali is a member of JavaFX team at Oracle working on WebKit, who has 
contributed 10 changesets [5] to OpenJFX, at least 8 of which are 
significant.


Votes are due by April 14, 2016.

Only current OpenJFX Committers [2] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing 
list.


For Lazy Consensus voting instructions, see [3]. Nomination to a 
project Committer is described in [4].


Thanks,

-- Kevin

[1] http://openjdk.java.net/census#mbilla

[2] http://openjdk.java.net/census#openjfx

[3] http://openjdk.java.net/bylaws#lazy-consensus

[4] http://openjdk.java.net/projects#project-committer

[5] List of changesets:
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/a251a1d65932
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/ecea43f5734c
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/42b461505f27
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/82ecaebd44cf
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/8643ca988cef
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/765fd07f22fc
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/ae75f92d5e53
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/25db4b2e47a1
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/51c2129d282c
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/cb8a24f5db2a

Re: CFV: New OpenJFX Committer: Murali Billa

[Morris Meyer]

Vote:  YES

On 3/31/16 5:04 PM, Kevin Rushforth wrote:

I hereby nominate Murali Billa [1] to OpenJFX Committer.

Murali is a member of JavaFX team at Oracle working on WebKit, who has 
contributed 10 changesets [5] to OpenJFX, at least 8 of which are 
significant.


Votes are due by April 14, 2016.

Only current OpenJFX Committers [2] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing 
list.


For Lazy Consensus voting instructions, see [3]. Nomination to a 
project Committer is described in [4].


Thanks,

-- Kevin

[1] http://openjdk.java.net/census#mbilla

[2] http://openjdk.java.net/census#openjfx

[3] http://openjdk.java.net/bylaws#lazy-consensus

[4] http://openjdk.java.net/projects#project-committer

[5] List of changesets:
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/a251a1d65932
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/ecea43f5734c
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/42b461505f27
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/82ecaebd44cf
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/8643ca988cef
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/765fd07f22fc
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/ae75f92d5e53
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/25db4b2e47a1
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/51c2129d282c
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/cb8a24f5db2a

Re: CFV: New OpenJFX Committer: Murali Billa

[Kevin Rushforth]

Vote: YES


Kevin Rushforth wrote:

I hereby nominate Murali Billa [1] to OpenJFX Committer.

Murali is a member of JavaFX team at Oracle working on WebKit, who has 
contributed 10 changesets [5] to OpenJFX, at least 8 of which are 
significant.


Votes are due by April 14, 2016.

Only current OpenJFX Committers [2] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing 
list.


For Lazy Consensus voting instructions, see [3]. Nomination to a 
project Committer is described in [4].


Thanks,

-- Kevin

[1] http://openjdk.java.net/census#mbilla

[2] http://openjdk.java.net/census#openjfx

[3] http://openjdk.java.net/bylaws#lazy-consensus

[4] http://openjdk.java.net/projects#project-committer

[5] List of changesets:
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/a251a1d65932
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/ecea43f5734c
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/42b461505f27
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/82ecaebd44cf
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/8643ca988cef
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/765fd07f22fc
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/ae75f92d5e53
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/25db4b2e47a1
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/51c2129d282c
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/cb8a24f5db2a

CFV: New OpenJFX Committer: Murali Billa

[Kevin Rushforth]

I hereby nominate Murali Billa [1] to OpenJFX Committer.

Murali is a member of JavaFX team at Oracle working on WebKit, who has 
contributed 10 changesets [5] to OpenJFX, at least 8 of which are 
significant.


Votes are due by April 14, 2016.

Only current OpenJFX Committers [2] are eligible to vote on this 
nomination. Votes must be cast in the open by replying to this mailing list.


For Lazy Consensus voting instructions, see [3]. Nomination to a project 
Committer is described in [4].


Thanks,

-- Kevin

[1] http://openjdk.java.net/census#mbilla

[2] http://openjdk.java.net/census#openjfx

[3] http://openjdk.java.net/bylaws#lazy-consensus

[4] http://openjdk.java.net/projects#project-committer

[5] List of changesets:
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/a251a1d65932
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/ecea43f5734c
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/42b461505f27
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/82ecaebd44cf
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/8643ca988cef
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/765fd07f22fc
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/ae75f92d5e53
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/25db4b2e47a1
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/51c2129d282c
http://hg.openjdk.java.net/openjfx/9-dev/rt/rev/cb8a24f5db2a

Re: Posible bug when maximizing an already maximized stage on Mac

[José Pereda]

Hi Jerome,

Your last comment is related to this open issue:
https://bugs.openjdk.java.net/browse/JDK-8087618

Jose

On Thu, Mar 31, 2016 at 12:31 PM, Jérome Cambon 
wrote:

> Hi,
>
> I can reproduce the issue as well, on both my Mac Retina display and my
> external display.
> Additional comments:
> - If one resize the window and click the maximize button several times: no
> issue
> - Once maximized, if one resize the window by only few pixels, and click
> the maximize button: nothing happen.
> - I guess the ‘maximized’ property should be set to false as soon as the
> window is resized: this is not the case.
>
> Jerome
>
>
> > On Mar 31, 2016, at 11:16 AM, José Pereda 
> wrote:
> >
> > Hi all,
> >
> > Running this little test on a MacBook Pro Retina, OS X 10.11.4, with JDK
> > 8u77:
> >
> >@Override
> >public void start(Stage stage) {
> >Button button = new Button("Click to maximize");
> >button.setOnAction(e -> stage.setMaximized(true));
> >Rectangle2D bounds = Screen.getPrimary().getVisualBounds();
> >stage.setScene(new Scene(new StackPane(button), bounds.getWidth(),
> > bounds.getHeight()));
> >stage.show();
> >}
> >
> > which shouldn't do anything at all, since the stage is already maximized,
> > turns into an iconified application, with root dimensions 0x0, stage
> > dimensions 0x22 (height of menubar), stage.isIconified() returns false,
> and
> > it can't be restored again to any visible size by any means other than
> > closing the application from the dock.
> >
> > A posible situation where this could happen: persisting and restoring the
> > properties (x, y, width, height and maximized) of a maximized stage.
> >
> >
> > I haven't found any report of this. Should I file a bug?
> >
> > Thanks,
> > Jose
> >
> > --
>
>


--

Re: Posible bug when maximizing an already maximized stage on Mac

[Jérome Cambon]

Hi,

I can reproduce the issue as well, on both my Mac Retina display and my 
external display.
Additional comments:
- If one resize the window and click the maximize button several times: no 
issue 
- Once maximized, if one resize the window by only few pixels, and click the 
maximize button: nothing happen.
- I guess the ‘maximized’ property should be set to false as soon as the window 
is resized: this is not the case.

Jerome


> On Mar 31, 2016, at 11:16 AM, José Pereda  wrote:
> 
> Hi all,
> 
> Running this little test on a MacBook Pro Retina, OS X 10.11.4, with JDK
> 8u77:
> 
>@Override
>public void start(Stage stage) {
>Button button = new Button("Click to maximize");
>button.setOnAction(e -> stage.setMaximized(true));
>Rectangle2D bounds = Screen.getPrimary().getVisualBounds();
>stage.setScene(new Scene(new StackPane(button), bounds.getWidth(),
> bounds.getHeight()));
>stage.show();
>}
> 
> which shouldn't do anything at all, since the stage is already maximized,
> turns into an iconified application, with root dimensions 0x0, stage
> dimensions 0x22 (height of menubar), stage.isIconified() returns false, and
> it can't be restored again to any visible size by any means other than
> closing the application from the dock.
> 
> A posible situation where this could happen: persisting and restoring the
> properties (x, y, width, height and maximized) of a maximized stage.
> 
> 
> I haven't found any report of this. Should I file a bug?
> 
> Thanks,
> Jose
> 
> --

Posible bug when maximizing an already maximized stage on Mac

[José Pereda]

Hi all,

Running this little test on a MacBook Pro Retina, OS X 10.11.4, with JDK
8u77:

@Override
public void start(Stage stage) {
Button button = new Button("Click to maximize");
button.setOnAction(e -> stage.setMaximized(true));
Rectangle2D bounds = Screen.getPrimary().getVisualBounds();
stage.setScene(new Scene(new StackPane(button), bounds.getWidth(),
bounds.getHeight()));
stage.show();
}

which shouldn't do anything at all, since the stage is already maximized,
turns into an iconified application, with root dimensions 0x0, stage
dimensions 0x22 (height of menubar), stage.isIconified() returns false, and
it can't be restored again to any visible size by any means other than
closing the application from the dock.

A posible situation where this could happen: persisting and restoring the
properties (x, y, width, height and maximized) of a maximized stage.


I haven't found any report of this. Should I file a bug?

Thanks,
Jose

--

Re: [9] Review request: 8091832: Provide API for getting the Screen scale on HiDPI screens

[Jim Graham]

I've updated the fix with the following additions:

http://cr.openjdk.java.net/~flar/JDK-8091832/webrev.rt.02/

- Redundant or obsolete command line overrides removed from Windows code 
as follows:

  Settings still supported:
-Dglass.win.uiScale
  Settings no longer supported, implementation conflicts with 
Per-Monitor DPI support:

-Dglass.win.minHiDPI
  Settings no longer supported, replaced by API in FX classes:
-Dglass.win.renderScale
-Dglass.win.forceIntegerRenderScale

- Font size now scales with uiScale override on Windows
- Fixes to scaling in JFXPanel
- Fixes to scaling in SwingPanel
- Monocle Screen initialization fixed

Note that SwingNode does not seem to relay the FX scaling parameters to 
Swing correctly, but that was true before these fixes. This patch will 
keep the functionality roughly the same, but additional fixes are needed 
to do proper scaling of embedded Swing nodes. I looked at what was 
needed and have an idea of what the fix would involve, but decided that 
it was outside the scope of these fixes that are needed to get the HiDPI 
FX properties implemented.


...jim

On 3/28/16 6:25 PM, Jim Graham wrote:

bug: https://bugs.openjdk.java.net/browse/JDK-8091832
webrev: http://cr.openjdk.java.net/~flar/JDK-8091832/webrev.rt.00/

This webrev fixes pixel snapping and application control over pixel
scaling on HiDPI screens:

- snap*() methods are all updated to take the current scale into account
- new variants of snap*() methods are added for separate X/Y control:
 Added: Region.snapSpaceX/Y()
 Added: Region.snapSizeX/Y()
 Added: Region.snapPositionX/Y()
- the non-X/Y variants of the above methods are now deprecated:
 Deprecated: Region.snapSpace()
 Deprecated: Region.snapSize()
 Deprecated: Region.snapPosition()
- methods to query the scale values of Screen objects:
 Added: Screen.getOutputScaleX/Y()
- properties to query and/or modify the scale values of Window objects:
 Added Read-Only  DoubleProperty:  Window.getOutputScaleX/Y()
 Added Read-Write BooleanProperty:
Window.set/getForceIntegerRenderScale()
 Added Read-Write DoubleProperty:  Window.set/getRenderScaleX/Y()

The changes have been compiled and tested on Windows and Mac and there
were trivial changes needed to the Linux files to adapt to one new
method signature, but I haven't done the test build on Linux yet...

 ...jim