Re: Code Review Request For 8155757: Encapsulate impl_ methods in animation, canvas, image, input, layout, paint, and text packages

2016-04-29 Thread Jim Graham
One comment on the implementation. For the methods used by an accessor inner class, if you make them private in the outer class then that inner class will need a hidden accessor method to be added in the bytecodes. If you make them package-private then they can access the method directly.

Code Review Request For 8155757: Encapsulate impl_ methods in animation, canvas, image, input, layout, paint, and text packages

2016-04-29 Thread Chien Yang
Hi Kevin, Please review the proposed fix: JIRA: https://bugs.openjdk.java.net/browse/JDK-8155757 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8155757/webrev.00/ Thanks, - Chien

In(Sanity) Testing Mondays

2016-04-29 Thread Vadim Pakhnushev
Reminder, Monday is our weekly sanity testing. You can find your testing assignment at: https://wiki.openjdk.java.net/display/OpenJFX/Sanity+Testing Also please remember that the repo will be locked from 1am PST until 1pm PST. Happy testing! Thanks, Vadim