Re: RFR: 8152423: Generated temp files (+JXF...temp) for custom fonts not deleted on exit.

2016-05-05 Thread Jim Graham
In that case, in order to avoid race conditions (GC could be accidentally triggered by this or subsequent shutdown hooks in the system), it should be released by calling disposer.dispose() instead of directly calling Release (still setting fontFace to null just in case). That will ensure only

Re: RFR: 8152423: Generated temp files (+JXF...temp) for custom fonts not deleted on exit.

2016-05-05 Thread Phil Race
On 05/05/2016 11:26 AM, Jim Graham wrote: Is this true of any other objects managed by DWDisposer? DWDisposer is only the class used to implement "dispose()" of a single DWFontFile that occurs during running/gc. It doesn't really "manage" anything and I don't see it used to dispose any other

Re: RFR: 8152423: Generated temp files (+JXF...temp) for custom fonts not deleted on exit.

2016-05-05 Thread Jim Graham
Is this true of any other objects managed by DWDisposer? Would it be better to simply run through the DWDisposer queue on shutdown and force it to dispose (i.e. release) everything it has? ...jim On 05/05/2016 11:12 AM, Phil Race wrote: Please review :- Bug : https://

Re: [graphics] [9] Review request for 8155903: Crash while running imported/w3c/canvas/2d.gradient.interpolate.overlap2.html

2016-05-05 Thread Jim Graham
Hi Arun, The change you made to the calculateSingleArray method looks like it produces a bad array of color stops for the case where Imin is 0. You should fall into the calculateMultipleArray method instead which should not have any trouble with zero length intervals. At that point you don'

RFR: 8152423: Generated temp files (+JXF...temp) for custom fonts not deleted on exit.

2016-05-05 Thread Phil Race
Please review :- Bug : https://bugs.openjdk.java.net/browse/JDK-8152423 Fix : http://cr.openjdk.java.net/~prr/8152423/ "Release" was not being called on the DirectWrite font object so it held a reference to the file, which on Windows prevents the fil

Re: JFX - Running with Jigsaw in development

2016-05-05 Thread Kevin Rushforth
Thanks, Dave. This is a great step forward and is a necessary piece to enable us to eventually move to a later JDK 9 for building JavaFX (we are stuck at build 109 for now). -- Kevin David Hill wrote: We have a new trick in the FX repo to help with running FX apps backed by a Jigsaw enab

Linux SwingNode focus work around?

2016-05-05 Thread Neil Brown
Hi, I recently found what seems to be a bug involving SwingNode and new windows on Linux. Essentially, when you have a SwingNode in an FX window, and show a new pure-Swing window, components in the new window will not receive focus even when clicked on, unless you focus away to another appli

JFX - Running with Jigsaw in development

2016-05-05 Thread David Hill
We have a new trick in the FX repo to help with running FX apps backed by a Jigsaw enabled build. If you build FX with JIGSAW_HOME set to a JDK 9 build later than build 110, then the Jigsaw modules will be generated. These modules can be used with -Xpatch to override the modules in JDK9. Unfo

[graphics] [9] Review request for 8155903: Crash while running imported/w3c/canvas/2d.gradient.interpolate.overlap2.html

2016-05-05 Thread Arunprasad Rajkumar
Hello Jim, Please review the below patch. JIRA: https://bugs.openjdk.java.net/browse/JDK-8155903 Webrev: http://cr.openjdk.java.net/~arajkumar/8155903/webrev.01 Issue: Divide by zero while adding multiple gradient stops at same offset. Regards, Arun