review: Rename directories under modules to exactly match the module names

2016-07-27 Thread David Hill
This is a biggie and is presented a bit not traditionally. In short, we need to rename modules/*/ to match the new JDK9 module names - javafx.* (with a few exceptions). For your review - a webrev of the actual changes needed in files to support this change. And... the script that will be

Re: [PATCH] 8088147: FXCanvas: implement custom cursors (revised)

2016-07-27 Thread Alexander Zvegintsev
Looks good to me too. -- Thanks, Alexander. On 28.07.2016 0:21, Kevin Rushforth wrote: I have reviewed and tested the latest patch on Mac, Windows, Linux. I added my approval to the JIRA. Now we just one more reviewer. Alexander Z or Sergey: are either of you able to review? -- Kevin Alex

Re: [PATCH] 8088147: FXCanvas: implement custom cursors (revised)

2016-07-27 Thread Kevin Rushforth
I have reviewed and tested the latest patch on Mac, Windows, Linux. I added my approval to the JIRA. Now we just one more reviewer. Alexander Z or Sergey: are either of you able to review? -- Kevin Alexander Nyssen wrote: Hi Kevin, sorry for that (I’m a Git guy and don’t feel very comforta

Re: [PATCH] 8088147: FXCanvas: implement custom cursors (revised)

2016-07-27 Thread Alexander Nyssen
Hi Kevin, sorry for that (I’m a Git guy and don’t feel very comfortable with Mercurial yet). I have attached a revised patch that (hopefully) provides the correct changes. Regards, Alexander > Am 27.07.2016 um 18:51 schrieb Kevin Rushforth : > > I attached the patch to the JBS issue. You h

Re: [PATCH] 8088147: FXCanvas: implement custom cursors (revised)

2016-07-27 Thread Kevin Rushforth
I attached the patch to the JBS issue. You have introduced a bug in the SWTCursorsTest.java JUnit test -- it appears to be an almost-exact copy of the manual test (including the now-incorrect class name). Also, you have inadvertently included an unwanted modification to .idea/modules.xml that s

issue number JDK-8095131 or issue number JDK-8089225

2016-07-27 Thread Sarie Chafiq
I have resolved the problem doing this : In my fxml file: The tab that should contains my tableView In java ScrollPane sc

[9] Review request for 8089755: AreaChart area color change when series is removed

2016-07-27 Thread Vadim Pakhnushev
Jonathan, Could you please review the fix: https://bugs.openjdk.java.net/browse/JDK-8089755 http://cr.openjdk.java.net/~vadim/8089755/webrev.00/ Thanks, Vadim