[9] Code Review Request For 8130675:Document that setting scene on stage changes stage size unless explicitly set

2016-08-15 Thread Chien Yang
Hi Kevin, Please review this proposed doc fix: JIRA:https://bugs.openjdk.java.net/browse/JDK-8130675 Webrev: http://cr.openjdk.java.net/~ckyang/JDK-8130675/webrev.00/ Thanks, - Chien

Re: [PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.

2016-08-15 Thread Kevin Rushforth
The 2016-08-12 revision looks fine to me, except for a missing space as noted in JBS (no need for a new patch if that is the only issue found). While we wait for approval from the JDK 9 release team, we need another reviewer for this. Alexander Z: can you take a look? -- Kevin Alexander

Re: [PATCH] 8161282: FXCanvas does not forward horizontal mouse scroll events to the embedded scene

2016-08-15 Thread Kevin Rushforth
OK, I'll upload this revised version of the patch today. -- Kevin Alexander Nyssen wrote: Hi Kevin, please consider the following updated patch instead, which contains an additional null-check. Regards Alexander

Re: [PATCH] 8161282: FXCanvas does not forward horizontal mouse scroll events to the embedded scene

2016-08-15 Thread Alexander Nyssen
Hi Kevin, please consider the following updated patch instead, which contains an additional null-check. Regards Alexander > Am 12.08.2016 um 16:04 schrieb Alexander Nyssen : > > Hi Kevin, > > attached please find an initial patch for >

Re: Structuring CSS Stylesheets

2016-08-15 Thread Kevin Rushforth
One slight correction on how to contribute below. David Grieve wrote: On 8/15/16 10:52 AM, Daniel Glöckner wrote: We found the culprits by patching the JRE, adding some statistics to SimpleSelector and CompoundSelector. I was wondering whether there are easier ways but anyway, it works ;)

Re: Structuring CSS Stylesheets

2016-08-15 Thread David Grieve
On 8/15/16 10:52 AM, Daniel Glöckner wrote: We found the culprits by patching the JRE, adding some statistics to SimpleSelector and CompoundSelector. I was wondering whether there are easier ways but anyway, it works ;) This sounds like some code that would be good to share with the

Focus Traversal of Nodes / Cells in TreeTableView

2016-08-15 Thread Daniel Glöckner
Hi, We're trying to implement an editable data grid using a TreeTableView. The tree table contains nodes: List> columns = ...; theTreeTable.getColumns().setAll(columns); Some of the nodes are custom controls (basically advanced text fields) which are editable:

RE: Structuring CSS Stylesheets

2016-08-15 Thread Daniel Glöckner
Hi, Thanks a lot for your comments, David. > -Original Message- > From: openjfx-dev [mailto:openjfx-dev-boun...@openjdk.java.net] On Behalf > Of David Grieve > Sent: Monday, August 15, 2016 4:35 PM > To: openjfx-dev@openjdk.java.net > Subject: Re: Structuring CSS Stylesheets > > > >

Re: Structuring CSS Stylesheets

2016-08-15 Thread David Grieve
On 8/15/16 9:46 AM, Daniel Glöckner wrote: Hi, We recently came across a number of performance issues which were caused by our poor CSS. Our stylesheet contained too many selectors, specifically too many generic selectors targeting "common" JavaFX controls (.text, .label etc.). Make the

Structuring CSS Stylesheets

2016-08-15 Thread Daniel Glöckner
Hi, We recently came across a number of performance issues which were caused by our poor CSS. Our stylesheet contained too many selectors, specifically too many generic selectors targeting "common" JavaFX controls (.text, .label etc.). We found the culprits by patching the JRE, adding some