[9] Review Request: 8155956 Java Packager runtime argument

2016-08-24 Thread Chris Bensen
Kevin,

Please review change for Java Packager runtime argument and a few other minor 
changes.

Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8155956/webrev.00/
JIRA: https://bugs.openjdk.java.net/browse/JDK-8155956

Chris

Re: Playing a sound at regular intervals

2016-08-24 Thread David DeHaven

I see no reason for that, I'll clean it up and make it public.

-DrD-

> FYI... This issue is not visible to me 
> https://bugs.openjdk.java.net/browse/JDK-8090414
> 
> 
> Scott
> 
>> On Aug 23, 2016, at 10:15 AM, David DeHaven  wrote:
>> 
>> 
>>> We're trying to play a notification sound at a regular interval (every 
>>> 500ms) in a loop.
>>> 
>>> It should sound like "bing.bing.bing." and not like 
>>> "bing..bing..bing...bing" if you know what I mean ;)
>>> 
>>> From the JavaDoc we were guessing that an efficient way to do this would be 
>>> to set cycle count to indefinite on the audio clip / on the media player 
>>> and call play() once.
>>> 
>>> Observations:
>>> - Cycle count doesn't work for mp3 files. No problem, just use WAV.
>>> - The playback does not happen at regular intervals. -> not usable in this 
>>> scenario
>>> 
>>> Our solution so far has been to have a scheduled executor which calls 
>>> audioclip.play() every 500 ms. This creates a new thread every time (see 
>>> stack trace below) and we don't like this approach.
>> 
>> For the moment this is a better solution, until we can get a few internal 
>> things fixed in AudioClip.
>> 
>> In the current implementation there will always be at least one new thread 
>> created.
>> 
>> 
>> There are bugs filed on this already, specifically:
>> https://bugs.openjdk.java.net/browse/JDK-8090414
>> https://bugs.openjdk.java.net/browse/JDK-8087423
>> 
>> And possibly related:
>> https://bugs.openjdk.java.net/browse/JDK-8088375
>> 
>> -DrD-
>> 



[9] Review request for 8162979: Website weibo.com cannot be loaded

2016-08-24 Thread Murali Billa
 

Hi Kevin, Arun, Guru,


Please review the following fix.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8162979


Webrev: http://cr.openjdk.java.net/~mbilla/8162979/webrev.00/

 



Thanks,

Murali


RE: Playing a sound at regular intervals

2016-08-24 Thread Daniel Glöckner
Hi,

Thanks for the explanation.

For now we'll use AudioInputStream / Clip from javax.sound.sampled which seems 
wo work nicely for WAV clips.

That API also offers continuous playback but without strange delays ;)

Kind regards,
Daniel

> -Original Message-
> From: David DeHaven [mailto:david.deha...@oracle.com]
> Sent: Tuesday, August 23, 2016 4:16 PM
> To: Daniel Glöckner
> Cc: openjfx-dev@openjdk.java.net
> Subject: Re: Playing a sound at regular intervals
> 
> 
> > We're trying to play a notification sound at a regular interval (every 
> > 500ms)
> in a loop.
> >
> > It should sound like "bing.bing.bing." and not like 
> > "bing..bing..bing...bing" if
> you know what I mean ;)
> >
> > From the JavaDoc we were guessing that an efficient way to do this would be
> to set cycle count to indefinite on the audio clip / on the media player and 
> call
> play() once.
> >
> > Observations:
> > - Cycle count doesn't work for mp3 files. No problem, just use WAV.
> > - The playback does not happen at regular intervals. -> not usable in this
> scenario
> >
> > Our solution so far has been to have a scheduled executor which calls
> audioclip.play() every 500 ms. This creates a new thread every time (see stack
> trace below) and we don't like this approach.
> 
> For the moment this is a better solution, until we can get a few internal 
> things
> fixed in AudioClip.
> 
> In the current implementation there will always be at least one new thread
> created.
> 
> 
> There are bugs filed on this already, specifically:
> https://bugs.openjdk.java.net/browse/JDK-8090414
> https://bugs.openjdk.java.net/browse/JDK-8087423
> 
> And possibly related:
> https://bugs.openjdk.java.net/browse/JDK-8088375
> 
> -DrD-