Re: [PATCH] 8161282: FXCanvas does not forward horizontal mouse scroll events to the embedded scene

[Kevin Rushforth]

Approved, assuming the changes to the wild-import are done by Alexander 
along with a correctly formatted changeset commit message.


-- Kevin


Kevin Rushforth wrote:

Uploaded the new version.

Alexander Zvegintsev will sponsor this patch, and I will review it.

My one quick comment -- in addition to the wild-card imports which 
Alexander Z caught, and said he would take care of -- is that the 
format of the commit message is not quite right. See the following 
page for formatting rules on the changeset commit message:


http://openjdk.java.net/guide/producingChangeset.html

Thanks.

-- Kevin



Alexander Nyssen wrote:
You might even take the one I attached. I just recognized I still had 
some unused imports in the manual test case (I am still not familiar 
with IntelliJ).


Regards,
Alexander





Am 15.08.2016 um 19:26 schrieb Kevin Rushforth 
>:


OK, I'll upload this revised version of the patch today.

-- Kevin


Alexander Nyssen wrote:

Hi Kevin,

please consider the following updated patch instead, which contains 
an additional null-check.


Regards
Alexander


 




Am 12.08.2016 um 16:04 schrieb Alexander Nyssen 
>:


Hi Kevin,

attached please find an initial patch for 
https://bugs.openjdk.java.net/browse/JDK-8161282.


The patch is not as minimal as I had hoped, as the 
EmbeddedSceneInterface had to be changed to differentiate between 
mouse and scroll events (while up to now, scroll events are 
handled as mouse events), but for me this seemed necessary to fix 
this issue properly. As a result, JFXPanel had to be adjusted as 
well to comply to the changes in the EmbeddedSceneInterface, while 
its behavior should not have changed.


As horizontal mouse events cannot be synthesized via 
Display.post(Event) yet (an open issue for SWT), I did not add an 
automated test, but instead added a manual one 
(FXCanvasMouseWheelEventsTest). Therefore, this patch does not 
depend on the patch I provided earlier for JDK-8160325.


Best Regards,
Alexander






=


=

[9] Review Request: 8165548 javapackager -help shows --modulepath not --module-path

[Chris Bensen]

Kevin,

Please review this simple string change.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8165548
Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8165548/webrev.00/

Chris

Re: [9] Review request for 8090176: Pisces software renderer shows incomplete border images in particular situation

[Jim Graham]

There is now an updated fix that addresses a potential performance loss when simple 1:1 blits were accidentally getting 
redirected through interpolate-per-pixel code by the first fix...


http://cr.openjdk.java.net/~flar/JDK-8090176/webrev.9u.02/

...jim

On 9/2/16 12:24 PM, Jim Graham wrote:

JBS: https://bugs.openjdk.java.net/browse/JDK-8090176
webrev for 9u: http://cr.openjdk.java.net/~flar/JDK-8090176/webrev.9u.01/

The webrev is prepared for 8u, but I will be holding off on submitting that for 
backport review until the fix has baked
in the 9u-dev repo for a couple of weeks...

...jim