[9] Review request for 8167175: JFX MediaPlayer Leaks Native Memory in Windows

2016-11-02 Thread Alexander Matveev
Hi David, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8167175 Fixed several memory leaks. Thanks, Alexander

Re: Fwd: Re: Marlin-Renderer and JavaFX

2016-11-02 Thread Sergey Bylokhov
Probably the logging should be enabled only if we pass the upper case "True" to "-Dsun.javafx.marlin=True". I do not know is it correct to write to the system output unconditionally, can this affect application? And instead of "sun." can we use something different like "jdk." I guess the same q

Re: JavaFX 9: Expose PlatformImpl.runAndWait() as Platform.runAndWait()

2016-11-02 Thread Tom Schindl
e(fx)clipse also uses FutureTask - we initially used CountDownLatch but it escapes my mind what was the reason for that change. BTW: We have many other clever util methods in this area - see - http://git.eclipse.org/c/efxclipse/org.eclipse.efxclipse.git/tree/bundles/runtime/org.eclipse.fx.ui.wo

Re: JavaFX 9: Expose PlatformImpl.runAndWait() as Platform.runAndWait()

2016-11-02 Thread Herve Girod
We have a use case where we receive a LOT of processing orders in one Thread in a TCP socket and we have to perform the drawing in the JavaFX Thread, but also we must wait until the effective drawing has finished before ordering a new drawing (because otherwise some parameters could have changed in

Re: Fwd: Re: Marlin-Renderer and JavaFX

2016-11-02 Thread Laurent Bourgès
Jim, Here is an updated patch for MarlinFX: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-s02-ofx9/ I made big improvements: MarlinFX is now "feature-complete": - Added MarlinAlphaConsumer & MarlinRenderer interfaces to define new methods on AlphaConsumer and common methods between AA &

Re: JavaFX 9: Expose PlatformImpl.runAndWait() as Platform.runAndWait()

2016-11-02 Thread Kevin Rushforth
We use runAndWait (using a CountDownLatch) in many of our unit tests. You might take a look at: tests/system/src/test/java/test/util/Util.java Its runAndWait method also handles propagating runtime exceptions and errors (e.g., assertion failures) from the body of the runAndWait back to the ca

Re: JavaFX 9: Expose PlatformImpl.runAndWait() as Platform.runAndWait()

2016-11-02 Thread Benjamin Gudehus
I wonder, if it is possible to test JavaFX applications without blocking the main thread. User interactions could be completely simulated by using Event.fireEvent(...) and we could enqueue assertions in the JavaFX application thread, in which case the assertion library needs to support asynchronous

Re: JavaFX 9: Expose PlatformImpl.runAndWait() as Platform.runAndWait()

2016-11-02 Thread Stefan Fuchs
Hi, in my experience blocking your working thread for the JavaFX application thread is almost always a sign of bad application design. You can easily deadlock your application. In our quite complex JavaFX Application, we could eliminate almost all of its uses. However, in one case it is still

Re: Review: Switch to Jigsaw-aware boot JDK for compiling FX 9

2016-11-02 Thread David Hill
On 11/2/16, 1:01 PM, Phil Race wrote: Updated with your suggestion, moved the obvious hot spots to the top. David, I generally make the following request of "large" reviews : One thing that would help a lot here is if the "important" files were at the top rather than buried due to lexical sort

Re: Review: Switch to Jigsaw-aware boot JDK for compiling FX 9

2016-11-02 Thread Phil Race
David, I generally make the following request of "large" reviews : One thing that would help a lot here is if the "important" files were at the top rather than buried due to lexical sorting by path name. In particular files like build.gradle and so on .. people then get a sense of what it is

Review: Switch to Jigsaw-aware boot JDK for compiling FX 9

2016-11-02 Thread David Hill
JBS: https://bugs.openjdk.java.net/browse/JDK-8161704 Webrev: http://cr.openjdk.java.net/~ddhill/8161704/ Kevin, Chien, Vadim, There is a lot of change in this webrev, but there are a lot of common patterns (or sets of changes) ./apps - the majority of the change is altering the NB project fi

Re: JavaFX 9: Expose PlatformImpl.runAndWait() as Platform.runAndWait()

2016-11-02 Thread Benjamin Gudehus
Hi, Kevin. Thanks for the info! On Wed, Nov 2, 2016 at 5:36 PM, Kevin Rushforth wrote: > No. This isn't something we will do for JDK 9, which is feature complete > (with an exception process for critical requests, especially relating to > Jigsaw). I note in this case that it isn't clear whether

Re: JavaFX 9: Expose PlatformImpl.runAndWait() as Platform.runAndWait()

2016-11-02 Thread Kevin Rushforth
No. This isn't something we will do for JDK 9, which is feature complete (with an exception process for critical requests, especially relating to Jigsaw). I note in this case that it isn't clear whether we want to do this one at all. -- Kevin Benjamin Gudehus wrote: Hey! Are there plans to

JavaFX 9: Expose PlatformImpl.runAndWait() as Platform.runAndWait()

2016-11-02 Thread Benjamin Gudehus
Hey! Are there plans to expose this API [1] in JavaFX 9? // NOTE: Add the following if we decide to expose it publicly // public static void runAndWait(Runnable runnable) { // PlatformImpl.runAndWait(runnable); // } [1] http://hg.openjdk.java.net/openjfx/9-dev/rt/file/ 6edd0c3c01f4/modules/javaf

Re: Occasional Canvas Error (stacktrace)

2016-11-02 Thread David Gilbert
I had something similar reported for JFreeChart running on JavaFX - see this thread: http://www.jfree.org/forum/viewtopic.php?f=3&t=117577 In the end it seems to have been caused by UI calls coming from another thread, so you should check if your code is doing this. Best regards, David Gilber