Re: Review request for 8169294:

2016-11-07 Thread Jim Graham
On 11/7/2016 1:14 PM, Laurent Bourgès wrote: The only difference in Path2D.java I noted is that the Java2D version has an EXPAND_MIN which is 10, but you re-use INIT_SIZE, which is 20, here for the same purpose. You're right; I think I didn't want to add an extra constant but if you prefer

Re: Fwd: Re: Marlin-Renderer and JavaFX

2016-11-07 Thread Laurent Bourgès
Jim, Here is the new patch: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-s02-ofx9.3/ Changes: - cleanup wrt OpenJDK9 (Unsafe is OK but I switch to the standard Cleaner) - modified PrismSettings as recommended and renamed all Marlin properties to use the prefix 'prism.marlin' -

Re: Review request for 8169294:

2016-11-07 Thread Kevin Rushforth
I'll review the test tomorrow (I'm a little backed up on my code reviews given the impending change to build with jigsaw JDK). -- Kevin Laurent Bourgès wrote: Jim, 2016-11-07 21:05 GMT+01:00 Jim Graham >: I'd like to see Kevin

RFR: 8088325 & 8169339 : Provide internal JDK API to JavaFX to locate JDK fonts

2016-11-07 Thread Phil Race
Hi, Two bug ids, two webrevs and a cross-post since JDK needs to provide a qualified export to JavaFX so it can access any fonts that may be provided with the JDK. FX bug: https://bugs.openjdk.java.net/browse/JDK-8088325 FX fix : http://cr.openjdk.java.net/~prr/8088325/

Re: Review request for 8169294:

2016-11-07 Thread Laurent Bourgès
Jim, 2016-11-07 21:05 GMT+01:00 Jim Graham : > I'd like to see Kevin review the test as I'm not the best expert on our > JUnit framework. > I just added @Test annotations and kept the jtreg tags in header (for information). I could add asserts but JUnit does intercept

Re: Review request for 8169294:

2016-11-07 Thread Jim Graham
I'd like to see Kevin review the test as I'm not the best expert on our JUnit framework. It looks like it is mostly just going to emit some printouts about performance (using echo() and log()) and verify that we don't get any ArrayBounds related exceptions (or worse, OOME)? The only

Re: Issues porting to Monocle EPD platform

2016-11-07 Thread David Hill
On 11/7/16, 12:55 PM, John Neffenger wrote: Hi John, I am probably the guy that will be looking over these, but I am in the middle of a big push. Feel free to ping me offline if I don't get back to you by early next week. Dave While porting OpenJFX to devices with an electronic paper

Issues porting to Monocle EPD platform

2016-11-07 Thread John Neffenger
While porting OpenJFX to devices with an electronic paper display, I resolved three issues in the graphics module that I thought I should pass along. The following merge request on GitLab lists the issues and my minor changes. See the Commits and Changes tabs in the middle of the page for

Re: [webkit] [9] Review request for 8088205: [Mac] WebView renders icons instead of letters on some sites

2016-11-07 Thread Arunprasad Rajkumar
Hello Kevin, Phil, I have incorporated review comments, Please take a look. http://cr.openjdk.java.net/~arajkumar/8088205/webrev.01/ Thanks, Arun > On 04-Oct-2016, at 12:15 AM, Arunprasad Rajkumar >

Heads up: Modular build is close.....

2016-11-07 Thread David Hill
The new modular build is close... ! The plan is for me to push the change set around 10 EST (7PST) on Tuesday. This way we have much of the week to respond to disruptions. Unlike one of my previous changes, there should be less disruption (less moved files, did not change buildSrc). BUT ...

Re: [Alpine Linux][amd64][JDK8] Build :graphics:compileDecoraNativeShadersLinux FAILED

2016-11-07 Thread Kevin Rushforth
The NPE is a known issue with antlr that happens on all platforms and is unrelated to your gcc error. -- Kevin d...@libertysurf.fr wrote: No, I did not install any new packages after the first build failure. In fact, I am building the javafx in a docker container restarting from the

[9] Review request for 8169309: Migrate SwingNode to the new float API of JLightweightFrame

2016-11-07 Thread Semyon Sadetsky
Hello Kevin & Jim, Please review the fix for jfx9: webrev: http://cr.openjdk.java.net/~ssadetsky/8169309/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8153522 --Semyon