[9] Review request:

[Chris Bensen]

Victor,

Please review this change to provide a warning with suggested work arounds when 
packaging on Windows 10 with Windows Defender enabled.

JIRA: https://bugs.openjdk.java.net/browse/JDK-8172444 

Webrev: http://cr.openjdk.java.net/~cbensen/JDK-8172444/webrev.01/ 


Chris

Problems building JavaFX with jdk-9+153

[Kevin Rushforth]

We recently discovered a javac bug that prevents building JavaFX modules 
using jdk-9+153 as a boot JDK:


https://bugs.openjdk.java.net/browse/JDK-8172809

This has now been fixed, and is expected to be delivered in build 154. 
You can use build 153 to build and run JavaFX applications, but if you 
need to build JavaFX itself, you should use an earlier build of JDK 9.


-- Kevin

Re: Need an official way to exclude parts of the SceneGraph from CSS-Processing

[Kevin Rushforth]

Improving CSS performance is a big goal for JDK 10. It is very likely 
too late to do anything about this for JDK 9, but Jonathan might be able 
to comment further.


-- Kevin


Tom Schindl wrote:

Hi,

One of the biggest problems when working with JavaFX is that if you
reparent a big portion of the SceneGraph is that a full CSS-Pass is
applied on all reparented SG-Nodes even if those nodes are currently not
visible (eg. because they are part of a TabPane).

I general I think it is ok to also applyCSS changes on currently not
visible nodes (eg they still have an influence on layout-bounds) but
there are situations like the above mentioned example of TabPane that it
is unnecessary overhead to apply applyCSS changes on those parts of the
SG until they get visible.

I would not mind if the CSS-Pass on JavaFX would be as performant as the
one from current browsers but unfortunately it isn't so I'd like to
discuss the possibility of a API to *temporarily* exclude portions of
the SG from CSS-Passes.

In JavaFX8 i was able to hack that in by overwriting impl_processCSS in
a subclass who changed to doProcessCSS who now is private so my hack
does not work anymore.

To give you an impression on what performance gains we are talking about
just look at the video I recorded -
https://tomsondev.bestsolution.at/2016/11/25/improving-minmax-performance-in-e4-on-javafx-applications/

Tom

  

Re: Impossible to implement custom control with a StyleableObjectProperty on JavaFX9

[Kevin Rushforth]

Hi Tom,

As that bug is Resolved/Fixed (with a pushed changeset) we will need a 
new JBS bug to track any additional changes that might be needed.


Thanks.

-- Kevin


Tom Schindl wrote:

https://bugs.openjdk.java.net/browse/JDK-8102126

Tom

On 19.01.17 00:09, Jonathan Giles wrote:
  

This sounds like a reasonable issue to discuss a resolution for. Can you
please file a Jira issue and we can look into our options (either making
a reapplyCss() method available, or following something along the lines
of your suggestion)?

Also, thanks for taking the time to test JDK 9 - this is exactly the
kind of feedback we need.

-- Jonathan

On 19/01/17 12:00 PM, Tom Schindl wrote:


Hi,

As JavaFX9 has removed impl_reapplyCss() it is impossible for custom
controls to deal with a styleable Font-Property.

To correctly implement a Font-Property the code needs to look similar to
the one in Labeled#fontProperty. The only possibility I see implementing
such a property without providing reapplyCss() to the public is to
provide a correct implementation as part of StyleablePropertyFactory.

Tom

  



  

Need an official way to exclude parts of the SceneGraph from CSS-Processing

[Tom Schindl]

Hi,

One of the biggest problems when working with JavaFX is that if you
reparent a big portion of the SceneGraph is that a full CSS-Pass is
applied on all reparented SG-Nodes even if those nodes are currently not
visible (eg. because they are part of a TabPane).

I general I think it is ok to also applyCSS changes on currently not
visible nodes (eg they still have an influence on layout-bounds) but
there are situations like the above mentioned example of TabPane that it
is unnecessary overhead to apply applyCSS changes on those parts of the
SG until they get visible.

I would not mind if the CSS-Pass on JavaFX would be as performant as the
one from current browsers but unfortunately it isn't so I'd like to
discuss the possibility of a API to *temporarily* exclude portions of
the SG from CSS-Passes.

In JavaFX8 i was able to hack that in by overwriting impl_processCSS in
a subclass who changed to doProcessCSS who now is private so my hack
does not work anymore.

To give you an impression on what performance gains we are talking about
just look at the video I recorded -
https://tomsondev.bestsolution.at/2016/11/25/improving-minmax-performance-in-e4-on-javafx-applications/

Tom

-- 
Thomas Schindl, CTO
BestSolution.at EDV Systemhaus GmbH
Eduard-Bodem-Gasse 5-7, A-6020 Innsbruck
http://www.bestsolution.at/
Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck

Re: Impossible to implement custom control with a StyleableObjectProperty on JavaFX9

[Tom Schindl]

In a similar vein a property like Labeled#graphicProperty - see
https://bugs.openjdk.java.net/browse/JDK-8173106 who can not be
implemented on JDK9 at all.

Tom

On 20.01.17 09:23, Tom Schindl wrote:
> Hi,
> 
> naturally it is https://bugs.openjdk.java.net/browse/JDK-8173103
> 
> Tom
> 
> On 20.01.17 09:16, Tom Schindl wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8102126
>>
>> Tom
>>
>> On 19.01.17 00:09, Jonathan Giles wrote:
>>> This sounds like a reasonable issue to discuss a resolution for. Can you
>>> please file a Jira issue and we can look into our options (either making
>>> a reapplyCss() method available, or following something along the lines
>>> of your suggestion)?
>>>
>>> Also, thanks for taking the time to test JDK 9 - this is exactly the
>>> kind of feedback we need.
>>>
>>> -- Jonathan
>>>
>>> On 19/01/17 12:00 PM, Tom Schindl wrote:
 Hi,

 As JavaFX9 has removed impl_reapplyCss() it is impossible for custom
 controls to deal with a styleable Font-Property.

 To correctly implement a Font-Property the code needs to look similar to
 the one in Labeled#fontProperty. The only possibility I see implementing
 such a property without providing reapplyCss() to the public is to
 provide a correct implementation as part of StyleablePropertyFactory.

 Tom

>>>
>>
>>
> 
> 


-- 
Thomas Schindl, CTO
BestSolution.at EDV Systemhaus GmbH
Eduard-Bodem-Gasse 5-7, A-6020 Innsbruck
http://www.bestsolution.at/
Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck

Re: Impossible to implement custom control with a StyleableObjectProperty on JavaFX9

[Tom Schindl]

Hi,

naturally it is https://bugs.openjdk.java.net/browse/JDK-8173103

Tom

On 20.01.17 09:16, Tom Schindl wrote:
> https://bugs.openjdk.java.net/browse/JDK-8102126
> 
> Tom
> 
> On 19.01.17 00:09, Jonathan Giles wrote:
>> This sounds like a reasonable issue to discuss a resolution for. Can you
>> please file a Jira issue and we can look into our options (either making
>> a reapplyCss() method available, or following something along the lines
>> of your suggestion)?
>>
>> Also, thanks for taking the time to test JDK 9 - this is exactly the
>> kind of feedback we need.
>>
>> -- Jonathan
>>
>> On 19/01/17 12:00 PM, Tom Schindl wrote:
>>> Hi,
>>>
>>> As JavaFX9 has removed impl_reapplyCss() it is impossible for custom
>>> controls to deal with a styleable Font-Property.
>>>
>>> To correctly implement a Font-Property the code needs to look similar to
>>> the one in Labeled#fontProperty. The only possibility I see implementing
>>> such a property without providing reapplyCss() to the public is to
>>> provide a correct implementation as part of StyleablePropertyFactory.
>>>
>>> Tom
>>>
>>
> 
> 


-- 
Thomas Schindl, CTO
BestSolution.at EDV Systemhaus GmbH
Eduard-Bodem-Gasse 5-7, A-6020 Innsbruck
http://www.bestsolution.at/
Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck

Re: Impossible to implement custom control with a StyleableObjectProperty on JavaFX9

[Tom Schindl]

https://bugs.openjdk.java.net/browse/JDK-8102126

Tom

On 19.01.17 00:09, Jonathan Giles wrote:
> This sounds like a reasonable issue to discuss a resolution for. Can you
> please file a Jira issue and we can look into our options (either making
> a reapplyCss() method available, or following something along the lines
> of your suggestion)?
> 
> Also, thanks for taking the time to test JDK 9 - this is exactly the
> kind of feedback we need.
> 
> -- Jonathan
> 
> On 19/01/17 12:00 PM, Tom Schindl wrote:
>> Hi,
>>
>> As JavaFX9 has removed impl_reapplyCss() it is impossible for custom
>> controls to deal with a styleable Font-Property.
>>
>> To correctly implement a Font-Property the code needs to look similar to
>> the one in Labeled#fontProperty. The only possibility I see implementing
>> such a property without providing reapplyCss() to the public is to
>> provide a correct implementation as part of StyleablePropertyFactory.
>>
>> Tom
>>
> 


-- 
Thomas Schindl, CTO
BestSolution.at EDV Systemhaus GmbH
Eduard-Bodem-Gasse 5-7, A-6020 Innsbruck
http://www.bestsolution.at/
Reg. Nr. FN 222302s am Firmenbuchgericht Innsbruck