Re: [9] Review request: 8180040: Exclude jdk.packager module from unified JDK 9 docs

2017-05-09 Thread Mandy Chung
> On May 9, 2017, at 6:52 PM, Kevin Rushforth > wrote: > > Thanks for the review. We currently don't use package-info.java anywhere, but > I can file a separate bug for converting all of our package.html to > package-info.java. That’d be good. > I can add the

Re: [9] Review request: 8180040: Exclude jdk.packager module from unified JDK 9 docs

2017-05-09 Thread Kevin Rushforth
Thanks for the review. We currently don't use package-info.java anywhere, but I can file a separate bug for converting all of our package.html to package-info.java. I can add the the missing copyright headers at the same time. -- Kevin Mandy Chung wrote: On May 9, 2017, at 6:08 PM, Kevin

Re: [9] Review request: 8180040: Exclude jdk.packager module from unified JDK 9 docs

2017-05-09 Thread Mandy Chung
> On May 9, 2017, at 6:08 PM, Kevin Rushforth > wrote: > > Please review the following to exclude jdk.packager module from the JDK docs > bundle: > > https://bugs.openjdk.java.net/browse/JDK-8180040 > http://cr.openjdk.java.net/~kcr/8180040/webrev.00/ > > I also

Re: [9] Review request: 8180040: Exclude jdk.packager module from unified JDK 9 docs

2017-05-09 Thread Erik Joelsson
Looks ok to me. /Erik On 2017-05-09 18:08, Kevin Rushforth wrote: Please review the following to exclude jdk.packager module from the JDK docs bundle: https://bugs.openjdk.java.net/browse/JDK-8180040 http://cr.openjdk.java.net/~kcr/8180040/webrev.00/ I also added a missing package

Re: [9] Review request: 8177566: FX user module gets IllegalAccessException from sun.reflect.misc.Trampoline

2017-05-09 Thread Kevin Rushforth
inline Peter Levart wrote: Hi Kevin, On 05/02/2017 02:21 AM, Kevin Rushforth wrote: This review is being cross-posted to both openjfx-dev and jigsaw-dev. Please review the proposed fix for: https://bugs.openjdk.java.net/browse/JDK-8177566

[10] Review request: JDK-8179946 - Objects are not rendered for certain rotation angle and cache hint combinations

2017-05-09 Thread Jim Graham
JBS: https://bugs.openjdk.java.net/browse/JDK-8179946 webrev: http://cr.openjdk.java.net/~flar/JDK-8179946/webrev.00/ This should get back-ported to 9 as well, as soon as makes sense... ...jim

[9] Review request: 8180040: Exclude jdk.packager module from unified JDK 9 docs

2017-05-09 Thread Kevin Rushforth
Please review the following to exclude jdk.packager module from the JDK docs bundle: https://bugs.openjdk.java.net/browse/JDK-8180040 http://cr.openjdk.java.net/~kcr/8180040/webrev.00/ I also added a missing package description for the jdk.packager.services package (in the

8089230: Mac: Window.maximize(false) won't restore a window into its original rectangle

2017-05-09 Thread Avik Niyogi
> Begin forwarded message: > > From: Avik Niyogi > Subject: 8089230: Mac: Window.maximize(false) won't restore a window into its > original rectangle > Date: 9 May 2017 2:35:39 pm IST > To: David Hill , Kevin Rushforth >