Re: [10] RFR: JDK-8133329: Drag and Drop of files in a SwingNode fails

[Jim Graham]

This looks good... +1

...jim

On 8/3/17 9:20 PM, Prasanta Sadhukhan wrote:



On 8/4/2017 2:57 AM, Jim Graham wrote:

I noticed a "FIXME" comment in there.  Didn't we do a pass a while back and 
convert all of them into JBS entries?

The new code simply repeats what was done for the existing Exception which is what has the "FIXME" comment so I would 
use this opportunity to upgrade that FIXME into an actual bug entry.


Also, perhaps we could use the multi-catch syntax here instead of creating a 
new catch?


Ok. I have put it as a mult-catch in this webrev
http://cr.openjdk.java.net/~psadhukhan/fx/8133329/webrev.01/

Regards
Prasanta

...jim

On 8/3/17 2:01 AM, Prasanta Sadhukhan wrote:

Hi All,

Please review a fix
http://cr.openjdk.java.net/~psadhukhan/fx/8133329/webrev.00/
for issue
https://bugs.openjdk.java.net/browse/JDK-8133329
More information in JBS.

Regards
Prasanta

Re: Skin fields visibility changed from protected to no modifier in Java9

[Jonathan Giles]

I can appreciate your desire to have more access to skin internals. As I 
was going through JEP 253 to make these APIs public I tried to be as 
clear as possible - at conferences, on openjfx-dev, via Twitter, etc - 
that developers urgently need to tell me what they want, as I couldn't 
just do a bulk copy/paste of existing skin code into public API. In 
cases where developers did communicate their requirements, I tried my 
best to accommodate these requirements into JDK 9.


JDK 9 is now no longer my focus, but the next JDK release is, and so, as 
always, I encourage people to get their requests in early while we still 
have an open feature development window. JBS is the right place for 
these reports.


The same goes for access to modena resources. We simply need to know the 
issues being experienced and we will try our best to make them go away 
in instances where they prevent some valid use case from being possible. 
This means bug reports into JBS.


-- Jonathan

On 5/08/17 2:32 AM, Wolfgang Zitzelsberger wrote:
In some Skins (e.g. MenuButtonSkinBar, TabPaneSkin, TextFieldSkin) the 
visibility of protected fields has been changed so they can't be 
accessed any longer without reflection. Skin classes are public in 
Java 9, that's fine - however, limiting visibility makes things even 
worse. Because of Jigsaw a user is now forced to add related 
"-add-opens" arguments.


Additionally, there is no way to access Modena resources because the 
package is not opened - see also 
https://stackoverflow.com/questions/45414557/modena-css-resource-loading-fails-on-java-9


I wonder why you are that restrictive?

- Wolfgang

Skin fields visibility changed from protected to no modifier in Java9

[Wolfgang Zitzelsberger]

In some Skins (e.g. MenuButtonSkinBar, TabPaneSkin, TextFieldSkin) the 
visibility of protected fields has been changed so they can't be 
accessed any longer without reflection. Skin classes are public in Java 
9, that's fine - however, limiting visibility makes things even worse. 
Because of Jigsaw a user is now forced to add related "-add-opens" 
arguments.


Additionally, there is no way to access Modena resources because the 
package is not opened - see also 
https://stackoverflow.com/questions/45414557/modena-css-resource-loading-fails-on-java-9


I wonder why you are that restrictive?

- Wolfgang

Review Request 8176813: Mac: Failure to exit full-screen programmatically in some cases

[Avik Niyogi]

Please review the webrev below which tries to fix the issue of GetApplication 
processed for Null values. Any alternatives or suggestions are welcome. This 
fixes the issue presented by the description.
https://bugs.openjdk.java.net/browse/JDK-8176813 

http://cr.openjdk.java.net/~aniyogi/8176813/webrev.00/ 

With Regards,
Avik Niyogi