Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

2017-09-22 Thread Sergey Bylokhov
Hi, Alexander. How can we be sure that the parent frame will not be disposed while we use a pointer? long ownerWindowPtr = peer.getOverridenWindowHandle(); < Dispose the peer if (ownerWindowPtr != 0) { //Place window above JavaFX stage CWrapper.NSWindow.addChildWindow( ownerWind

Re: [10] RFR JDK-8088132:[Swing, singleThread] ClassCastException in nested event loop when showing multiple message dialogs in SwingNode

2017-09-22 Thread Sergey Bylokhov
Hi, Prasanta. On 9/19/17 22:26, Prasanta Sadhukhan wrote: Hi, Prasanta.  - In this version it is unclear what is a purpose of the "fxCheckSequenceThread.start()". This code will start the thread and will continue execution, it will not wait when the thread will stop.  - The DefaultKeyboardFocu

Re: OpenJFX initiative

2017-09-22 Thread John-Val Rose
Probably, but JEPs can take a lot of time from start to finish and time is itself perhaps the biggest enemy that JavaFX is facing. And how many JEPs are being initiated by the Oracle JavaFX team themselves? I mean for the specific purpose of *true* innovation? On 23 September 2017 at 10:24, Nir

Re: OpenJFX initiative

2017-09-22 Thread Nir Lisker
I don't have any answer to those questions. A JEP is the only thing I can think of. On Sat, Sep 23, 2017 at 3:19 AM, John-Val Rose wrote: > Yes, well I'm sure there's a lot of truth to that as Johan has > demonstrated. > > But, I think it's a bit of an over simplification. > > How do I know if *

Re: OpenJFX initiative

2017-09-22 Thread John-Val Rose
Yes, well I'm sure there's a lot of truth to that as Johan has demonstrated. But, I think it's a bit of an over simplification. How do I know if *my* innovation (of say 9 months of effort) is "high-quality code that makes OpenJFX better"? I can do my best to write high-quality code but what exac

Re: OpenJFX initiative

2017-09-22 Thread Nir Lisker
> What do you mean by “go with Johan Vos’s experience”? What he said here: http://mail.openjdk.java.net/pipermail/openjfx-dev/2017-September/020801.html . On Sat, Sep 23, 2017 at 12:08 AM, John-Val Rose wrote: > The concept of “innovation” no longer seems to apply to JavaFX, at least > not from

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

2017-09-22 Thread Phil Race
I need to look more closely but at a quick glance I don't see any problems so a tentative +1 .. but a final +1 will go in the bug. Have you tested the various configurations .. running this on top of current JDK (not FX) 10 both with and without the FX changes ? -phil. On 09/21/2017 10:56 PM

Re: OpenJFX initiative

2017-09-22 Thread John-Val Rose
The concept of “innovation” no longer seems to apply to JavaFX, at least not from Oracle’s perspective. If you read the official list of changes in the just-released Java 9, AWT (yes, AWT) has more changes than JavaFX and even then the only significant change is to make it Jigsaw compatible. A

[10] JDK-8187781: "InvalidDnDOperationException: Drag and drop in progress" while running javafx application with option -Djavafx.embed.singleThread=true

2017-09-22 Thread Prasanta Sadhukhan
Hi All, Please review a fix http://cr.openjdk.java.net/~psadhukhan/fx/8187781/webrev.00/ for fx issue https://bugs.openjdk.java.net/browse/JDK-8187781 More info in JBS. Regards Prasanta

OpenJFX initiative

2017-09-22 Thread Nir Lisker
I didn't see any update on the idea for our initiative. Are we still waiting for a reply from Oracle or do we go with Johan Vos's experience? I think that the least we can do without putting any work into this is have a semi-formal list of people who would like to work on this and a list of what