Re: [10] RFR JDK-8088132:[Swing, singleThread] ClassCastException in nested event loop when showing multiple message dialogs in SwingNode

2017-09-25 Thread Sergey Bylokhov
From the AWT point of view the fix looks fine. On 9/23/17 00:03, Prasanta Sadhukhan wrote: Hi Sergey, Please find modified webrev catering to DefaultKeyboardFocusManager also http://cr.openjdk.java.net/~psadhukhan/8088132/webrev.05/ Regards Prasanta On 9/23/2017 7:52 AM, Sergey Bylokhov

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

2017-09-25 Thread Semyon Sadetsky
Hi Alexander, On the Windows platform you've only modified the dialog native peer while on other platforms all window types are modified to use FX window as a parent. Shouldn't the frame native peer be modified too on the Windows platform? --Semyon On 09/21/2017 10:56 PM, Alexander

Gradle test fail; DLLS are missing (Windows 10)

2017-09-25 Thread David Bimamisa
Hi all, I'm trying to build OpenJFX-8u on a Windows 10 machine and I stuck in the test task of the fxpackager module. I'm getting the following exception: com.oracle.tools.packager.APITest > testRuntimes FAILED java.lang.RuntimeException: Not found MSVC dlls at

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

2017-09-25 Thread Alexander Zvegintsev
Hi Sergey, Thanks for catching this, this is an issue which should be addressed. Thanks, Alexander. On 23/09/2017 08:01, Sergey Bylokhov wrote: Hi, Alexander. How can we be sure that the parent frame will not be disposed while we use a pointer? long ownerWindowPtr =

Re: [10] Review request for 8185634, 8185634: Java Fx-Swing dialogs appearing behind main stage

2017-09-25 Thread Alexander Zvegintsev
Hi Dmitry, From my understanding JavaFX stage can't be easily integrated in JDK to support orderWindow() approach, addChildWindow() is a native(and the simplest) way to maintain one window above other one, should be called only once. IIUC the main concert of JDK-8080729 that child windows