HI Semyon,
Please see my answer to Dmitry
Hi Dmitry,
From my understanding JavaFX stage can't be easily integrated in JDK to
support orderWindow() approach,
addChildWindow() is a native(and the simplest) way to maintain one window above
other one, should be called only once.
IIUC the
I did a fairly quick review and ran tests on two platforms. It looks
good to me. I have some minor formating nits:
PathConsumer2D.java:
1. In the following:
+public DPathConsumer2D wrapPath2d(Path2D p2d)
+{
the opening curly brace can go at the end of the method declaration
(same
_FX patch_
The new tests run fine for me on all three platforms. I noticed a couple
issues while reviewing it:
1. All robot-based tests should be in the test.robot.** package
hierarchy, such that they are only enabled with "-PUSE_ROBOT=true" -- I
recommend to put them in a new
Hi Alexander,
In CPlatformWindow.java change you used addChildWindow(), but we get rig
of addChildWindow() in 8080729 and start to manage windows order on java
side. Can you test that this change doesn't cause any ordering issues
with modal and non-modal child and sibling windows on mac?
Thank yo for clarification, looks fine.
On 07/11/2017 10:11, Alexander Zvegintsev wrote:
Hi Sergey,
I am not able to crash it on several platforms, except one case:
if we are terminating JavaFX application while EDT processing some long
task. But it is unrelated to the fix and reproducible
Victor, Kevin,
Please review fix for build failure caused by the previous fix for
https://bugs.openjdk.java.net/browse/JDK-8185877.
JIRA: https://bugs.openjdk.java.net/browse/JDK-8190863
Webrev: http://cr.openjdk.java.net/~asemenyuk/8190863/webrev.00/
Testing done: built and verified on
Hi Sergey,
I am not able to crash it on several platforms, except one case:
if we are terminating JavaFX application while EDT processing some long
task. But it is unrelated to the fix and reproducible on current builds.
I've filed a separate bug JDK-8190329
