Re: javapackager feedback and questions

2017-11-30 Thread Scott Palmer
I’m using javapackager to generate native installers for several services and GUI applications. I would be using it for some command line tools as well, but it doesn’t yet support “console” applications on Windows. I.e. you can’t make javapackager with javapackager. I’ve filed an issue for that

[10] Review request: 8192867: Update version of Lucene in license file to 7.1.0

2017-11-30 Thread Kevin Rushforth
Phil, Please review the following follow-up fix to the Lucene 7.1.0 upgrade. I forgot to change the version in the license file: https://bugs.openjdk.java.net/browse/JDK-8192867 The one line diff is in JBS, and repeated here: diff --git a/apps/samples/Ensemble8/legal/lucene.md

Re: javapackager feedback and questions

2017-11-30 Thread Mani Sarkar
Hi Victor, To answer your query about how javapackager can be made better, packr ( https://github.com/libgdx/packr) and FPM ( https://github.com/jordansissel/fpm) are two great examples in this space. If we can pool together some of the features from both, it would certainly draw attention of

Re: javapackager feedback and questions

2017-11-30 Thread Michael Hall
> On Nov 30, 2017, at 6:16 PM, Kevin Rushforth > wrote: > > Hi Michael, > > We realized that the javapackger CLI JEP wasn't quite ready, and was out of > scope for JDK 10 anyway, so we withdrew it in order to file a new JEP later. > > Related to this, we are

Re: javapackager feedback and questions

2017-11-30 Thread Kevin Rushforth
Hi Michael, We realized that the javapackger CLI JEP wasn't quite ready, and was out of scope for JDK 10 anyway, so we withdrew it in order to file a new JEP later. Related to this, we are soliciting input as to how people are using the javapackager (see Victor's question below). So we'd

Re: javapackager feedback and questions

2017-11-30 Thread Martijn Verburg
Hi Victor, I can answer the last Q. It's for two products, one is Censum our GC Log analyser (Java swing desktop app, yes they still exist! ;p) and the second is a stand alone Java 'daemon' for our APM SaaS tool (illuminate). jlink and javapackager is a powerful combination for us, so thanks

Re: [10] Review request: 8185923: Bump minimum gradle version to 4.3 for JDK10

2017-11-30 Thread Johan Vos
FWIW, I'm +1 on this. We're using 4.3.1 for building JavaFX on mobile. - Johan On Thu, Nov 30, 2017 at 6:36 PM Kevin Rushforth wrote: > Hi Phil, > > Please review the following fix to make gradle 4.3 the minimum version: > >

[10] Review request: 8185923: Bump minimum gradle version to 4.3 for JDK10

2017-11-30 Thread Kevin Rushforth
Hi Phil, Please review the following fix to make gradle 4.3 the minimum version: https://bugs.openjdk.java.net/browse/JDK-8185923 http://cr.openjdk.java.net/~kcr/8185923/webrev.00/ We've already been using 4.3 for a few weeks, so it is time to enforce it as the minimum in preparation for

Re: javah deprecated?

2017-11-30 Thread Kevin Rushforth
Yes, something along those lines is what I was thinking. Preferably it would be added in an existing class in the javafx.web module rather than a new class if a suitable one can be found. In either case, it will need to be done in a way that does not expose these constants as part of the

Re: javah deprecated?

2017-11-30 Thread Johan Vos
Hi Kevin, Just to make sure I understand this approach: you want a (new or existing) Foo.Java file in the modules/javafx.web space that contains e.g. this: public static int DIRECTIONALITY_LEFT_TO_RIGHT = Character. DIRECTIONALITY_LEFT_TO_RIGHT; Applying javac -h (which the build already does)

Java Packager fails to create macOS or Windows Bundle

2017-11-30 Thread Dmitry Beloborodov
(Two months later) Please fix bug https://bugs.openjdk.java.net/browse/JDK-8179033 See patch below (or previous letter http://mail.openjdk.java.net/pipermail/openjfx-dev/2017-October/020878.html) See example on GitHub to check https://github.com/dbelob/multiplatform-distribution How to build

Re: javah deprecated?

2017-11-30 Thread Kevin Rushforth
Hi Johan, Thanks for filing the bug. If we really do need Character and IDN, then the cleanest approach might be to define new fields in a suitable JavaFX class and assign the appropriate values to them. -- Kevin Johan Vos wrote: I filed a bug

Re: javah deprecated?

2017-11-30 Thread Johan Vos
The headers are required indeed. modules/javafx.web/src/main/native/Source/WTF/wtf/unicode/java/UnicodeJava.h includes java_lang_Character.h in order to access the static final fields in Character.java - Johan On Thu, Nov 30, 2017 at 12:07 PM Johan Vos wrote: > There was

Re: javah deprecated?

2017-11-30 Thread Johan Vos
There was a related issue at https://bugs.openjdk.java.net/browse/JDK-8170591 about going back to javah instead of javac -h but that doesn't talk about why the headers for Character and IDN are needed. I'm building without those headers (takes almost 1 hour though to build webkit on linux) so

Re: javapackager feedback and questions

2017-11-30 Thread Mani Sarkar
Thanks Victor for you response and invite. I'll get back with details for your query. Just for your info, I was referring to javapackager in the context of Java 9 built artifacts. On Thu, 30 Nov 2017 09:28 Michael Hall, wrote: > > > On Nov 29, 2017, at 5:18 PM,

Re: javah deprecated?

2017-11-30 Thread Johan Vos
I filed a bug (https://bugs.openjdk.java.net/browse/JDK-8192806) and I am looking into it. It seems a bit weird to me that the java.lang.Character and java.net.IDN header files are needed. I'll remove them and see where it fails. But if they are needed (and they probably are), it won't be easy to

Re: javapackager feedback and questions

2017-11-30 Thread Michael Hall
> On Nov 29, 2017, at 5:18 PM, victor.droz...@oracle.com wrote: > > Hi, Mani. > > Thanks for providing the feedback! > We will consider adding more examples and more details in the docs as you > proposed(there is an arg named jvmOptions but that's not mentioned in the > table). > Looks like

Re: javapackager feedback and questions

2017-11-30 Thread Michael Paus
Hi, I am wondering why you can say that ".dmg and .msi packaging work very well" because there is this still open bug https://bugs.openjdk.java.net/browse/JDK-8179033 which keeps me from building DMG files on Java 9. Are you still using Java 8? Michael Am 29.11.17 um 12:48 schrieb Mani