Re: Proposal For Inclusion of Robot and ParametersImpl in the Public API

I didn't realize "_1" is an escape character in JNI method naming and is only needed when the method has a "_" in its' name. Nevermind! On Fri, Dec 22, 2017 at 2:57 PM, Michael Ennen wrote: > I have made quite a bit of good progress I think: > >

Re: Updated OpenJFX build instructions

I did set them, but... if I set them in bash they disappear the next time I launch it, which made me think they are not being set properly for some reason even though they appear in `export -p` immediately after. Launching bash as admin didn't do anything (I thought write permissions issue). So I

Re: Updated OpenJFX build instructions

Thanks for the feedback...I'll note it. As for the build failure, did you install Visual Studio 2017 and set the two env variables (VS150COMNTOOLS and MSVC_VER) to point to it? If so, then it should determine WINSDK_DIR without anything else needed. -- Kevin Nir Lisker wrote: Thanks

Re: Updated OpenJFX build instructions

Thanks Kevin, I'm going through the process now on Win 10. A few things to note: - In the Platform Prerequisites/cygwin it says to make sure mercurial package is installed. Later, under Common Prerequisites/Mercurial it says "you can also install Mercurial as a cygwin package". It's not clear

Re: Proposal For Inclusion of Robot and ParametersImpl in the Public API

I have made quite a bit of good progress I think: https://github.com/brcolow/openjfx/commit/d92ef24101cf32dfc07b21bdcb575528d8a58eaf The public API is starting to look much cleaner:

Re: Updated OpenJFX build instructions

Thanks for taking the time to do this, Kevin. On Fri, Dec 22, 2017 at 11:13 AM, Kevin Rushforth < kevin.rushfo...@oracle.com> wrote: > [resend with typo fixed in Subject line] > > I did a first pass over the build instructions on the OpenJFX Wiki [1]. I > think I cleaned up the worst of the

Updated OpenJFX build instructions

[resend with typo fixed in Subject line] I did a first pass over the build instructions on the OpenJFX Wiki [1]. I think I cleaned up the worst of the inaccuracies, and added some information that will make it easier to build. I'm not the best person to see whether anything important is

Updated OpenJFX buld instructions

I did a first pass over the build instructions on the OpenJFX Wiki [1]. I think I cleaned up the worst of the inaccuracies, and added some information that will make it easier to build. I'm not the best person to see whether anything important is missing, though. Someone less familiar with

RFR : JDK-8192056 : Memory leak when removing javafx.scene.shape.Sphere-objects from a group or container

Hi Kevin & Ajit, Request you to review this fix Issue: https://bugs.openjdk.java.net/browse/JDK-8192056 Webrev: http://cr.openjdk.java.net/~arapte/fx/8192056/webrev.02 Regards, Ambarish

[11] Review Request: JDK-8190411 NPE in SliderSkin:140 if Slider.Tooltip.autohide is true

Hi Kevin, Ajit Request you to review following fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8190411 Webrev: HYPERLINK "http://cr.openjdk.java.net/%7Epkbalakr/fx/8190411/webrev.00/"http://cr.openjdk.java.net/~pkbalakr/fx/8190411/webrev.00/ Regards, Prem