RE: [8u-Backport] Review request for 8185634, 8187803 : Java Fx-Swing dialogs appearing behind main stage

2018-01-17 Thread Dipak Kumar
Hi Semyon, Could you please review the changes (also have a look at Phil's comment in trailing mail) and let me know your comments. Thanks Kevin and Phil. I have incorporated the changes suggested for unit tests in JavaFx side. Request you to have a look. Please find updated webrev at -

Re: [10] Review request: 8195075: Old app window is not reactivatable

2018-01-17 Thread Alexey Semenyuk
Hi Kevin, My bad, I didn't look carefully at "Fix Version" in the JIRA record. Yes, the subject of the email is misleading. Should I resend it with the proper subject? - Alexey On 1/17/2018 6:30 PM, Kevin Rushforth wrote: I see that this bug was (correctly) targeted for 11 and not for 10.

Re: [10] Review request: 8195075: Old app window is not reactivatable

2018-01-17 Thread Kevin Rushforth
I see that this bug was (correctly) targeted for 11 and not for 10. I guess the subject line is wrong? -- Kevin Alexey Semenyuk wrote: Victor, Please review my changes for fixing the issue: "JDK-8195075: Old app window is not reactivatable" JIRA:

[10] Review request: 8195075: Old app window is not reactivatable

2018-01-17 Thread Alexey Semenyuk
Victor, Please review my changes for fixing the issue: "JDK-8195075: Old app window is not reactivatable" JIRA: https://bugs.openjdk.java.net/browse/JDK-8195075 Webrev: http://cr.openjdk.java.net/~asemenyuk/8195075/webrev.00/ - Alexey

Re: [8u-Backport] Review request for 8185634, 8187803 : Java Fx-Swing dialogs appearing behind main stage

2018-01-17 Thread Kevin Rushforth
I think you mean https://bugs.openjdk.java.net/browse/JDK-8187803 for the AWT/Swing side... -- Kevin Phil Race wrote: The AWT/Swing side of this needs to be bug https://bugs.openjdk.java.net/browse/JDK-8185634 One thing I notice is that in XWindowPeer.java the calculation for the value of

Re: [8u-Backport] Review request for 8185634 : Java Fx-Swing dialogs appearing behind main stage

2018-01-17 Thread Phil Race
The AWT/Swing side of this needs to be bug https://bugs.openjdk.java.net/browse/JDK-8185634 One thing I notice is that in XWindowPeer.java the calculation for the value of transientForWindow is different .. because you don't have the fix for https://bugs.openjdk.java.net/browse/JDK-8021961 :

Re: [8u-Backport] Review request for 8185634, 8187803 : Java Fx-Swing dialogs appearing behind main stage

2018-01-17 Thread Kevin Rushforth
Hi Dipak, To underscore the fact that the AWT part of the change has to be pushed under a separate bug ID I have modified the subject line. The FX half of the implementation changes look fine. I tested it on Linux and it works as expected. There are two problems with the unit tests: 1. The