[11] Review request: 8195801: Replace jdk.internal.misc.Unsafe with sun.misc.Unsafe in MarlinFX

Hi Laurent and Phil, Please review the following fix: https://bugs.openjdk.java.net/browse/JDK-8195801 http://cr.openjdk.java.net/~kcr/8195801/webrev.00/ This removes the dependency on the internal jdk.internal.misc.Unsafe class, and goes back to using sun.misc.Unsafe, which is still

Re: lipjpeg7 in static library

> In the end, we link all static libs + object files in a single executable. I see. I had missed that you said "libjavafx_iio.a", meaning static linking. No, I don't know how to make that work, either. Name mangling might be the best solution then. -- Kevin Johan Vos wrote: At the risk

Re: lipjpeg7 in static library

At the risk of being stupid, but I don't see how I could make the JPEG symbols invisible, as they are still needed by the native functions in javafx_iio (in jpegloader.c). If they are invisible, jpegloader.o won't be able to access them either, no? In the end, we link all static libs + object

Re: JDK-8196130: Eclipse configuration files need to be updated

Ah, I see. Then yes, just removing the old ones is fine. As for the larger question, unless there are dependencies on apps, you can assume that the only ones you care about are the ones created by "gradle sdk". -- Kevin Nir Lisker wrote: So this is why I was asking about the optional

Re: JDK-8196130: Eclipse configuration files need to be updated

So this is why I was asking about the optional stuff: 'graphics' module has BOTH build/resources/jsl-decora build/resources/jsl-prism and build/gensrc/jsl-decora build/gensrc/jsl-prism That led me to think that when the new dependencies were added the old ones weren't removed. Those that

Re: JDK-8196130: Eclipse configuration files need to be updated

One more thing about the specific path you mentioned as not being there. path="build/resources/jsl-decora"/> path="build/resources/jsl-prism"/> These are still being created by 'gradle sdk', but the path is wrong (the files moved in JDK 9) and should be: build/gensrc/jsl-decora

Re: JDK-8196130: Eclipse configuration files need to be updated

Nir Lisker wrote: Iv'e removed all the classpath dependencies that were causing errors. I don't mind sorting out the rest of the files while at it, though for that there are a few things I'm not sure about: 1. Some dependencies are marked as optional and as such they don't cause errors,

JDK-8196130: Eclipse configuration files need to be updated

Iv'e removed all the classpath dependencies that were causing errors. I don't mind sorting out the rest of the files while at it, though for that there are a few things I'm not sure about: 1. Some dependencies are marked as optional and as such they don't cause errors, but they are still missing.

Re: Instructions for working on OpenJFX

Now available here: https://bugs.openjdk.java.net/browse/JDK-8196130 You can send me your patch and I'll review / push it. -- Kevin Nir Lisker wrote: Submitted 9052392 to fix Eclipse config files. On Thu, Jan 25, 2018 at 1:22 AM, Kevin Rushforth