[11] Review request: 8146672: [Windows] Support cmake ninja build

2018-02-16 Thread Arunprasad Rajkumar
Hi, Please review the simple fix to enable ninja build generation from cmake on Windows. Linux and macOS builds are already supports ninja build. JBS: https://bugs.openjdk.java.net/browse/JDK-8146672 Webrev: http://cr.openjdk.java.net/~arajkumar/8146672/webrev Thanks, Arun

[11] Review request for 8198316: MediaPlayer crashes when playing m3u8 files on macOS High Sierra 10.13.2

2018-02-16 Thread Alexander Matveev
Hi Kevin, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8198316 Fixed crash with HLS streams on OS X 10.13. Thanks, Alexander

Re: Updating class javafx.beans.binding.When

2018-02-16 Thread Kevin Rushforth
This will take me a bit more time to look at than I have right now (and Monday is a US holiday), so one quick comment for now: The refactoring must not alter any public API signatures for exported packagers, and must be behavior neutral. So if there are unit tests that pass without your fix an

Re: Updating class javafx.beans.binding.When

2018-02-16 Thread Nir Lisker
Let's start with the refactoring then. Before I submit a bug let's check that this plan makes sense. Attached webrev for discussion. Changes: * Main change was to the XxxCondition classes. Instead of having 4 combinations of primitives and observables I used the unification approach that NumberCon