Re: Monocle Headless BufferOverflowException (Issue + Fix)
>From my limited testing, the issue is still present in 8u172 b03 (early access) and 9.0.1+11 (that is, assuming it is the same bug which I am crossing my fingers about!). Thanks for taking this back up, John. On Fri, Feb 23, 2018 at 4:45 PM, Kevin Rushforth wrote: > > In general, what should we do when we find bugs in version 8 but the >> latest development is happening on version 11? Open the bug, or test it >> against the latest version first? >> > > The latter is preferable if it is possible to test it on the latest > version. > > Thanks. > > -- Kevin > > > > John Neffenger wrote: > >> On 02/23/2018 02:29 PM, Michael Ennen wrote: >> >>> Here is the issue: >>> >>> https://gitlab.com/openjfxepd/jfxpatch/issues/1 >>> >>> Thanks to John Neffenger for taking the time to put this together! I >>> wanted to make this work was known to Kevin and the team. >>> >> >> I'm so glad you found it! I posted a link to the issue, along with two >> others, on this mailing list a year ago, but I think people were too busy >> with all the Java 9 changes happening at the time (rightfully so). >> >> I was reluctant to open the official bugs on the Oracle page before >> testing whether they still occur in the latest version. Actually, I haven't >> even had the time to check whether they still occur in the latest OpenJFX 8. >> >> In general, what should we do when we find bugs in version 8 but the >> latest development is happening on version 11? Open the bug, or test it >> against the latest version first? >> >> Thanks, >> John >> > -- Michael Ennen
Re: Monocle Headless BufferOverflowException (Issue + Fix)
In general, what should we do when we find bugs in version 8 but the latest development is happening on version 11? Open the bug, or test it against the latest version first? The latter is preferable if it is possible to test it on the latest version. Thanks. -- Kevin John Neffenger wrote: On 02/23/2018 02:29 PM, Michael Ennen wrote: Here is the issue: https://gitlab.com/openjfxepd/jfxpatch/issues/1 Thanks to John Neffenger for taking the time to put this together! I wanted to make this work was known to Kevin and the team. I'm so glad you found it! I posted a link to the issue, along with two others, on this mailing list a year ago, but I think people were too busy with all the Java 9 changes happening at the time (rightfully so). I was reluctant to open the official bugs on the Oracle page before testing whether they still occur in the latest version. Actually, I haven't even had the time to check whether they still occur in the latest OpenJFX 8. In general, what should we do when we find bugs in version 8 but the latest development is happening on version 11? Open the bug, or test it against the latest version first? Thanks, John
Re: Monocle Headless BufferOverflowException (Issue + Fix)
On 02/23/2018 02:29 PM, Michael Ennen wrote: Here is the issue: https://gitlab.com/openjfxepd/jfxpatch/issues/1 Thanks to John Neffenger for taking the time to put this together! I wanted to make this work was known to Kevin and the team. I'm so glad you found it! I posted a link to the issue, along with two others, on this mailing list a year ago, but I think people were too busy with all the Java 9 changes happening at the time (rightfully so). I was reluctant to open the official bugs on the Oracle page before testing whether they still occur in the latest version. Actually, I haven't even had the time to check whether they still occur in the latest OpenJFX 8. In general, what should we do when we find bugs in version 8 but the latest development is happening on version 11? Open the bug, or test it against the latest version first? Thanks, John
Re: Monocle Headless BufferOverflowException (Issue + Fix)
Good point about the OCA, I have sent an email just now to John Neffenger. Hopefully he is still interested in this topic :). I will file the bug report after hopefully getting into contact with John. Thanks Kevin, And no rush on the Robot review, just didn't want you to totally forget - I know how it is, Michael On Fri, Feb 23, 2018 at 3:36 PM, Kevin Rushforth wrote: > I haven't seen this bug, and I did a quick search and don't find it. Go > ahead and file a bug, but unless it is a trivial fix, you will need to > contact the author of the fix and ask him to sign the OCA before we could > take it. > > > (P.S. When is ramp down phase 2 over? :) ). > > Oh, right. We're actually at GAC for JDK 10 now. I owe you a review of the > Robot API... > > -- Kevin > > > > > Michael Ennen wrote: > >> Hello, >> >> When doing some testing with TestFX running in headless mode >> via Monocle I came across a BufferOverflowException. >> >> After some google searching it seems that someone has come >> across this before me and created a GitLab repository with the >> full issue details and a suggested fix! I was wondering if this >> has ever been brought to the attention of the JavaFX devs and if >> there was a corresponding bug in JBS. >> >> Here's the commit: >> >> https://gitlab.com/openjfxepd/jfxpatch/commit/f7c341775e5258 >> e790a049f3fdce4a >> 956ef665c7 >> >> Here is the issue: >> >> https://gitlab.com/openjfxepd/jfxpatch/issues/1 >> >> Thanks to John Neffenger for taking the time to put this together! I >> wanted to make this work was known to Kevin and the team. >> >> Thanks very much, >> >> (P.S. When is ramp down phase 2 over? :) ). >> >> >> >
Re: Monocle Headless BufferOverflowException (Issue + Fix)
I haven't seen this bug, and I did a quick search and don't find it. Go ahead and file a bug, but unless it is a trivial fix, you will need to contact the author of the fix and ask him to sign the OCA before we could take it. > (P.S. When is ramp down phase 2 over? :) ). Oh, right. We're actually at GAC for JDK 10 now. I owe you a review of the Robot API... -- Kevin Michael Ennen wrote: Hello, When doing some testing with TestFX running in headless mode via Monocle I came across a BufferOverflowException. After some google searching it seems that someone has come across this before me and created a GitLab repository with the full issue details and a suggested fix! I was wondering if this has ever been brought to the attention of the JavaFX devs and if there was a corresponding bug in JBS. Here's the commit: https://gitlab.com/openjfxepd/jfxpatch/commit/f7c341775e5258e790a049f3fdce4a 956ef665c7 Here is the issue: https://gitlab.com/openjfxepd/jfxpatch/issues/1 Thanks to John Neffenger for taking the time to put this together! I wanted to make this work was known to Kevin and the team. Thanks very much, (P.S. When is ramp down phase 2 over? :) ).
Monocle Headless BufferOverflowException (Issue + Fix)
Hello, When doing some testing with TestFX running in headless mode via Monocle I came across a BufferOverflowException. After some google searching it seems that someone has come across this before me and created a GitLab repository with the full issue details and a suggested fix! I was wondering if this has ever been brought to the attention of the JavaFX devs and if there was a corresponding bug in JBS. Here's the commit: https://gitlab.com/openjfxepd/jfxpatch/commit/f7c341775e5258e790a049f3fdce4a 956ef665c7 Here is the issue: https://gitlab.com/openjfxepd/jfxpatch/issues/1 Thanks to John Neffenger for taking the time to put this together! I wanted to make this work was known to Kevin and the team. Thanks very much, (P.S. When is ramp down phase 2 over? :) ). -- Michael Ennen
Re: Layout bug with SwingNode ?
This does sound like a bug. Can you file it at http://bugreport.java.com/ ?
One possible workaround might be to set the size of the scene when you
first create it:
new Scene(root, WIDTH, HEIGHT)
-- Kevin
Adam Granger wrote:
Greeting,
(https://stackoverflow.com/questions/48937412/node-snapshot-causing-layout-issue)
Using JavaFX 9.0.4 I'm embedding some 3rd party Swing content in a
JavaFX app. The 3rd party content already has its own preferred size,
so I'm wrapping it with a StackPane to stretch it out...
However, when node.snapshot() is called this causes the SwingNode to
jump back to its preferred size, manually resizing the window causes
it to fill the window again.
I've also identified this only occurs if the scene is first shown
without content and the content is added later.
Is this a bug? How can I work around it?
The following example recreates the issue
public
class
NodeSnapshotFunny
extends
Application
{
@Override
public
void
start
(
Stage
stage
)
throws
Exception
{
SwingNode
swingNode
=
new
SwingNode
();
Button
button
=
new
Button
(
"Test"
);
button
.
setOnAction
(
event
->
{
WritableImage
image
=
button
.
snapshot
(
null
,
null
);
});
StackPane
stackPane
=
new
StackPane
(
swingNode
);
Scene
scene
=
new
Scene
(
stackPane
);
stage
.
setScene
(
scene
);
stage
.
show
();
stackPane
.
getChildren
().
add
(
button
);
SwingUtilities
.
invokeLater
(()
->
{
JPanel
jPanel
=
new
JPanel
();
jPanel
.
setPreferredSize
(
new
Dimension
(
300
,
300
));
jPanel
.
setBackground
(
Color
.
red
);
swingNode
.
setContent
(
jPanel
);
});
}
public
static
void
main
(
String
[]
args
)
{
launch
(
args
);
}
}
[11] Review request for 8193207: [TESTBUG] Unit test case to check user agent string
Hi Kevin, Please review the below simple fix. JIRA: https://bugs.openjdk.java.net/browse/JDK-8193207 webrev: http://cr.openjdk.java.net/~mbilla/8193207/webrev.00/ Thanks, Murali
Layout bug with SwingNode ?
Greeting,
(https://stackoverflow.com/questions/48937412/node-snapshot-causing-layout-issue)
Using JavaFX 9.0.4 I'm embedding some 3rd party Swing content in a
JavaFX app. The 3rd party content already has its own preferred size,
so I'm wrapping it with a StackPane to stretch it out...
However, when node.snapshot() is called this causes the SwingNode to
jump back to its preferred size, manually resizing the window causes
it to fill the window again.
I've also identified this only occurs if the scene is first shown
without content and the content is added later.
Is this a bug? How can I work around it?
The following example recreates the issue
public
class
NodeSnapshotFunny
extends
Application
{
@Override
public
void
start
(
Stage
stage
)
throws
Exception
{
SwingNode
swingNode
=
new
SwingNode
();
Button
button
=
new
Button
(
"Test"
);
button
.
setOnAction
(
event
->
{
WritableImage
image
=
button
.
snapshot
(
null
,
null
);
});
StackPane
stackPane
=
new
StackPane
(
swingNode
);
Scene
scene
=
new
Scene
(
stackPane
);
stage
.
setScene
(
scene
);
stage
.
show
();
stackPane
.
getChildren
().
add
(
button
);
SwingUtilities
.
invokeLater
(()
->
{
JPanel
jPanel
=
new
JPanel
();
jPanel
.
setPreferredSize
(
new
Dimension
(
300
,
300
));
jPanel
.
setBackground
(
Color
.
red
);
swingNode
.
setContent
(
jPanel
);
});
}
public
static
void
main
(
String
[]
args
)
{
launch
(
args
);
}
}
