[11] RFR JDK-8202743: Dashed Stroke randomly painted incorrectly, may freeze application

2018-05-24 Thread Laurent Bourgès
Please review this simple fix for MarlinFX Dasher: JBS: https://bugs.openjdk.java.net/browse/JDK-8202743 webrev: http://cr.openjdk.java.net/~lbourges/marlinFX/marlinFX-8202743.0/ Github Pull request: https://github.com/javafxports/openjdk-jfx/pull/87 Notes: - (D)Dasher changes corresponds to

RFR: 8129582: Controls slow considerably when displaying RTL-languages text on Linux

2018-05-24 Thread Phil Race
Please review this fix for a performance problem in Pango Text Layout. The root cause was pointed out by itai...@gmail.com, that the fontmap is an expensive thing to create, and we were recreating it on each call to layout. By caching it we can avoid this huge overhead. Bug : https://bugs.openj

Re: OpenJFX code review policies, etc.

2018-05-24 Thread Kevin Rushforth
Phil pointed out one glaring typo in the summary and also a couple things in the details that could be clarified. The short version of the proposal is: ... 2. Revised code review policies for different types of changes: simple, low-impact fixes (1 Reviewer); higher-impact fixes (2 Reviewers +

Re: OpenJFX code review policies, etc.

2018-05-24 Thread Nir Lisker
Thanks for the detailed plan Kevin, I will provide an initial list of reviewers to the registrar based on past > contributions, and also recognizing Committers who have become experts in > their area. It will be a good idea to list the reviewers/experts (names and mail) according to their field,

Re: JavaFX roadmap

2018-05-24 Thread Kevin Rushforth
[changing the subject so we can keep the threads separate] I think Johan hits the nail on the head here. Realistically, "large feature X" is only going to happen if there are enough resources to make it happen. Of course smaller features / enhancements can be done by part-time contributors, bu

Re: OpenJFX code review policies, etc.

2018-05-24 Thread Johan Vos
Hi Paul, That is a great question, and it has surfaced a number of times here. In my opinion, the direction of the project is mainly determined by the contributors. In a good eco-system, this lead to good results. In general, I think that if there is a large interest from many companies and indivi

OpenJFX code review policies, etc.

2018-05-24 Thread Paul Ray Russell
"and the desired direction of the Project" - perhaps, Kevin, it would be worth you taking a few words describing what this "direction" is. We all know with JFX is currently, but what is the future direction? What are contributors working towards in the long run? I'm sure we've all got our own pers