Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

Thanks for confirming that. Mandy On 6/14/18 3:53 PM, Kevin Rushforth wrote: I verified on an earlier version of the patch that it wasn't in the docs, but it would be good for Prasanta to double-check. -- Kevin On 6/14/2018 1:29 PM, Phil Race wrote: you surely mean @since 11 I believe it

Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

I verified on an earlier version of the patch that it wasn't in the docs, but it would be good for Prasanta to double-check. -- Kevin On 6/14/2018 1:29 PM, Phil Race wrote: you surely mean @since 11 I believe it has been verified that it is excluded from the docs build .. right Prasanta ?

Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

On 6/14/18 1:29 PM, Phil Race wrote: you surely mean @since 11 Oops typo. Yes @since 11 Mandy

Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

you surely mean @since 11 I believe it has been verified that it is excluded from the docs build .. right Prasanta ? -phil On 06/14/2018 01:26 PM, mandy chung wrote: I reviewed the module-info.java change. @since 12 is missing in jdk.unsupported.desktop module-info.java Otherwise it's

Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

I reviewed the module-info.java change. @since 12 is missing in jdk.unsupported.desktop module-info.java Otherwise it's fine. Does the docs build exclude jdk.unsupported.desktop? You might have confirmed that that I missed. Mandy On 6/13/18 12:48 AM, Prasanta Sadhukhan wrote: Hi Phil,

Re: [11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

+1 from me for the JDK changes. -phil. On 06/13/2018 06:04 PM, Kevin Rushforth wrote: The JDK changes look good to me, and as far as I have tested them, it works for me. I haven't tried Drag and Drop yet with the latest interface changes. To repeat something I've mentioned before, just so

[11] RFR JDK-8202277:WebView image capture fails with standalone FX due to dependency on javafx.swing

Hi Kevin, All Please review the fix to remove the dependancy on javafx.swing module from javafx.web Bug: https://bugs.openjdk.java.net/browse/JDK-8202277 webrev: http://cr.openjdk.java.net/~psadhukhan/fx/8202277/webrev/ Regards Prasanta

Re: [11] Review request: 8200446: Update minimum boot JDK to 10

Thanks for the reminder. This is good advice that we should all strive to follow. -- Kevin On 6/14/2018 6:37 AM, Nir Lisker wrote: Once this is done, we can start using JDK 10 features, such as 'var' for local variables (although please don't take this as a license to use 'var'

Re: [11] Review request: 8200446: Update minimum boot JDK to 10

> > Once this is done, we can start using JDK 10 features, such as 'var' for > local variables (although please don't take this as a license to use 'var' > gratuitously). I'll remind that there's a style guide at http://openjdk.java.net/projects/amber/LVTIstyle.html. - Nir On Thu, Jun 14, 2018

[11] Review request: 8200446: Update minimum boot JDK to 10

Please review the following to bump the minimum boot JDK required for JavaFX builds to JDK 10. Note that the review will be done on github, but it is OK to reply to this thread with comments if you don't have a github account. https://bugs.openjdk.java.net/browse/JDK-8200446

[11] RFR JDK-8204956 : Cleanup whitespace after fix for JDK-8200285

Hi Kevin, Please review this correction fix : Bug: https://bugs.openjdk.java.net/browse/JDK-8204956 Webrev: http://cr.openjdk.java.net/~arapte/fx/8204956/webrev.00/ Regards, Ambarish

Re: negative line spacing in Text

I'm all in favor of following W3C CSS, but you can't specify negative values in W3C CSS line-height property either. The minimum value is 0 which just collapses everything into the same line, so negative values wouldn't make sense since it would layout the paragraph upside down. Cheers, I looked