Hi all,
The class javafx.beans.binding.When is using eager evaluation of its
arguments [1]. Kevin and I discussed the idea of changing this default
behavior to the more intuitive lazy evaluation as done in a simple ternary
expression. This is a potentially breaking change for current code that
I'm giving a +1 on the implementation changes. I scanned the webrev and
didn't see anything out of place. I compared the diffs of the FX Marlin
0.9.2 with the Java2D 0.9.1 changeset, and there were a few more diffs
than I might have expoected, but nothing jumped out of me as a problem.
Also,
One more thing about the test. All of the OpenJFX unit tests should have
GPL v2 + Classpath Exception (this differs from the JDK).
-- Kevin
On 6/29/2018 10:23 AM, Kevin Rushforth wrote:
I'll plan to review the code today if possible. This will need one
more reviewer, so maybe Phil can also
I'll plan to review the code today if possible. This will need one more
reviewer, so maybe Phil can also review it, since he reviewed the Java2D
patch?
As for my comments on the test:
Finally I think this test should be manually run only if Marlin
renderer is modified.
How to do that ?
